IDempiere/FullMeeting20130501

⇐ Table of Contents | Full Meeting Minutes | Full Meeting 2013-05-01

CarlosRuiz: Good Morning
nmicoud: Bonjour
CarlosRuiz: today is holiday in many countries :-) (including here)
CarlosRuiz: I'll review the peer review queue
nmicoud: yep, here also
nmicoud: can you have a look at ticket 865 ? i've udpated demo.idempiere.com
CarlosRuiz: not many bugs reported for beta - seems like we're in good shape to release a candidate
CarlosRuiz: sure - checking now
nmicoud: yep, we're getting close :)
nmicoud: thanks
CarlosRuiz: ah, and you reported something about info window
nmicoud: yep
nmicoud: a tricky one
CarlosRuiz: So, I log in with Français lang
nmicoud: yes
nmicoud: goto User window
nmicoud: select Carl Boss
nmicoud: Copy the record ; save
CarlosRuiz: :-D how is "User" in french
nmicoud: Utilisateur
CarlosRuiz: --> Impossible denregistrer les modifications : {0}
nmicoud: Yep !!
nmicoud: if you do the same in English or spanish, you would have the 'full' message
CarlosRuiz: got it
nmicoud: ah great !!
CarlosRuiz: --> Could not save changes: Could not save record - Require unique data: EMail Address
nmicoud: First, i though it was because the translated msg 'SaveError' got comma ; so i removed them ; nothing change
CarlosRuiz: debugging
nmicoud: you find someting ? can i help ?
CarlosRuiz: yep
CarlosRuiz: I'm looking at AbstractADWindowContent, line 1294
CarlosRuiz: the message received is not processed - instead is tried again
CarlosRuiz: trying to find why in french is that behavior different than english and spanish
nmicoud: "L'exception culturelle française" :))
nmicoud: will have a look
CarlosRuiz: instead of showing the error SaveErrorNotUnique - is showing the SaveError
CarlosRuiz: well - trying a patch here that solved the problem - but I'm not happy because I still don't know the cause :-)
nmicoud: héhé ; that the 1st step
nmicoud: I don't know if it is important but the translated message of SaveError is "Impossible d'enregistrer les modifications : "
nmicoud: And the displayed message is "Impossible denregistrer les modifications : {0}"
nmicoud: The ' has been removed
CarlosRuiz: ah yes - seems related
CarlosRuiz: definitely the quote is the difference
CarlosRuiz: reading MessageFormat.java has a different treatment for quotes
CarlosRuiz: http://docs.oracle.com/javase/6/docs/api/java/text/MessageFormat.html#patterns
CarlosRuiz: this changeset introduced message formatting for translated messages
CarlosRuiz: https://bitbucket.org/idempiere/idempiere/commits/ccd924ab57d4/
nmicoud: i never notice it on adempiere ; there was some changes ?
CarlosRuiz: so, seems it's breaking some messages with quotes
nmicoud: which can be annoying ; especially in France
CarlosRuiz: just to confirm can you test dropping the quote?
nmicoud: i'll do this on demo.idempiere.com
CarlosRuiz: a new test case to confirm my theory of any message with quotes:
CarlosRuiz: login as GardenAdmin
CarlosRuiz: open System Configurator
CarlosRuiz: copy 2PACK_HANDLE_TRANSLATIONS - change config level to Client and Save
CarlosRuiz: the message says
CarlosRuiz: This is a system parameter, you cant save it as client parameter: {0}
CarlosRuiz: the quote of the "can't" was dropped and the {0} is added
nmicoud: i remove the quote but i got same msg ; is there some cache behind ?
CarlosRuiz: ah yes - messages are cached
nmicoud: will try to access monitor to reset cache
nmicoud: cache has been reset
nmicoud: and message is correct then !
nmicoud: Impossible denregistrer les modifications : Enregistrement impossible - Enregistrement unique exigé : Email
nmicoud: Definitively better :))
nmicoud: I also try to double the quote ; and it seems to work fine
CarlosRuiz: I think ";" can have a problem too
CarlosRuiz: ok, now knowing the cause I'll try a more general patch :-)
nmicoud: good luck
CarlosRuiz: well - I have a patch that seems really simple and solves the problem
nmicoud: nice
CarlosRuiz: is just replacing quotes with two quotes
nmicoud: the easier the better
CarlosRuiz: there is still something curious there - messages are repeated
CarlosRuiz: some messages
CarlosRuiz: like this on sysconfig
CarlosRuiz: "This is a system parameter, you can't save it as client parameter: This is a system parameter, you can't save it as client parameter"
nmicoud: means that the 'SaveError' msg is not displayed ?
CarlosRuiz: in some cases
nmicoud: there is a quote in this message : This is a system parameter, you can't save it as client parameter
nmicoud: can it be linked ?
CarlosRuiz: when the error is set - in this case is set a message with value "Can't Save Client Level"
CarlosRuiz: just that this algorithm - create the message and then add again the message as parameter
nmicoud: Means there is something to fix in https://bitbucket.org/idempiere/idempiere/commits/ccd924ab57d4/ ?
CarlosRuiz: yep
Not-002: [iDempiere] CarlosRuiz_globalqss pushed 1 commit [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/
Not-002: [iDempiere] globalqss 6398e3e - IDEMPIERE-865 log.saveError: problem with translation
Not-002: [iDempiere] CarlosRuiz_globalqss pushed 1 commit [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/
Not-002: [iDempiere] globalqss ab27d09 - IDEMPIERE-865 log.saveError: problem with translation / improvement
nmicoud: can i test or do you others commits ?
CarlosRuiz: you can test
CarlosRuiz: I'm checking 325
nmicoud: ok
Not-002: [iDempiere] CarlosRuiz_globalqss pushed 1 commit [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/
Not-002: [iDempiere] globalqss d224d6b - IDEMPIERE-325 AD_InfoWindow / fix NPE reported by Nicolas
nmicoud: (y)
Not-002: [iDempiere] CarlosRuiz_globalqss pushed 1 commit [+0/-0/±2] https://bitbucket.org/idempiere/idempiere/commits/
Not-002: [iDempiere] globalqss c7ccf28 - IDEMPIERE-889 See Order from other organization in generate invoices
nmicoud: I'm currently trying to test but that's much longer than expected. This morning, i also notice that a view name start with a X : http://jira.idempiere.com/browse/IDEMPIERE-895 .
CarlosRuiz: ah yes
CarlosRuiz: which one are you trying to test?
nmicoud: both (865 and 325)
nmicoud: it's longer because i have to restore sources on my machine
nmicoud: made a little mistake...
CarlosRuiz: hmmm jenkins is stuck
CarlosRuiz: will restart it
Not-002: [iDempiere] CarlosRuiz_globalqss pushed 1 commit [+0/-0/±4] https://bitbucket.org/idempiere/idempiere/commits/
Not-002: [iDempiere] globalqss fe2e627 - IDEMPIERE-888 NPE when opening an account as report from Trial Balance
nmicoud: i've tested your patches related to 865 and 325 and both seems ok ; thanks !
buildmaster: Project iDempiere build #1088: SUCCESS in 6 min 6 sec: http://jenkins.idempiere.com/job/iDempiere/1088/
CarlosRuiz: great
CarlosRuiz: Nicolas, gtg, thanks a lot for reporting and testing those issues
nmicoud: i will do some tests those next 2 days ; maybe i will find others ; thanks for fixing them
CarlosRuiz: installed on demo the latest patches
nmicoud: fine ; Info Order will be operational then ;)
CarlosRuiz: BTW - are you attending conference?
nmicoud: nope :(
nmicoud: i'd like to ; but too much work + children
nmicoud: complicated to find the time
CarlosRuiz: ah - ok - hope we can do cast something
CarlosRuiz: c u then - bye
nmicoud: bye bye