| Not-a748 | [iDempiereDaily] jenkins built #580 completed (success) http://ci.idempiere.org/job/iDempiereDaily/580/ | 03:34 |
|---|---|---|
| *** a42niem has joined #idempiere | 05:22 | |
| Not-a748 | [iDempiere5.1Daily] jenkins built #42 completed (success) http://ci.idempiere.org/job/iDempiere5.1Daily/42/ | 05:32 |
| *** norbertbede has joined #idempiere | 07:24 | |
| *** nmicoud has joined #idempiere | 07:42 | |
| *** CarlosRuiz has joined #idempiere | 08:59 | |
| nmicoud | Hello CarlosRuiz, thanks for taking time to review my tickets :) | 09:13 |
| CarlosRuiz | Hi nmicoud - thanks to you for contributing :-) | 09:13 |
| nmicoud | now i'm on 5.1, that would be easier to submit patches | 09:14 |
| nmicoud | i'll give you some work :p | 09:14 |
| norbertbede | hi all | 09:25 |
| norbertbede | nmicoud. a question | 09:25 |
| norbertbede | i'm start to use import leads ad_user approx 100k trough csv import | 09:25 |
| norbertbede | i test first 1k records. and as result: error message however approx 100 records was not imported | 09:26 |
| norbertbede | i found the reason. is google map callout on c_location | 09:26 |
| norbertbede | so as i found in topics, csv import is like window including callouts | 09:27 |
| norbertbede | i cant guarantee quality of leads so adresses sometimes are corrupted. so the question is: | 09:27 |
| norbertbede | is it better somehow disable for client google coordinate calculation OR change slightly code/review why import skip such issue records | 09:28 |
| norbertbede | wdyt ? maybe this is related to gmail and import csv itself | 09:28 |
| nmicoud | hi norbert | 09:29 |
| nmicoud | i'm not familiar with csv import (i'm still using the 'old' way, ie I_ tables) | 09:29 |
| nmicoud | if you import 100k locations, i fear Google will blacklist you - there should be a limit of requests/day | 09:30 |
| nmicoud | if you want to do the import using csv import, i would advise to do it from Eclipse (there, you should easily deactivate the gps plugin) | 09:31 |
| norbertbede | can we add sysconfig ? | 09:32 |
| nmicoud | Or maybe add a SysConfig key 'ENABLE_GPS_PLUGIN' that will set to N when importing | 09:32 |
| nmicoud | and then set to Y right after | 09:32 |
| nmicoud | suer | 09:32 |
| nmicoud | *sure* | 09:32 |
| norbertbede | yes not nice but helpful for consultant | 09:32 |
| nmicoud | Or perhaps there is a way to kwow if there is a csv import running (in context) | 09:33 |
| norbertbede | maybe csv import should make hardcoded part avoid to call external ws when improt running | 09:33 |
| nmicoud | yes, something like that | 09:33 |
| nmicoud | a trick can be : if Env.getAD_UserID(ctx) > 999999 | 09:33 |
| nmicoud | Records created by SuperUser won't be impacted | 09:34 |
| nmicoud | Or, if you plan to regularly import leads, you can also create a specific user for that purpose and use its userID | 09:34 |
| norbertbede | i prefer make specific behaviour when import - do not call external api's | 09:35 |
| norbertbede | this is more general and can avoid all use cases in all tables in similar cases | 09:35 |
| norbertbede | while external providers will ban us anyway | 09:36 |
| norbertbede | thanks for ideas. make decision. | 09:38 |
| nmicoud | looking in code to see if we could know data is inserting from csv | 09:39 |
| nmicoud | but, i see nothing :( | 09:39 |
| norbertbede | CarlosRuiz whyt to add generic DISABLE_API_CALLS_CSV_IMPORT sysconfig | 09:40 |
| CarlosRuiz | Hi norbertbede - nmicoud | 09:47 |
| CarlosRuiz | DISABLE_API_CALLS_CSV_IMPORT - it doesn't sound good as a generic thing | 09:47 |
| CarlosRuiz | it sounds is specific for every provider | 09:47 |
| CarlosRuiz | I think the suggestion from nmicoud about ENABLE_GPS_PLUGIN sounds better | 09:47 |
| norbertbede | ok. however admin - mainly - in cloud environment must be informed well, else suck when start import a huge data set | 09:48 |
| norbertbede | when installation admin <> tenant admin let say "Tenant Power user" | 09:49 |
| norbertbede | thanks for comments !!! | 09:56 |
| *** norbertbede has quit IRC | 10:44 | |
| *** dagelf_ has quit IRC | 15:01 | |
| *** CarlosRuiz has quit IRC | 15:04 | |
| *** dagelf has joined #idempiere | 15:15 | |
| *** CarlosRuiz has joined #idempiere | 15:17 | |
| *** nmicoud has quit IRC | 16:31 | |
| *** CarlosRuiz has quit IRC | 19:17 | |
| *** CarlosRuiz has joined #idempiere | 19:33 | |
| *** CarlosRuiz has quit IRC | 20:25 | |
| *** CarlosRuiz has joined #idempiere | 20:37 | |
| *** CarlosRuiz has quit IRC | 20:45 | |
| *** a42niem has quit IRC | 23:10 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!