IDempiere/FullMeeting20150513
⇐ Table of Contents | Full Meeting Minutes | Full Meeting 2015-05-13
CarlosRuiz: Good Morning
nmicoud: Bonjour
Kuroshima: Heya
nmicoud: Any chance you can review and integrate https://idempiere.atlassian.net/browse/IDEMPIERE-2244 today ?
CarlosRuiz: ok nmicoud - in queue
CarlosRuiz: first in queue for today :-)
nmicoud: thanks Carlos
Deepak_: Hello Carlos
norbertbede: hi all
norbertbede: have a nice day
Deepak_: I added small patch on https://idempiere.atlassian.net/browse/IDEMPIERE-2617
CarlosRuiz: Hi Deepak_ - Hi norbertbede
Deepak_: this is related to transaction closed issue which I mention earlier
Deepak_: May be regression issue
CarlosRuiz: good Deepak_ - is there a way to reproduce it?
Deepak_: It is reproduced in this way
Deepak_: 1. After starting system, Run account processor from idempieremonitor
Deepak_: 2. Then try to repost any of document
Deepak_: When I tried to post same from idempiere first, then it was working well
Deepak_: Also good if you can look IDEMPIERE-2615
Kuroshima: Is anyone here familiar with drop shipments in iDempiere? I have a business case that might require something similar, but as far as I know, there's no documentation other than the code, and the code seems to go in multiple contradictory directions. My case is simple, iDempiere is used by a manufacturing company that is sometimes asked to deliver to a 3rd party (that is, to someone different than the customer), that is often the cu
Kuroshima: stomer's customer. As far as I understand, that's exactly the drop shipment use case, from the PoV of the customer. The way we're doing it right now, is that we add the address of the third party to the business partner as if it was one of theirs, but that ends up meaning that some business partners end up with a lot of addresses that aren't really theirs, and that makes selecting the delivery address on orders prone to human error
Kuroshima: s. I've looked into the drop shipment functionality in iDempiere, but it seems that iDempiere does not allow making a shipment out of an order that is marked for drop shipment. I assume that it only includes the use case of the company delivering orders via drop shipment from one supplier, right?
CarlosRuiz: Antoni - there is a wiki page where the original requirement was documented ... let me check
CarlosRuiz: http://www.adempiere.com/Sponsored_Development:_Drop_Ship
Kuroshima: Thanks CarlosRuiz. I assume the proposed implementation was never implemented?
Kuroshima: Because what's called there the current implementation is, as that web page says, unusable for my use case
CarlosRuiz: better you test before assume
Deepak_: Antoni, It works..
Deepak_: Carlos, I have one question. I think currently we do not have way to match AP Credit memo + AP invoice + Reciept?
Kuroshima: It seems that my use case is No 3
Deepak_: I am explaining scenario say that we get vendor invoice and want to tag exactly same as vendor invoice paper copy. And there is some over invoiced qty. So we want to enter same and then want to get credit using AP credit memo
Deepak_: So in this case over invoiced qty can be adjusted agains AP credit memo and remaining should match to MR
Deepak_: Currently this scenario do not work as qty on AP Credit memo is considered positive on Match PO-Receipt-Invoice form
norbertbede: any idea how user able to stop reservation on a specific order ? without closing and opening ?
norbertbede: because order e.g. was 3 time delivered but some lines should be changed
Deepak_: norbert, I think we added check quite back to fix over removal of reservation due to free items or extra items recieved
Deepak_: or shipped
Kuroshima: I can find no way, as far as I can see, to "ship" a "customer drop shipping" as described in use case 3, given that Generate Shipments has a hard codded to only accept orders that are not drop shipment.
CarlosRuiz: Deepak_, I think it must be possible to match it in the match form - otherwise I think it's a bug - or a good improvement
Deepak_: Carlos, I just tested. It did not work as expected
Deepak_: So let fix that
Kuroshima: and if I were to manually generate a shipment, by going to the customer shipments window, and a new one, and selecting the order, it will not copy the drop shipment data from the order to the shipment
CarlosRuiz: a drop ship is not shipped - by definition you don't have the stock - use case 3 says the vendor ships
CarlosRuiz: norbertbede, the only order that doesn't make reservation is "non-binding offer"
norbertbede: i know that
norbertbede: let explain
norbertbede: we receive 70 lines 1 order
norbertbede: 30 delivered, 20 purchased
norbertbede: 5 dropped
Kuroshima: CarlosRuiz, I might have red it wrong (English is my 4th language), but AFAIU, in use case 3, it's Monet Co that has implemented ADempiere, while freda uses excel.
norbertbede: meanwhile we start shipment
norbertbede: and order has linked shipments and invoices
norbertbede: but want want e.g. close 1 line or some qty on line
norbertbede: not yet deliered
norbertbede: there is 200 orders here daily
Kuroshima: Freda requests a drop shipment from Monet Co to her customer
norbertbede: and this is totally regular case
norbertbede: :(
Kuroshima: so Monet will have to ship the items, because for Monet it's just an order where it doesn't ship to the customer, but to a 3rd party
norbertbede: in case additional line we create new order but cant stop lines or qty
norbertbede: i thinking about play with field - lostsalesqty
druiz: Hey everyone
Kuroshima: Hello druiz
norbertbede: that us used when close order on document level
CarlosRuiz: Hi druiz
CarlosRuiz: Antoni - I read this "She laboriously re-enters that very order as a purchase order in Monet's webstore" - not sure about the meaning
CarlosRuiz: norbertbede, I think we have managed that reactivating and moving the qty to zero
CarlosRuiz: for the specific line
norbertbede: this doesnt touch other lines ? shipped invoiced ?
Kuroshima: CarlosRuiz, Freda (the 'she' in that sentence) is the customer to Monet Co.
Kuroshima: norbertbede, What we did in similar cases, is reactivate the order, set the quantities to 0, and then prepare and complete it again
Kuroshima: CarlosRuiz, but from the PoV of Monet Co, that is using ADempiere, it's an order from Freda that ships to Mr Escher
Kuroshima: norbertbede, when you prepare, it updates the reservations as you would expect
Deepak_: norbert, reactivation will affect reservation to get negative but once you complete again, it will restored
CarlosRuiz: yes - but for Monet is not a drop ship sales order - because he has the stock
Kuroshima: CarlosRuiz, So, Monet should do as, and I quote
Kuroshima: Monet could simply add Escher as a contact for Freda, and his address as one of Freda's delivery locations, and alter the print format to not print Freda's company name in the deliver to field. Of course, if Monet needed, for example, to send a shipment confirmation to Freda's real address he would need to perform various contortions to get the necessary information. It would probably be better if Freda's name, address and contact
Kuroshima: information were kept as the main order business partner details, and the delivery information was handled separately
Deepak_: Antoni, case is direct shipment. So they can handle by adding BPartner relation
Kuroshima: Deepak_, unfortunately, using partner relationship for ship-to addresses does not work
Deepak_: You should have created BPartner for customer's customer
Deepak_: and create relationship between customer and their customer
Kuroshima: Deepak_, the checkbox is both nor marked as updatable in table and column, and as read only in window and tab, and even if you fix that, it's not added to the dropdown on the sales order
Deepak_: your customer should be invoice partner and one you are shipping should be shipping partner
Kuroshima: so you send the order confirmation to the shipping partner?
Kuroshima: instead of to the one who actually made the order?
Deepak_: See currently there is no order confirmation sent as default
Deepak_: So you may have developed that
Deepak_: So you can control to whom you want to send confirmation
Kuroshima: Deepak_, Yeah, I know, but as the web page states " Of course, if Monet needed, for example, to send a shipment confirmation to Freda's real address he would need to perform various contortions to get the necessary information"
Kuroshima: that's exactly what's not aceptable here
Kuroshima: the report that would print on the order would list the shipping partner and not the one that actually made the order
Kuroshima: The proposed implementation here http://www.adempiere.com/Sponsored_Development:_Drop_Ship
Deepak_: Antoni, this all you may need to customize to reflect correct information on print format
Kuroshima: would actually address my needs, that's why I asked if this was ever integrated into iDempiere
Kuroshima: Deepak_, If every order was like this, there would be no problem, I would customize the print format to show the bill partner instead of the shipping partner, but this use case represents a part of the total orders
Kuroshima: so I would need two print formats, with no rule inside the program letting you decide if a given order should use one or the other
Deepak_: Antoni, you can create a document type if want print format for different scenario
Deepak_: Also looking at your requirement, you may looks looking for case 1
Deepak_: Vendor's dropship
Deepak_: Sorry I am in rush need to leave sortly
Kuroshima: Deepak_, Nope, it's use case 3, customer drop ship
Deepak_: Carlos, can you please review IDEMPIERE-2615 as you touched Date material policy issue on movement recently
Deepak_: Customer dropship case is when you as idempiere user want to ask your vendor to deliver to your customer directly and you will invoice to your customer
Deepak_: Is that your case?
Kuroshima: Deepak_, Read use case 3 again, It's Monet Co that is using ADempiere, not Freda (who uses excel). Freda is requesting a drop ship from Monet
Deepak_: YEs, I noticed that
Deepak_: First time I am reading that
Deepak_: http://www.adempiere.com/Sponsored_Development:_Drop_Ship
Deepak_: this is first time read
Deepak_: but Let me know both scenario works in iDempiere
Deepak_: only you may need to set correct process.
Kuroshima: Deepak_, check the current functionality part of the page
Deepak_: sure, thanks
Kuroshima: it acknowledges that it's (sort of) possible to handle customer drop shipment using standard functionality
Deepak_: I have to rush really
CarlosRuiz: Antoni, I think you're expecting that 100% of your needs are covered - and that's not the usual case - the most usual case is that you need to do some customizations
Kuroshima: but it requires contortions
Kuroshima: CarlosRuiz, No, I'm fine with doing customizations, I only wanted to know if someone else had done this first, and if that could be resused
Kuroshima: reused
Kuroshima: CarlosRuiz, Maybe this was done by Idalica, but never contributed back?
CarlosRuiz: it's in core AFAIR
Kuroshima: CarlosRuiz, Again, use case 3 aligns with my needs perfectly, but reading the code, it doesn't seem to be implemented
Kuroshima: CarlosRuiz, There are multiple warnings that this would break or be inconsistent with the functionality inherited from Compiere, so maybe it's why it was not merged?
Kuroshima: or maybe this was merged into ADempiere after the split?
CarlosRuiz: no - is old
CarlosRuiz: and it was merged
CarlosRuiz: I cannot say it was 100% perfectly tested
CarlosRuiz: so - is ok if you find bugs and raise them for fix
Kuroshima: CarlosRuiz, I found at least one (unrelated) bug for drop shipments: if purchase orders are done manually, the drop shipment partner field on the purchase order has a default filter for suppliers, not customers. That threw me off when I was checking to code to see how far this was implemented
Kuroshima: CarlosRuiz, Time to raise a jira ticket then (I don't like raising jira tickets without asking the cominity if something is really a bug, as I do not want to increase the project overhead)
Kuroshima: CarlosRuiz, Ok, IDEMPIERE-2619 created
Kuroshima: Now to create another ticket for the missing functionality
CarlosRuiz: thanks Antoni
Kuroshima: No problem CarlosRuiz, Too often the problem is that documentation on (i|A)dempiere is outdated or completely inexistent
Kuroshima: IDEMPIERE-2620 created
Kuroshima: CarlosRuiz, I created this one as a new feature instead of a bug, since the functionality doesn't seem to exist in the code base
CarlosRuiz: I think is not a workaround - but maybe that's the way - and the contortion is just to send a notification to the customer?
Kuroshima: CarlosRuiz, It's not just that, if the drop ship partner is added as an address to the actual customer, you need to add some way to hide the actual customer name from the shipment documents. If you set up the drop ship partner as a separate business partner, make the order to that partner and then use partner relationship to set your actual customer as the invoice partner, then you have the counterintuitive case that the listed par
Kuroshima: tner on the order is not the actual partner.
Kuroshima: and no way to represent that in iDempiere, making it less than ideal if there's an issue and the order needs to be revisited at a later date
CarlosRuiz: yes - most probably that sales order has a specific format to impersonate the customer
CarlosRuiz: as Monet - I would set a sales order document type called "Freda Sales Order" - and set a print format with Freda's logo probably
CarlosRuiz: and you can set up a workflow on that sales order type to notify Freda when shipped
CarlosRuiz: I mean - Monet can :-)
Kuroshima: CarlosRuiz, The thing is, in my use case, freda would sometimes request that I drop ship, and sometimes request that I ship to her, plus making a print format per customer who requests a drop ship is not sustainable
Kuroshima: in my case, what happens is that the customer finds out he's in a hurry, and that, to save time, we should ship directly to the his customer, meaning that the order would change types midway
Kuroshima: CarlosRuiz, Again, the proposed implementation in that sponsored development would suit me perfectly
CarlosRuiz: yes - just pointing that it can be done with actual code
Kuroshima: Indeed, it can be workarounded, as described in the page, but it's a workaround, not a proper solution IMHO
CarlosRuiz: hieplq__, AYT?
CarlosRuiz: nmicoud, IDEMPIERE-2244 integrated in dev - seems like TkTech notifico is not working today
nmicoud: ok, thanks Carlos
nmicoud: is same as last patch ?
CarlosRuiz: yes - I didn't change anything - can you please test it?
nmicoud: already done :)
nmicoud: we are using for weeks
nmicoud: not the RequestEMailProcessor but for similar stuff
CarlosRuiz: great
CarlosRuiz: let's check next from Deepak -2617
CarlosRuiz: I was checking if the mime properties can be set programatically
CarlosRuiz: and then I read your comment that you tested and didn't work
CarlosRuiz: :-)
CarlosRuiz: but checking that I found that you can set properties in a file called idempiereInit.properties
CarlosRuiz: the org.adempiere.base activator checks for that file and set the properties found there
nmicoud: ah good to know
druiz: hi @nmicoud
druiz: I've been working on this today https://idempiere.atlassian.net/browse/IDEMPIERE-2181
nmicoud: hi druiz
nmicoud: you find something useful ?
druiz: we talked with @CarlosRuiz about it, and I'm testing a solution that sets a variable TabNo in MLookupInfo, and overrides the method ParseContext in the Env Class
druiz: to receive that TabNo and then it works
nmicoud: ah great!
druiz: I tested it with a specific case and it works, to get the right values in a lookup in the detail pane in the sales order window
nmicoud: you want me to test your patch ?
druiz: It's not ready yet, I think I will post it soon, I need to test that I doesn't break any existing lookups now, but when I do it if you help me with that can help me a lot. I think your case and my case are different but it's the same problem.
nmicoud: sure
druiz: :) Do you know about more existing bugs in the detail pane?
nmicoud: => https://idempiere.atlassian.net/issues/?jql=labels%20%3D%20DetailTabIssue
druiz: :/, they're a few and I think I found a new one. :D Thanks
CarlosRuiz: :-) I was looking for a parent ticket - and nmicoud did was in a label - didn't remember that
Kuroshima: Bye everyone
druiz: @CarlosRuiz the lookupfield is created in the GridFieldVO class in the method loadLookupInfo. I cannot overload that method and its a public one, do you think it's ok if I change the MLookupFactory.getLookupInfo (ctx, WindowNo, AD_Column_ID, displayType....) to call the new method with that sets the TabNo
CarlosRuiz: checking ...
CarlosRuiz: I see two options
CarlosRuiz: one - adding a new getLookupInfo with TabNo
CarlosRuiz: or two - adding a setter/getter for TabNo in MLookupInfo - and calling it where needed
druiz: But even with the second approach it has to be set somewhere
druiz: so where needed there would be a line with getLookUpInfo
druiz: and after it woth setTabNo
CarlosRuiz: ...
druiz: I found this method in MLookup get (Properties ctx, int WindowNo, int TabNo, int Column_ID, int AD_Reference_ID)
druiz: it receives the TabNo but then it does not do anything with it
druiz: Is there a reason for that?
druiz: Sorry the method is in MLookupFactory
CarlosRuiz: look here
CarlosRuiz: http://pastebin.com/p2A7TtB1
CarlosRuiz: that's the way I use to do
CarlosRuiz: and you need to regenerate serialVersionUID where needed - adding public variables or methods
CarlosRuiz: ah - that patch is for 2.1 - maybe it doesn't integrate straight into your dev
nmicoud: gtg, see you
CarlosRuiz: bye nmicoud - thanks
druiz: @CarlosRuiz I created a patch and attached here https://idempiere.atlassian.net/browse/IDEMPIERE-2181
druiz: please review it when you have time and let me know of any issues with it
CarlosRuiz: thanks
