IDempiere/FullMeeting20140716

From WikiQSS
Revision as of 20:27, 16 July 2014 by CarlosRuiz (talk | contribs) (drop JIRA notifications from log)
(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)

Table of Contents | Full Meeting Minutes | Full Meeting 2014-07-16

CarlosRuiz: Good Morning
JanThielemann: hellop
nmicoud: Bonjour
JanThielemann: may you take a look at https://idempiere.atlassian.net/browse/IDEMPIERE-2055 ?
JanThielemann: a very simple fix i would love to see in the trunk
CarlosRuiz: yep JanThielemann - that's good
tbayen: Daarestiet!
Deepak: Good Morning CarlosRuiz
CarlosRuiz: Hi Deepak
Deepak: Hello Carlos
Deepak: I think some one has developed fast entry features in iDempiere
Deepak: Do anybody able to point me to correct url?
nmicoud: @Deepak : was it related to sales order lines ?
tbayen: Hi deepak. I saw your mail about that but I was away some days and did not answer yet.
tbayen: nmicoud worked on that
nmicoud: https://bitbucket.org/red1/quckinputsolines ?
Deepak: Thanks Nicolas
Deepak: Is anybody working to move KenosTax module to iDempiere plugin?
nmicoud: @Deepak : i think red1 has started to work on that
JanThielemann: carlosruiz but it's the same with products, isn't it?
CarlosRuiz: does product have cascade constraints? that would be dangerous
CarlosRuiz: wow - found 236 cascade constraints in non trl/access/acct tables
JanThielemann: some of them e.g. m_product_acct, m_product_bom, m_product_po, m_product_trl, m_productprice, m_productoperation
JanThielemann: would it be ok to implement delete of sub tables in model hooks / event handlers?
CarlosRuiz: even C_Invoice - C_BPartner - C_Order have cascade delete
CarlosRuiz: C_Order is curious
CarlosRuiz: it has cascade delete on line and tax
CarlosRuiz: on tax I think is fine as it's created automatically
CarlosRuiz: but on line is not good
CarlosRuiz: but - MOrder.beforeDelete takes care of that and delete the lines saving the change log
JanThielemann: so it would be ok if i implement deleting of webservice in/out fields and paras in beforeDelete() and make a patch?
CarlosRuiz: in one of our implementations a user deleted "inadvertently" 53 orders with the multi-delete button - we were able to restore the deleted info from the change log
CarlosRuiz: let me refine the query to check how many cascades we really have
CarlosRuiz: I see 250 cascade constraints - seems like that deserves a review
hengsin: for moving of cascade delete to model classes - if we can make use of jdbc batch update, the performance difference should be less significant
aguerra: Hello every body!!!!
nmicoud: Can someone have a look at ticket #2062 please ? patch seems too easy
CarlosRuiz: Hi aguerra
CarlosRuiz: nmicoud, does MRefList have serialversionID variable?
nmicoud: yes
nmicoud: serialVersionUID
CarlosRuiz: when adding public methods or variables - is better to regenerate it
CarlosRuiz: I usually just delete the variable - and click on the eclipse warning to generate it again
nmicoud: correct, i make it too fast
nmicoud: beacause i do it just before uploading the patch
nmicoud: not good practice
nmicoud: regenerating one
nmicoud: new patch uploaded
nmicoud: Carlos, could you have a look please when you have time ? if ok, i will apply to other methods
ocurieles_DCS: Hello my Friends
hengsin: nmicoud, IDEMPIERE-2062 looks goods to me
nmicoud: ok, thanks hengsin, thus will apply for other methods
hieplq: @CarlosRuiz "when adding public methods or variables - is better to regenerate it" it's good practise of idempiere or of java?
hieplq: hi CarlosRuiz IDEMPIERE-2061 is same IDEMPIERE-1667? i can close IDEMPIERE-1667 too?
CarlosRuiz: Hi ocurieles_DCS
CarlosRuiz: great hieplq - if 2061 solves 1667 then sure - please link them and resolve it
hieplq: ok. will get patch and test it
CarlosRuiz: hieplq, changing serialversionUID is good java practice
nmicoud: CarlosRuiz, just uploaded a new patch for #2062, with method getListDescription (and a new servialversionUID :))
nmicoud: you commit first patch too fast ;)
nmicoud: thanks Carlos
CarlosRuiz: thanks to you
nmicoud: also if you got time, maybe having a look at #1825 & 1828 ? related to emails (and btw, #1899 - images in signature - is in our instance for some days and it works perfectly !)
hengsin: nmicoud, I think the patch for 1825 needs to be regenerated, seems many are just white space difference.
nmicoud: ah, let me check
nmicoud: ok, will do that and upload a new one
norbertbede: hi all
hengsin: hi norbert
tbayen: Hi Norbert
nmicoud: thanks Carlos ; i will upload a new patch for 1825 tonight, but there are 2 others tickets that seems harmless and usefull : 2033 & 1851 :)
HansR42: Hi
Deepak: Hello Hans
HansR42: Found a strange behavior when try to import products via importproduct.java process, get an exception "Tax Category"
CarlosRuiz: Hi HansR42
HansR42: It seems all runs nice, when the number of products is below 200, but when i try to import 300 records, the exception is launched
HansR42: found some info in web about that. It seems that this error hasn't been fixed ...
Deepak: Can you say what is error message?
CarlosRuiz: JanThielemann, about your comment on IDEMPIERE-1851
CarlosRuiz: we have toolbar button column as Y-toolbar N-tab
CarlosRuiz: I think it could be good to add an option B-Both - to show a button on the toolbar and on the tab
CarlosRuiz: WDYT?
nmicoud: +1 for me :)
HansR42: Deepak, Regarding Errormessage in logfile: [STDERROR] ====> ImportProduct.process: TaxCategory [62]
ocurieles_DCS: @CarlosRuiz can i set the spanish languague by default in login ?
Deepak: Hans try to set one of TaxCategory as default and it may not fail
ocurieles_DCS: in this company nobody use the English
nmicoud: @ocurieles_DCS : you can uncheck the 'IsLoginLanguage' in the language window
Deepak: Hans, which version of iDempiere you are using?
ocurieles_DCS: Thanks @nmicoud
nmicoud: otherwise, you can define the default language based on the language browser (i think there is a jira related to that)
HansR42: Deepak: I have already done this. there is only one default Taxcategory available.
ocurieles_DCS: @nmicoud i put the spanish language by default.. and uncheck US English.. but in the login window appear in blank, my customer don't wanna select the language
nmicoud: so i think you will have to set it using the browser language
nmicoud: in LoginPanel, line 193
nmicoud: before, the language was linked to the ad_user_id, but it could lead to security breach and this behaviour was removed
CarlosRuiz: ocurieles_DCS, try also changing the language of client System - I think initially it defaults to that - as nmicoud pointed I think there is an undeveloped ticket about checking the browser language
nmicoud: See : https://idempiere.atlassian.net/browse/IDEMPIERE-1797
ocurieles_DCS: Thanks @CarlosRuiz is working fine :D
norbertbede: hieplq: are you there ?
hieplq: i'm here
norbertbede: are we ready with issue 1970 ?
hieplq: yes. it's ready.
norbertbede: i prefer to finish it if ready to commit
norbertbede: CarlosRuiz: do you havetime pls to review ?
CarlosRuiz: 1970?
norbertbede: hieplq: can you intrduce link, im on ipad
CarlosRuiz: don't worry - I'm already there
norbertbede: cant paste linkere :)
CarlosRuiz: applying IDEMPIERE-1970-add-old-func.patch
hieplq: yes. i add a test data, test process. please review it. i wait for your comment :D
norbertbede: ok thanks
red1: norbertbede: i am trying to do your defined feature, i hope u can test it next week when i done something
norbertbede: sure i can
red1: Can u give me test data now?
red1: U can email me or put in the JIRA steps to create a new case
red1: and what results to expect
red1: then i write it as a test data
red1: for me to define a new Workflow that use this feature
red1: The way you define i been studying is very well done for me to understand.
norbertbede: im on "senec lakes" now. will be ready in 2hours in my computer
red1: take your time.. no hurry
norbertbede: i can chat now well
red1: after this i want to improve with hieplq the GUI wizard to able to add also Transition/Condition
red1: not just Add Node
hieplq: yes. just learn zk for something, as drag & drop, layout
norbertbede: im plan to write some guides how to use wf in business
CarlosRuiz: transitions can be added actually
red1: yes i need that too, to edit for my tutorial
CarlosRuiz: but not conditions
red1: ah gut.. less work
red1: CarlosRuiz: i was on Skype with an African telco company and proposing he comes to your paid advanced course but tbayen told us that it is very advanced so he is afraid to.
red1: Instead i be going to Namibia to give them a calm course
CarlosRuiz: yep - the idea at the castle is not a course - but a workshop
red1: what is the 'very advanced' stuff u be doing?
CarlosRuiz: :-) I still don't know what tbayen has prepared
red1: Ah so, i am sure it must be the German way that beats Brazil that beats Colombia. :)
CarlosRuiz: nope - it will be like Colombia has the top goal scorer - and help Germany to become champions
CarlosRuiz: :D
red1: The only way that we are satistified is that Germany plays against Colombia, and take the result to minus 7-1
CarlosRuiz: hieplq, thanks for the test case 2pack for 1970
CarlosRuiz: I was able to test it correctly
CarlosRuiz: and easily :-)
hieplq: it's good when can help you :D
red1: :)
hieplq: @CarlosRuiz this patch is affect to refresh list (remain selected item) affter run process. i will fix it soon
hieplq: i find some my tiny ticket, please look it when you avaiable.
hieplq: IDEMPIERE-1527, IDEMPIERE-1552, IDEMPIERE-2026
red1: I think we should give you tickets also, to come Germany :D
red1: How much your visa? Have you checked it?
hieplq: me? never have a visa, just passport. but i must learn english for 6month. i hope i can hear and speach with you after this course
norbertbede: CarlosRuiz: thanks for commit. hieplq pls summarise related issues, should commit too
hieplq: yes. i will open new ticket for it. summit patch after one or two day.
CarlosRuiz: norbertbede, thanks to hieplq and you for pushing this
norbertbede: if today timeframe allow, suggest to resolve the following 3 issue: IDEMPIERE-2027, IDEMPIERE-1866, IDEMPIERE-1788
CarlosRuiz: norbertbede, I'm going out for lunch, I hope to review 2027, 1866 and 1788 this afternoon
red1: tbayen: check your FB
norbertbede: thanks CarlosRuiz
CarlosRuiz: norbertbede, I was able to reproduce IDEMPIERE-1866 - seems my solution is not the best - will solve it later
norbertbede: ok sure