IDempiere/FullMeeting20140702

From WikiQSS
Revision as of 10:16, 3 July 2014 by CarlosRuiz (talk | contribs) (full meeting)
(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)

⇐ Table of Contents | Full Meeting Minutes | Full Meeting 2014-07-02

CarlosRuiz: Good Morning
nmicoud: Bonjour
nmicoud: Carlos, could you have a look at those tickets please ? https://idempiere.atlassian.net/browse/IDEMPIERE-1725 and https://idempiere.atlassian.net/browse/IDEMPIERE-1697 ?
CarlosRuiz: ok, let me check
nmicoud: thanks
tbayen: Daarestiet :-)
nmicoud: hi thomas
Not-47e: [iDempiere] CarlosRuiz_globalqss pushed 1 commit to development [+2/-0/±0] https://bitbucket.org/idempiere/idempiere/commits/
Not-47e: [iDempiere] hieplq 270e749 - IDEMPIERE-1878:Printformat name in login language
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-1878 status set to "Resolved" -resolution set to "Fixed"
Not-47e: [IDEMPIERE] Thanks [~hieplq]
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1878
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2032
Not-47e: [IDEMPIERE] [~hieplq], maybe changing to DB.executeUpdateEx ?
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2032
Not-47e: [iDempiere] CarlosRuiz_globalqss pushed 1 commit to development [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/
Not-47e: [iDempiere] nmicoud 5f723c3 - IDEMPIERE-1725 List of available print formats should be filtered with report view in report viewer
Not-47e: [IDEMPIERE] hieplq updated IDEMPIERE-2032
Not-47e: [IDEMPIERE] yes. executeUpdateEx can help in this case. i will add a patch for it. but add a warning at DB.executeUpdate can help with Potential issue for easy investigate
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2032
norbertbede: hi @
norbertbede: all
norbertbede: @CarlosRuiz @hieplq can we close today https://idempiere.atlassian.net/browse/IDEMPIERE-1970 ?
norbertbede: i would be glad because other tickets are stalled on
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2032
Not-47e: [IDEMPIERE] [~hieplq] in DB.executeUpdate lines 1049/1052 the exception is being saved in log severe level. What do you mean with a warning?
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2032
Not-47e: [IDEMPIERE] hieplq updated IDEMPIERE-2032
Not-47e: [IDEMPIERE] huh. i will lean about "severe level". seem this log level is not show in console. when it show in console, it more make attention of dev.
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2032
CarlosRuiz: @norbertbede, @hieplq I have a long list from hiep to review - will try to review some today
CarlosRuiz: @norbertbede, @hieplq I have a long list from hiep to review - will try to review some today
nmicoud: any idea why default action for proposal document is "Prepare" ? (https://groups.google.com/forum/?fromgroups#!topic/idempiere/AclfJECiHNM) ? as it won't reserve stock, i don't understand why we can't just complete it
CarlosRuiz: nmicoud, Prepare does the reservations
nmicoud: yes, but proposal document don't reserve stock
nmicoud: it's hardcoded in MOrder
CarlosRuiz: it depends - there are two kinds of proposal
CarlosRuiz: binding-offer and non-binding offer
nmicoud: but they have different sub document type order
nmicoud: (sorry), i got disconnected for some seconds)
CarlosRuiz: it depends - there are two kinds of proposal
CarlosRuiz: binding-offer and non-binding offer
CarlosRuiz: binding does reservations - non-binding doesn't
nmicoud: i agree
CarlosRuiz: so, what's the issue?
nmicoud: but in DocumentEngine, both have the Prepare as default action whereas non-binding document should go to complete directly, no ?
nmicoud: hum, let me check
CarlosRuiz: I think the intended flow for a proposal or quotation is to become a sales order
CarlosRuiz: or be closed if it doesn't
nmicoud: i thought that as the non binding offer won't reserve stock, it would have make sense to complete it directly (as default action). So, if the non binding is converted to a sales order, this is this SO that will reserve stock
nmicoud: but perhaps, with the actual behaviour, there is a single way, no difference
CarlosRuiz: being prepared - you can change the doctype
nmicoud: yes
nmicoud: in fact, i was in a case where i wanted to have the complete as default action. and i cannot find a way to achieve it.
nmicoud: i had to modify DocumentEngine
nmicoud: and that make me wonder if it would make sense to change the default action for this kind of document
CarlosRuiz: which is the default option - the first?
ocurieles_dcs: Hi guys
nmicoud: it should be, but in getValidActions, for C_Order table, there is this piece of code
CarlosRuiz: Hi Orlando
nmicoud: if ("Y".equals(isSOTrx) && ("OB".equals(orderType) || "ON".equals(orderType))) docAction[0] = DocumentEngine.ACTION_Prepare;
nmicoud: line 980
CarlosRuiz: I think you can modify that with customizeValidActions
nmicoud: no
nmicoud: you can only add or remove action, you can't define the default one
nmicoud: or i haven't find a way to do it
ocurieles_dcs: I have a question, How can print the Org Logo in the reports ???,
CarlosRuiz: default is the zero index of the docAction array - so maybe you could reorganize it
CarlosRuiz: ocurieles_dcs, adding a Logo_ID column
ocurieles_dcs: the reporEngine only search in the client
ocurieles_dcs: the client logo by default
nmicoud: not in the customizeValidAction as it only returns an integer (the index)
CarlosRuiz: yep - for reports is client logo - for documents is org logo
nmicoud: it doesn't modify the docActioon[]
CarlosRuiz: what if you write
CarlosRuiz: docAction[0] = DocumentEngine.ACTION_Complete
nmicoud: i think i've tested it but it doesn't have good result
nmicoud: will retry it
nmicoud: retested and it doesn't have effect
nmicoud: prepare is still the default action
Not-47e: [iDempiere] CarlosRuiz_globalqss pushed 2 commits to development [+2/-0/±5] https://bitbucket.org/idempiere/idempiere/commits/
Not-47e: [iDempiere] nmicoud a186c37 - IDEMPIERE-1697 Ability to filter available column for print format
Not-47e: [iDempiere] globalqss f8c9bb5 - IDEMPIERE-1697 Ability to filter available column for print format / peer review
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-1697 status set to "Resolved" -assignee set to "Nicolas Micoud" -resolution set to "Fixed"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1697
nmicoud: thanks for the peer review CarlosRuiz. Don't know if you still have time, but there are 3 others tickets that could be integrated (1992, 2010 and 2011). All are harmless and useful :)
CarlosRuiz: nmicoud, did a little test changing MOrder to implement customizeValidActions
CarlosRuiz: and it worked
CarlosRuiz: like this
CarlosRuiz: docAction[0] = DocumentEngine.ACTION_Complete;
CarlosRuiz: return index;
nmicoud: i've made the customization in MOrder_Tgi which extends MOrder and implements DocOptions
nmicoud: same code as yours
CarlosRuiz: and is being used as PO?
CarlosRuiz: did a breakpoint stop in your custom method?
nmicoud: let me check
nmicoud: wow
nmicoud: it worked !
nmicoud: i don't know what happens last time
nmicoud: but it seems ok, will do some further searches
nmicoud: anyway, thanks a lot !
CarlosRuiz: yw
CarlosRuiz: hieplq, AYT?
Not-47e: [IDEMPIERE] alan.lesc1 created IDEMPIERE-2036 RMA/Return not working properly with diferent UOM
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2036
Not-47e: [IDEMPIERE] alan.lesc1 updated IDEMPIERE-2036 Attachment set to "IDEMPIERE-2036.patch"
Not-47e: [IDEMPIERE] The attached patch correct issues related
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2036
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-1970
Not-47e: [IDEMPIERE] [~hieplq], in the patch you're changing a public method in DB.java: {code} public static void createT_Selection(int AD_PInstance_ID, Collection<Integer> selection, String trxName) {code} by {code} public static void createT_Selection(int AD_PInstance_ID, Map<Integer, List<String>> saveKeys, int viewIDIndex, String trxName) {code} for backward compatibility (is possible this method is used by customizations and/or extensions) is better to i
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1970
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-1970
Not-47e: [IDEMPIERE] Also it will be good if you can provide (via 2pack) a test case definition of the info window using this approach.
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1970
Not-47e: [IDEMPIERE] hieplq updated IDEMPIERE-1970
Not-47e: [IDEMPIERE] thanks [~carlosruiz_globalqss]. I will update patch soon. [~norbert.bede] your new info window is good testcase. you can help me?
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1970
Not-47e: [iDempiere] CarlosRuiz_globalqss pushed 7 commits to development [+4/-0/±11] https://bitbucket.org/idempiere/idempiere/commits/
Not-47e: [iDempiere] hieplq d51943c - IDEMPIERE-1979:auto requery with new value in parameter in info window after a action can make a Straggle
Not-47e: [iDempiere] hieplq 7dd51fe - IDEMPIERE-1973:Info Window - parameters - field Mandatory Logic missing
Not-47e: [iDempiere] globalqss 65fe816 - IDEMPIERE-1973:Info Window - parameters - field Mandatory Logic missing / fix oracle script
Not-47e: [iDempiere] hieplq 9b2ab88 - IDEMPIERE-1972:extend - Info window - process - by display logic field
Not-47e: [iDempiere] globalqss 1c63d14 - IDEMPIERE-1972:extend - Info window - process - by display logic field / fix oracle script
Not-47e: [iDempiere] globalqss 6a8088a - Fixing server.product.launch reported at https://groups.google.com/d/msg/idempiere/gV5u4i0CdZk/52A0uR7qAmQJ
Not-47e: [iDempiere] globalqss 1b5ae90 - Regenerate serialVersionUID for modified classes from IDEMPIERE-1979 / IDEMPIERE-1973 / IDEMPIERE-1972
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-1979 status set to "Resolved" -resolution set to "Fixed"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1979
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-1973 status set to "Resolved" -resolution set to "Fixed"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1973
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-1972 status set to "Resolved" -resolution set to "Fixed"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1972
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2030 status set to "Resolved" -assignee set to "Redhuan D. Oon" -resolution set to "Incomplete"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2030
Not-47e: [IDEMPIERE] hengsin updated IDEMPIERE-2035
Not-47e: [IDEMPIERE] I believe the issue is due to the use of non-default uom and have nothing to do with whether the product is having positive or negative on hand quantity.
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2035
Not-47e: [IDEMPIERE] hengsin updated IDEMPIERE-2036
Not-47e: [IDEMPIERE] Please provide a test case to illustrate the problem you are trying to fix, thanks.
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2036
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-1992
Not-47e: [IDEMPIERE] [~nmicoud], seems the requery parameter is useless anyways as MLocation.get is bringing the cached version
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1992
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2010
Not-47e: [IDEMPIERE] [~nmicoud], seems the requery parameter is useless anyways as MLocation.get is bringing the cached version
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2010
Not-47e: [IDEMPIERE] nmicoud updated IDEMPIERE-2010
Not-47e: [IDEMPIERE] so, we should add a new method with no parameter and set the actual with the deprecated tag ?
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2010
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2010
Not-47e: [IDEMPIERE] yes, that or force a real requery not reading from the cache
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2010
Not-47e: [IDEMPIERE] nmicoud updated IDEMPIERE-2010
Not-47e: [IDEMPIERE] means adding a new MLocation.get method with a new param requery ?
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2010
hieplq_: @CarlosRuiz. thanks so much for hard work with my ticket.
hieplq_: please just one. IDEMPIERE-1378 :)
CarlosRuiz: thanks to you - and sorry for the big delay
hieplq_: i see IDEMPIERE-1792 is commit but status is not change. you can recheck it?
Not-47e: [IDEMPIERE] alan.lesc1 updated IDEMPIERE-2035
Not-47e: [IDEMPIERE] Actually, the code that adjust QtyEntered is skiped by a "if (storage.getQtyOnHand().signum() < 0) continue;" near line 465 of InOutGenerate.java
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2035
CarlosRuiz: hieplq_, you reopened 1792 on june 4 and added IDEMPIERE-1792-1378.patch
hieplq_: ah. sory.
CarlosRuiz: so, is needed to check that for 1378?
hieplq_: yes. this patch is relate to 1378 please help me review too
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2010
Not-47e: [IDEMPIERE] it could be - or adding a MLocation.removeFromCache method - but the simplest can be to use "new MLocation" instead of "MLocation.get"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2010
Not-47e: [IDEMPIERE] nmicoud updated IDEMPIERE-2010
Not-47e: [IDEMPIERE] so, will add a new method and set the actual with the deprecated flag
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2010
Not-47e: [iDempiere] CarlosRuiz_globalqss pushed 2 commits to development [+0/-0/±2] https://bitbucket.org/idempiere/idempiere/commits/
Not-47e: [iDempiere] globalqss c85ed97 - IDEMPIERE-1992 HTML editor toolbar button disappear when swithching tabs / Thanks to Chử Trần Vương (VuongCT)
Not-47e: [iDempiere] globalqss 3d2505e - IDEMPIERE-1999 Adding support for over shipment / fix warning
Not-47e: [IDEMPIERE] alan.lesc1 updated IDEMPIERE-2036
Not-47e: [IDEMPIERE] To reproduce: - create & complete new Sales Order; create new line with product elm (ex: qty 5), but select non-default uom, like a 6-pack - create & complete shipment - create RMA, and try both Create Line or create the line manually. Both will retrieve QtyEntered and PriceEntered (wrong), but most of code is already ported to use product uom (which is the correct). Callout already allows you to increase qty to max product uom (in the exa
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2036
Not-47e: [iDempiere] CarlosRuiz_globalqss pushed 1 commit to development [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/
Not-47e: [iDempiere] hieplq 406356e - IDEMPIERE-1792:Info Window - Default Logic missing
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-1792 status set to "Resolved" -resolution set to "Fixed"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1792
Not-47e: [IDEMPIERE] norbert.bede updated IDEMPIERE-1963 assignee set to "hieplq"
Not-47e: [IDEMPIERE] its done, by [~tsvikruha] just stalled by 1970.
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1963
Not-47e: [IDEMPIERE] norbert.bede updated IDEMPIERE-1965 assignee set to "hieplq"
Not-47e: [IDEMPIERE] its done, by [~tsvikruha] just stalled by 1970.
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1965
CarlosRuiz: hieplq_, still there?
hieplq_: yes. i'm here
CarlosRuiz: can you please check this
CarlosRuiz: the patch for 1378
CarlosRuiz: is removing the overriden method createParameterPanel from InfoProductWindow
CarlosRuiz: but you just added a couple of lines (update display of mandatory field) to call validateParameters with IDEMPIERE-1973
CarlosRuiz: is that right?
hieplq_: yes. this override is not need.
hieplq_: i tested with some case.
CarlosRuiz: so, you don't need the call to validateParameters for the mandatory field
hieplq_: not remeber but validateParameters is call in other where
hieplq_: wait me recheck
hieplq_: my working folder is crash. i'm remaking it
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-1378
Not-47e: [IDEMPIERE] failed test case: - product info window - pushing the reset button set the product category to Standard, initially was empty
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1378
CarlosRuiz: hieplq_, 1979 broke info window from sales order - when I fill BP with any value a NPE is raised
hieplq_: i will test and fix it when finish setup working folder. thanks for test case
CarlosRuiz: I think I got it - I'll commit a fix - please check it
Not-47e: [iDempiere] CarlosRuiz_globalqss pushed 1 commit to development [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/
Not-47e: [iDempiere] globalqss f271edf - IDEMPIERE-1979 / fix NPE on initial query
Not-47e: [IDEMPIERE] nmicoud updated IDEMPIERE-2010 Attachment set to "IDEMPIERE-2010_v2.patch"
Not-47e: [IDEMPIERE] Patch with a new method getLocation()
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2010
Not-47e: [IDEMPIERE] nmicoud created IDEMPIERE-2037 WStringEditor title is not translated
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2037
Not-47e: [IDEMPIERE] nmicoud updated IDEMPIERE-2037 Attachment set to "IDEMPIERE-2037.patch"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2037
Not-47e: [IDEMPIERE] nmicoud updated IDEMPIERE-2037 labels set to "+Patch"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2037
Not-47e: [IDEMPIERE] nmicoud updated IDEMPIERE-2037 assignee set to "Carlos Antonio Ruiz Gomez"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2037
Not-47e: [IDEMPIERE] nmicoud updated IDEMPIERE-2037 status set to "Peer Review Queue"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2037
Not-47e: [IDEMPIERE] nmicoud updated IDEMPIERE-2037 priority set to "Minor"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2037
Not-47e: [iDempiere] CarlosRuiz_globalqss pushed 1 commit to development [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/
Not-47e: [iDempiere] globalqss 66ae8d7 - IDEMPIERE-2010 Param requery of MBPartnerLocation.getLocation is useless / based on patch from nmicoud
Not-47e: [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2010 status set to "Resolved" -assignee set to "Nicolas Micoud" -resolution set to "Fixed"
Not-47e: [IDEMPIERE] [~nmicoud], reviewing further the value is correctly requeried when used within a transaction, so I think is ok, committed a similar version to your first patch.
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2010
Not-47e: [IDEMPIERE] nmicoud updated IDEMPIERE-2033 assignee set to "Nicolas Micoud"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2033
Not-47e: [IDEMPIERE] nmicoud updated IDEMPIERE-2033 priority set to "Minor"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2033
Not-47e: [IDEMPIERE] nmicoud updated IDEMPIERE-2033 Attachment set to "IDEMPIERE-2033.patch"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2033
Not-47e: [IDEMPIERE] nmicoud updated IDEMPIERE-2033 labels set to "+Patch"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2033
Not-47e: [IDEMPIERE] nmicoud updated IDEMPIERE-2033 assignee set to "Carlos Antonio Ruiz Gomez"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2033
Not-47e: [IDEMPIERE] nmicoud updated IDEMPIERE-2033 status set to "Peer Review Queue"
Not-47e: [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2033

Retrieved from "https://globalqss.com/wiki/index.php?title=IDempiere/FullMeeting20140702&oldid=420"