IDempiere/FullMeeting20140702
⇐ Table of Contents | Full Meeting Minutes | Full Meeting 2014-07-02
CarlosRuiz: Good Morning
nmicoud: Bonjour
nmicoud: Carlos, could you have a look at those tickets please ? https://idempiere.atlassian.net/browse/IDEMPIERE-1725 and https://idempiere.atlassian.net/browse/IDEMPIERE-1697 ?
CarlosRuiz: ok, let me check
nmicoud: thanks
tbayen: Daarestiet :-)
nmicoud: hi thomas
norbertbede: hi @
norbertbede: all
norbertbede: @CarlosRuiz @hieplq can we close today https://idempiere.atlassian.net/browse/IDEMPIERE-1970 ?
norbertbede: i would be glad because other tickets are stalled on
CarlosRuiz: @norbertbede, @hieplq I have a long list from hiep to review - will try to review some today
CarlosRuiz: @norbertbede, @hieplq I have a long list from hiep to review - will try to review some today
nmicoud: any idea why default action for proposal document is "Prepare" ? (https://groups.google.com/forum/?fromgroups#!topic/idempiere/AclfJECiHNM) ? as it won't reserve stock, i don't understand why we can't just complete it
CarlosRuiz: nmicoud, Prepare does the reservations
nmicoud: yes, but proposal document don't reserve stock
nmicoud: it's hardcoded in MOrder
CarlosRuiz: it depends - there are two kinds of proposal
CarlosRuiz: binding-offer and non-binding offer
nmicoud: but they have different sub document type order
nmicoud: (sorry), i got disconnected for some seconds)
CarlosRuiz: it depends - there are two kinds of proposal
CarlosRuiz: binding-offer and non-binding offer
CarlosRuiz: binding does reservations - non-binding doesn't
nmicoud: i agree
CarlosRuiz: so, what's the issue?
nmicoud: but in DocumentEngine, both have the Prepare as default action whereas non-binding document should go to complete directly, no ?
nmicoud: hum, let me check
CarlosRuiz: I think the intended flow for a proposal or quotation is to become a sales order
CarlosRuiz: or be closed if it doesn't
nmicoud: i thought that as the non binding offer won't reserve stock, it would have make sense to complete it directly (as default action). So, if the non binding is converted to a sales order, this is this SO that will reserve stock
nmicoud: but perhaps, with the actual behaviour, there is a single way, no difference
CarlosRuiz: being prepared - you can change the doctype
nmicoud: yes
nmicoud: in fact, i was in a case where i wanted to have the complete as default action. and i cannot find a way to achieve it.
nmicoud: i had to modify DocumentEngine
nmicoud: and that make me wonder if it would make sense to change the default action for this kind of document
CarlosRuiz: which is the default option - the first?
ocurieles_dcs: Hi guys
nmicoud: it should be, but in getValidActions, for C_Order table, there is this piece of code
CarlosRuiz: Hi Orlando
nmicoud: if ("Y".equals(isSOTrx) && ("OB".equals(orderType) || "ON".equals(orderType))) docAction[0] = DocumentEngine.ACTION_Prepare;
nmicoud: line 980
CarlosRuiz: I think you can modify that with customizeValidActions
nmicoud: no
nmicoud: you can only add or remove action, you can't define the default one
nmicoud: or i haven't find a way to do it
ocurieles_dcs: I have a question, How can print the Org Logo in the reports ???,
CarlosRuiz: default is the zero index of the docAction array - so maybe you could reorganize it
CarlosRuiz: ocurieles_dcs, adding a Logo_ID column
ocurieles_dcs: the reporEngine only search in the client
ocurieles_dcs: the client logo by default
nmicoud: not in the customizeValidAction as it only returns an integer (the index)
CarlosRuiz: yep - for reports is client logo - for documents is org logo
nmicoud: it doesn't modify the docActioon[]
CarlosRuiz: what if you write
CarlosRuiz: docAction[0] = DocumentEngine.ACTION_Complete
nmicoud: i think i've tested it but it doesn't have good result
nmicoud: will retry it
nmicoud: retested and it doesn't have effect
nmicoud: prepare is still the default action
nmicoud: thanks for the peer review CarlosRuiz. Don't know if you still have time, but there are 3 others tickets that could be integrated (1992, 2010 and 2011). All are harmless and useful :)
CarlosRuiz: nmicoud, did a little test changing MOrder to implement customizeValidActions
CarlosRuiz: and it worked
CarlosRuiz: like this
CarlosRuiz: docAction[0] = DocumentEngine.ACTION_Complete;
CarlosRuiz: return index;
nmicoud: i've made the customization in MOrder_Tgi which extends MOrder and implements DocOptions
nmicoud: same code as yours
CarlosRuiz: and is being used as PO?
CarlosRuiz: did a breakpoint stop in your custom method?
nmicoud: let me check
nmicoud: wow
nmicoud: it worked !
nmicoud: i don't know what happens last time
nmicoud: but it seems ok, will do some further searches
nmicoud: anyway, thanks a lot !
CarlosRuiz: yw
CarlosRuiz: hieplq, AYT?
hieplq_: @CarlosRuiz. thanks so much for hard work with my ticket.
hieplq_: please just one. IDEMPIERE-1378 :)
CarlosRuiz: thanks to you - and sorry for the big delay
hieplq_: i see IDEMPIERE-1792 is commit but status is not change. you can recheck it?
CarlosRuiz: hieplq_, you reopened 1792 on june 4 and added IDEMPIERE-1792-1378.patch
hieplq_: ah. sory.
CarlosRuiz: so, is needed to check that for 1378?
hieplq_: yes. this patch is relate to 1378 please help me review too
CarlosRuiz: hieplq_, still there?
hieplq_: yes. i'm here
CarlosRuiz: can you please check this
CarlosRuiz: the patch for 1378
CarlosRuiz: is removing the overriden method createParameterPanel from InfoProductWindow
CarlosRuiz: but you just added a couple of lines (update display of mandatory field) to call validateParameters with IDEMPIERE-1973
CarlosRuiz: is that right?
hieplq_: yes. this override is not need.
hieplq_: i tested with some case.
CarlosRuiz: so, you don't need the call to validateParameters for the mandatory field
hieplq_: not remeber but validateParameters is call in other where
hieplq_: wait me recheck
hieplq_: my working folder is crash. i'm remaking it
CarlosRuiz: hieplq_, 1979 broke info window from sales order - when I fill BP with any value a NPE is raised
hieplq_: i will test and fix it when finish setup working folder. thanks for test case
CarlosRuiz: I think I got it - I'll commit a fix - please check it
