IDempiere/FullMeeting20150715 - Revision history

CarlosRuiz: drop JIRA notifications from log

2015-07-15T23:43:04Z

drop JIRA notifications from log

CarlosRuiz: full meeting

2015-07-15T23:42:33Z

full meeting

New page

⇐
[[IDempiere|Table of Contents]] |
[[IDempiere/Full Meeting Minutes|Full Meeting Minutes]] |
Full Meeting 2015-07-15


'''''CarlosRuiz''''': Good Morning 
'''''mpat''''': Hi 
'''''nmicoud''''': Bonjour 
'''''Not-f4e9''''': [IDEMPIERE] hieplq updated IDEMPIERE-2725 
'''''Not-f4e9''''': [IDEMPIERE] hi [~HansR42a] play a bit and i see how to redo it. 1. edit record 1 after that click refresh (because record 1 being focus, it's don't filter out) 2. edit record 2 after that click refresh (because record 2 being focus, it's don't filter out. record 1 also don't filter out by this bug) 3. edit record 3 after move focus to record 4 after that click refresh (record 3 is filter out but record 1,2,3 still 
'''''Not-f4e9''''': don't filter out by this bug) 4. record 1,2,3 don't filter out even you do more refresh. reason: logic build where clause for retain function is wrong see function dataRefreshAll class gridTable {code:java} if (retainedWhere != null) { // String whereClause = m_whereClause; if (m_whereClause != null && m_whereClause.trim().length() > 0) { m_whereClause = "((" + m_whereClause + ") OR (" + retainedWhere + ")) "; } 
'''''Not-f4e9''''': open(m_maxRows); // m_whereClause = whereClause; } {code} must separate where from sql_where field and where for retain record also reset where for retain record each time refresh. 
'''''Not-f4e9''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2725 
'''''nmicoud''''': Hi CarlosRuiz, could you look at #2720 please ? there is patch and a pending question :) 
'''''CarlosRuiz''''': ok 
'''''nmicoud''''': thanks 
'''''red1_''''': Bonjour mpat , bonjour nmicoud 
'''''nmicoud''''': Bonjour red1 :) 
'''''mpat''''': hi 
'''''aguerra''''': hi for all 
'''''Not-f4e9''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2725 
'''''Not-f4e9''''': [IDEMPIERE] not really a bug - that was intentionally added to force edited records to be kept on screen. The opposite behavior (the bug was fixed with this approach) was very annoying, you created or edited a record and the record disappeared from your screen. There were common mistakes made by user when the user edited a record, the record disappeared from screen and the user didn't notice and did an additional 
'''''Not-f4e9''''': change on a different record that was not intended (the record on the user screen - different than the user thought it was because the original edited record is gone) 
'''''Not-f4e9''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2725 
'''''smartjsp''''': Good morning everyone, there is not chat activity today ? 
'''''aguerra''''': yes 
'''''CarlosRuiz''''': morning smartjsp 
'''''aguerra''''': hello CarlosRuiz 
'''''CarlosRuiz''''': Hi aguerra 
'''''Not-f4e9''''': [iDempiere] CarlosRuiz_globalqss pushed 2 commits to release-2.1 [+0/-0/±2] https://bitbucket.org/idempiere/idempiere/commits/ 
'''''Not-f4e9''''': [iDempiere] nmicoud ef4c977 - IDEMPIERE-2720 Run as Job + EMail : title not translated 
'''''Not-f4e9''''': [iDempiere] globalqss 925ca90 - IDEMPIERE-2720 Run as Job + EMail : title not translated 
'''''Not-f4e9''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2720 status set to "Resolved" -resolution set to "Fixed" 
'''''Not-f4e9''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2720 
'''''Not-f4e9''''': [IDEMPIERE] hieplq updated IDEMPIERE-2725 
'''''Not-f4e9''''': [IDEMPIERE] hi [~carlosruiz_globalqss] in my test case, if at step 1,2 user don't click refresh, at step 4 all edited record will filter out. because we will must fix something. (i test in development branch) 
'''''Not-f4e9''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2725 
'''''hriess''''': Hello hiep lq 
'''''hriess''''': thank you for working on jira ticket 2725 
'''''hriess''''': seems to be a bug, based on your analysis and the analysis of Kirit 
'''''Not-f4e9''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2725 
'''''Not-f4e9''''': [IDEMPIERE] I think refresh is intended as a button to reread the data from database - not to do a requery. 
'''''Not-f4e9''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2725 
'''''CarlosRuiz''''': Hi hriess - glad to have you here 
'''''hriess''''': hi 
'''''CarlosRuiz''''': I see you're attending next conference - good - will meet there 
'''''hriess''''': yes this is my plan 
'''''hriess''''': looking forward to see you 
'''''CarlosRuiz''''': I made some comments on 2725 - the old behavior was worst in my opinion - the record disappeared from screen after used push save - or after user run a button 
'''''hriess''''': agee with you 
'''''hriess''''': but we found that current behaviour is not absolutely correct 
'''''hriess''''': it is more a random behaviour 
'''''hriess''''': hiep made a suggestion to correct current behaviour 
'''''Not-f4e9''''': [iDempiere2.1] jenkins built #257 completed (success) http://ci.idempiere.org/job/iDempiere2.1/257/ 
'''''CarlosRuiz''''': not random 
'''''CarlosRuiz''''': the edited records are preserved until you requery 
'''''CarlosRuiz''''': the refresh button is not doing a requery - just re-reading records from DB AFAIU 
'''''hriess''''': my current situation: i have a window with a tab, that should show only records with isactive = Y 
'''''hriess''''': if i modify the field to N they are still in list, but if i go to the next record and modify the isactive Field to N and repeat this step sometimes, suddenly some of the records disapper 
'''''hriess''''': probably some of the records are in cache and some of the records will be retrieved from the DB ... 
'''''CarlosRuiz''''': well - that's not the issue reported in 2725 - sounds like odd for user - if you can reproduce it in one of the test sites would be good to provide steps to reproduce 
'''''Deepak_''''': Good Morning all 
'''''aguerra''''': hi Deepak_ 
'''''CarlosRuiz''''': morning Deepak_ 
'''''Deepak_''''': Hello Carlos and aguerra 
'''''hriess''''': ok - i will try to reproduce on the test site 
'''''Deepak_''''': Do anybody know what is tree driven by value? 
'''''Deepak_''''': I am working to merge one of my patch for tree with custom table support and I come across thist 
'''''CarlosRuiz''''': Deepak_, let me look for the ticket ... 
'''''CarlosRuiz''''': is about automatic organization of the tree based on the value 
'''''CarlosRuiz''''': this is 
'''''CarlosRuiz''''': https://idempiere.atlassian.net/browse/IDEMPIERE-1425 
'''''CarlosRuiz''''': with that improvement I was able to import the account element tree using the CSV importer - instead of the Import Account 
'''''Deepak_''''': ohk 
'''''Deepak_''''': Carlos, I looked at patch 
'''''Deepak_''''': I don't think it is same 
'''''Deepak_''''': let me try to get ticket 
'''''Deepak_''''': ahh, Sorry it is same ticket 
'''''Deepak_''''': IDEMPIERE-1425 Account element improvements 
'''''hriess''''': i made a test in https://demo.globalqss.com/webui/ 
'''''hriess''''': it is same behaviour as in our instance 
'''''Not-f4e9''''': [IDEMPIERE] HansR42a updated IDEMPIERE-2725 
'''''Not-f4e9''''': [IDEMPIERE] i made some tests in https://demo.globalqss.com/webui/ result: - if records are deactivated, they are still in grid list -> same behaviour as in our local instance (idempiere 2.1) 
'''''Not-f4e9''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2725 
'''''CarlosRuiz''''': Deepak_, the patch was different than the commit in that ticket 
'''''Not-f4e9''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2672 Attachment set to "IDEMPIERE-2672_v0_workaround.patch" 
'''''Not-f4e9''''': [IDEMPIERE] Attaching a possible workaround tested for the AD_OrgInfo issue found. IDEMPIERE-2672_v0_workaround.patch Not the complete solution, but the workaround at least allows to edit the orginfo record. [~egil0902] can you please confirm? 
'''''Not-f4e9''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2672 
'''''Not-f4e9''''': [IDEMPIERE] egil0902 updated IDEMPIERE-2672 
'''''Not-f4e9''''': [IDEMPIERE] Hi [~carlosruiz_globalqss] I test the patch and it works and save perfect. The only isue i saw was that in the grid view of org_info does not put the name of the fiel but ad_org_id. Regards, 
'''''Not-f4e9''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2672 
'''''Not-f4e9''''': [IDEMPIERE] egil0902 updated IDEMPIERE-2672 
'''''Not-f4e9''''': [IDEMPIERE] Other thing to consider is that the org wrong saved before give me this error when i select one of them jul 15, 2015 11:36:49 AM org.adempiere.webui.adwindow.ADTabpanel navigateTo ADVERTENCIA: Tab does not have ID with Node_ID=1000004 jul 15, 2015 11:36:49 AM org.zkoss.zk.ui.impl.UiEngineImpl handleError:1359 GRAVE: >>org.adempiere.exceptions.AdempiereException: El registro no se encuentra en la búsqueda 
'''''Not-f4e9''''': actual >> at org.adempiere.webui.adwindow.ADTabpanel.navigateTo(ADTabpanel.java:1199) >> at org.adempiere.webui.adwindow.ADTabpanel.onEvent(ADTabpanel.java:1075) >> at org.zkoss.zk.ui.AbstractComponent.onEvent(AbstractComponent.java:2742) >> at org.zkoss.zk.ui.AbstractComponent.service(AbstractComponent.java:2713) >> at org.zkoss.zk.ui.AbstractComponent.service(AbstractComponent.java:2654) >> at 
'''''Not-f4e9''''': org.zkoss.zk.ui.impl.EventProcessor.process(EventProcessor.java:136) >> at org.zkoss.zk.ui.impl.UiEngineImpl.processEvent(UiEngineImpl.java:1717) >> at org.zkoss.zk.ui.impl.UiEngineImpl.process(UiEngineImpl.java:1502) >> at org.zkoss.zk.ui.impl.UiEngineImpl.execUpdate(UiEngineImpl.java:1212) >> at org.zkoss.zk.au.http.DHtmlUpdateServlet.process(DHtmlUpdateServlet.java:600) >> at 
'''''Not-f4e9''''': org.zkoss.zk.au.http.DHtmlUpdateServlet.doGet(DHtmlUpdateServlet.java:482) >> at org.zkoss.zk.au.http.DHtmlUpdateServlet.doPost(DHtmlUpdateServlet.java:491) >> at javax.servlet.http.HttpServlet.service(HttpServlet.java:755) >> at javax.servlet.http.HttpServlet.service(HttpServlet.java:848) >> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:304) >> at 
'''''Not-f4e9''''': org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210) >> at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:224) >> at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:185) >> at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472) >> at 
'''''Not-f4e9''''': org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:151) >> at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100) >> at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118) >> at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:405) >> at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:269) >> at 
'''''Not-f4e9''''': org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515) >> at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:302) >> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) >> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) >> at java.lang.Thread.run(Thread.java:745) 
'''''Not-f4e9''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2672

@@ Line 10: / Line 10: @@
 '''''mpat''''': Hi<br>
 '''''nmicoud''''': Bonjour<br>
 '''''nmicoud''''': Hi  CarlosRuiz, could you look at #2720 please ? there is patch and a pending question :)<br>
 '''''CarlosRuiz''''': ok<br>
@@ Line 22: / Line 17: @@
 '''''mpat''''': hi<br>
 '''''aguerra''''': hi for all<br>
 '''''smartjsp''''': Good morning everyone, there is not chat activity today ?<br>
 '''''aguerra''''': yes<br>
@@ Line 31: / Line 22: @@
 '''''aguerra''''': hello CarlosRuiz<br>
 '''''CarlosRuiz''''': Hi aguerra <br>
 '''''hriess''''': Hello hiep lq<br>
 '''''hriess''''': thank you for working on jira ticket 2725<br>
 '''''hriess''''': seems to be a bug, based on your analysis and the analysis of Kirit<br>
 '''''CarlosRuiz''''': Hi hriess - glad to have you here<br>
 '''''hriess''''': hi<br>
@@ Line 55: / Line 35: @@
 '''''hriess''''': it is more a random behaviour<br>
 '''''hriess''''': hiep made a suggestion to correct current behaviour<br>
 '''''CarlosRuiz''''': not random<br>
 '''''CarlosRuiz''''': the edited records are preserved until you requery<br>
@@ Line 83: / Line 62: @@
 '''''hriess''''': i made a test in https://demo.globalqss.com/webui/<br>
 '''''hriess''''': it is same behaviour as in our instance<br>
 '''''CarlosRuiz''''': Deepak_, the patch was different than the commit in that ticket<br>