CarlosRuiz: full meeting

2015-04-16T01:07:16Z

full meeting

New page

⇐
[[IDempiere|Table of Contents]] |
[[IDempiere/Full Meeting Minutes|Full Meeting Minutes]] |
Full Meeting 2015-04-15


'''''CarlosRuiz''''': Good Morning 
'''''nmicoud''''': Bonjour 
'''''nmicoud''''': Hey Carlos, i notice deleted messages from the google thread https://groups.google.com/d/msg/idempiere/AEnbxKxUgrQ/MUojpuD2C0oJ ; do you know what happened ? 
'''''CarlosRuiz''''': yep nmicoud - probably the author deleted it 
'''''CarlosRuiz''''': but it must still be in your inbox if you're subscribed to email notifications 
'''''nmicoud''''': because i was able to read it yesterday, and this morning there were deleted 
'''''nmicoud''''': i don't receive notification 
'''''nmicoud''''': but not a big deal, i fear google was deleting stuff silently 
'''''CarlosRuiz''''': unfortunately I think google group forums cannot be configured to disallow that 
'''''nmicoud''''': ok 
'''''nmicoud''''': any chance you can review special editor today ? 
'''''nmicoud''''': it's really useful :) 
'''''CarlosRuiz''''': ok 
'''''nmicoud''''': thanks 
'''''nmicoud''''': here the link https://bitbucket.org/nmicoud/org.idempiere.ui.zk.specialeditor 
'''''nmicoud''''': and the related jira ticket https://idempiere.atlassian.net/browse/IDEMPIERE-1779 
'''''red1''''': Deepak__: you mean that budget module plugin? 
'''''Deepak__''''': yes 
'''''red1''''': Ah u are too kind 
'''''red1''''': I thought I needed to migrate your changes in ADempiere 
'''''red1''''': Do I will just wait and pull your changes? 
'''''Deepak__''''': yes, wait and pull changes when we commit 
'''''red1''''': I will bring you great coffee from Java island later this year :) 
'''''red1''''': Or Colombia nearby if I going to Panama 
'''''Deepak__''''': Thanks 
'''''aguerra''''': Buenos dias mundo!!! 
'''''CarlosRuiz''''': Hi Alejandro 
'''''aguerra''''': hi Carlos 
'''''CarlosRuiz''''': nmicoud, I think we can have a core SpecialEditor plugin - and then attach xtensions to it? 
'''''nmicoud''''': yes 
'''''nmicoud''''': a kind of "reference" (with util classes, examples) 
'''''nmicoud''''': and then, anyone can use them and extend 
'''''CarlosRuiz''''': I mean - something like a core that you and me use the same code (the org.idempiere.base/ui.zk/action parts) 
'''''CarlosRuiz''''': and then your org.idempiere.extend probably will be different than mine 
'''''nmicoud''''': exactly 
'''''CarlosRuiz''''': but we share the core base to improve it 
'''''nmicoud''''': that was i meant when i was talking of "reference" 
'''''CarlosRuiz''''': I'm wondering now why when I designed this I didn't do it per tab :-) 
'''''nmicoud''''': it's never too late ;) 
'''''CarlosRuiz''''': ah, but you can check which tab are you positioned in canEdit and return false if is wrong tab 
'''''nmicoud''''': that can be achieved with the ad_toolbar display logic 
'''''nmicoud''''': but perhaps it's better if hardcoded ? 
'''''CarlosRuiz''''': Msg not found -> org.idempiere.ui.zk.action.specialeditor.label 
'''''CarlosRuiz''''': something in the 2pack maybe 
'''''nmicoud''''': yes, the image is not displayed also 
'''''red1''''': Hola aguerra 
'''''nmicoud''''': i haven't checked that 
'''''CarlosRuiz''''': here the image is displayed 
'''''nmicoud''''': O_o 
'''''aguerra''''': Hola red1 
'''''CarlosRuiz''''': don't know if is because I restarted 
'''''nmicoud''''': you're lucky ! 
'''''CarlosRuiz''''': another Msg NOT found: NoFieldsForSpecialEdit 
'''''nmicoud''''': probably i made a mistake on Eclipse 
'''''Not-311d''''': [IDEMPIERE] deepak updated IDEMPIERE-2579 Fix Version set to "2.1" -Version set to "2.1" -Component set to "Accounting" -Attachment set to "IDEMPIERE-2579.patch" 
'''''Not-311d''''': [IDEMPIERE] Patch attached for 2.1 branch. 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2579 
'''''Not-311d''''': [IDEMPIERE] deepak updated IDEMPIERE-2579 labels set to "+Patch" 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2579 
'''''ocurieles''''': Good Morning ... 
'''''CarlosRuiz''''': Hi Orlando 
'''''aguerra''''': hi Orlando 
'''''ocurieles''''': Is Somebody using the fixed asset module ? 
'''''ocurieles''''': HI @CarlosRuiz and @aguerra 
'''''ocurieles''''': I have a question, if i have two asset, by example two trucks, with the same caracteristics, is necessary create two assets ? or just create one Asset with two additions ? 
'''''CarlosRuiz''''': nmicoud, ok if I commit fix for the 2pack there? 
'''''nmicoud''''': yes 
'''''CarlosRuiz''''': nmicoud, abort: authorization failed 
'''''nmicoud''''': perhaps i need to add your bitbucket user 
'''''nmicoud''''': send you an 'invitation' 
'''''CarlosRuiz''''': ready - committed 
'''''nmicoud''''': great 
'''''CarlosRuiz''''': https://bitbucket.org/nmicoud/org.idempiere.ui.zk.specialeditor/commits/282ffe8 
'''''CarlosRuiz''''': I found a bug - will comment in the ticket ... 
'''''nmicoud''''': ok 
'''''ocurieles''''': the demo server is laggin 
'''''ocurieles''''': lagging 
'''''nmicoud''''': CarlosRuiz : you said you wanted to implement SpecialEditor per tab. If we add some stuff in code, perhaps we should also add a 'standard' button. This way, using the ad_toolbar_restriction, we will be able to display it according to role, tab, windows, .... wdyt ? 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-1779 
'''''Not-311d''''': [IDEMPIERE] Thanks Nicolas, I'm testing locally, some issues found: - Bug here? I opened the special editor on invoice line and selected org -> it shows the org field, then I changed my mind and selected Charge, and it shows the charge field but is not deleting the org field, both labels and both fields are shown together - I know it's a POC :-) But SpecialEditC_InvoiceLineC_Charge_ID allowed me to add a charge to a line that already had a product (c 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1779 
'''''nmicoud''''': Carlos, for your #2 (change charge on a line that already has a product), means we have to duplicate a part of MInvoiceLine beforeSave on the updateEdit or validateEdit ? 
'''''CarlosRuiz''''': I think is required to repeat the important validations related there 
'''''CarlosRuiz''''': as you annotated MInvoiceLine cannot be used - so you must do the beforeSave validations - and the afterSave logic also if needed 
'''''nmicoud''''': yes, checking line has a product is a good example 
'''''nmicoud''''': and for adding the button as part of standard toolbar ? 
'''''CarlosRuiz''''': nmicoud, what do you mean with Standard Button? 
'''''nmicoud''''': like Save, New, ImportCSV, ... 
'''''CarlosRuiz''''': the 2pack is adding it on toolbarbutton - so you can restrict it 
'''''nmicoud''''': right, my mistake :) 
'''''CarlosRuiz''''': Hi druiz 
'''''druiz''''': Hi everyone 
'''''aguerra''''': Buenos dias druiz 
'''''CarlosRuiz''''': so druiz - ready to check https://idempiere.atlassian.net/browse/IDEMPIERE-2556 ? 
'''''Not-311d''''': [iDempiere] CarlosRuiz_globalqss pushed 1 commit to development [+0/-0/±4] https://bitbucket.org/idempiere/idempiere/commits/ 
'''''Not-311d''''': [iDempiere] hieplq 9134a7c - IDEMPIERE-2569:ZK7 - Unexpected token in DSP/CSS 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2569 status set to "Resolved" -resolution set to "Fixed" 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2569 
'''''druiz''''': we could work on the design so I can start doing it 
'''''CarlosRuiz''''': aha 
'''''CarlosRuiz''''': ok - we talked about http://www.globalqss.com/idempiere/irclog/%23idempiere.2015-04-01.log.html 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2556 
'''''Not-311d''''': [IDEMPIERE] Notes from http://www.globalqss.com/idempiere/irclog/%23idempiere.2015-04-01.log.html * creating a table+window * we can keep showing in the preference window the fields marked as quick entry * changes required at Login.loadPreferences and WPreference to show the fields marked as quick entry and add a link to open the new window 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2556 
'''''CarlosRuiz''''': so, druiz - I think these would be the steps 
'''''CarlosRuiz''''': 1 - create table AD_UserPreference using official IDs and generating migration script for the ticket in 2.1z folder 
'''''CarlosRuiz''''': the table must have the 9 required columns plus the columns: AutoCommit and AutoNew (probably it requires to create elements for these two) 
'''''CarlosRuiz''''': 2 - then create a window (official IDs and same migration script) - the two columns AutoCommit and AutoNew must be marked as Quick Entry 
'''''CarlosRuiz''''': 3 - change WPreference to make it flexible - it must show - the fields on Preference window marked as Quick Entry 
'''''CarlosRuiz''''': and I think you can leave hardcoded in WPreference the other actual fields there (Dictionary Maintenance, Log Migration Script, Manage Gadgets) and the save button 
'''''CarlosRuiz''''': we must also add a link or button called "More Preferences" that zooms to the Preference window 
'''''CarlosRuiz''''': 4 - change org.compiere.util.Login - method loadPreferences 
'''''CarlosRuiz''''': to set in context the preferences found in the record for the user login in 
'''''CarlosRuiz''''': if the user doesn't have preferences then maybe we can assign default - or create a preference record on the fly there 
'''''CarlosRuiz''''': and then test :-) 
'''''CarlosRuiz''''': I think it can be good to create org.compiere.model.MUserPreference and helper methods there to get a preference for a user 
'''''CarlosRuiz''''': the outcome of IDEMPIERE-2556 must be that core and plugins can add and use user preferences without needing to change the java code on WPreference each time 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2556 
'''''Not-311d''''': [IDEMPIERE] More detailed design discussed here: http://www.globalqss.com/idempiere/irclog/%23idempiere.2015-04-15.log.html#t2015-04-15T15:02:45 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2556 
'''''nmicoud''''': CarlosRuiz, just commited fixes for SpecialEditor (maybe you receive notification ?), but gtg ; bye bye 
'''''druiz''''': Ok. Good for starting, I guess I'll have extra questions when I go further on the development, but I'll let you know. XD. Thanks 
'''''CarlosRuiz''''': bye nmicoud - thanks 
'''''CarlosRuiz''''': yw druiz 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-1779 
'''''Not-311d''''': [IDEMPIERE] Thanks [~nmicoud], tested latest changes and is working fine now :-) As we talked on meeting maybe is better to split the plugin in two. 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1779 
'''''Not-311d''''': [iDempiere] CarlosRuiz_globalqss pushed 2 commits to release-2.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ 
'''''Not-311d''''': [iDempiere] brerp 736a50d - IDEMPIERE-2578 MProduction without TIMING_BEFORE_COMPLETE and TIMING_AFTER_COMPLETE validation 
'''''Not-311d''''': [iDempiere] globalqss 7f2f405 - IDEMPIERE-2578 / IDEMPIERE-1715 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2578 status set to "Resolved" -assignee set to "Murilo Habermann Torquato" -resolution set to "Fixed" 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2578 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2579 
'''''Not-311d''''': [IDEMPIERE] Thanks [~deepak], my peer review: - some times the costing level is based on product category, so I think the line {code} if (MAcctSchema.COSTINGLEVEL_BatchLot.equals(MClient.get(getCtx()).getAcctSchema().getCostingLevel()) {code} must looke like {code} if (MAcctSchema.COSTINGLEVEL_BatchLot.equals(line.getProduct().getCostingLevel(m_as)) {code} but I haven't tested - m_as is private at this moment - and I don't know if the details are loa 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2579 
'''''norbertbede''''': hi all 
'''''CarlosRuiz''''': hi norbertbede 
'''''tsvikruha''''': Hi community, 
'''''tsvikruha''''': anybody who met logs such as this? 
'''''tsvikruha''''': 15:29:21.685-----------> ServletHandler.doHandle: /webui/ [950] 
'''''tsvikruha''''': java.util.ConcurrentModificationException 
'''''tsvikruha''''': at java.util.LinkedHashMap$LinkedHashIterator.nextEntry(LinkedHashMap.java:394) 
'''''tsvikruha''''': at java.util.LinkedHashMap$EntryIterator.next(LinkedHashMap.java:413) 
'''''tsvikruha''''': at java.util.LinkedHashMap$EntryIterator.next(LinkedHashMap.java:412) 
'''''tsvikruha''''': at org.zkoss.util.CacheMap.expunge(CacheMap.java:228) 
'''''tsvikruha''''': at org.zkoss.util.CacheMap.doExpunge(CacheMap.java:208) 
'''''tsvikruha''''': at org.zkoss.util.CacheMap.tryExpunge(CacheMap.java:202) 
'''''tsvikruha''''': at org.zkoss.util.CacheMap.put(CacheMap.java:428) 
'''''tsvikruha''''': at org.zkoss.zk.ui.impl.SimpleDesktopCache.addDesktop(SimpleDesktopCache.java:91) 
'''''tsvikruha''''': at org.zkoss.zk.ui.impl.DesktopImpl.<init>(DesktopImpl.java:271) 
'''''tsvikruha''''': at org.zkoss.zk.ui.impl.AbstractUiFactory.newDesktop(AbstractUiFactory.java:85) 
'''''tsvikruha''''': http://pastebin.com/2LMwp0dq 
'''''CarlosRuiz''''': haven't seen that one 
'''''tsvikruha''''': I've just uploaded the log on pastebin.. 
'''''tsvikruha''''': Do you have some ideas what it could mean? 
'''''Not-311d''''': [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+2/-0/±3] https://bitbucket.org/idempiere/idempiere/commits/ 
'''''Not-311d''''': [iDempiere] globalqss cc312c6 - IDEMPIERE-2549 Password rule break Initial Client Setup 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2549 status set to "Resolved" -assignee set to "Carlos Antonio Ruiz Gomez" -resolution set to "Fixed" 
'''''Not-311d''''': [IDEMPIERE] OK, I implemented a solution this way: - added a flag on Initial Client Setup saying "Set Initial Password" - for this case the flag must be unchecked so the two new users are not assigned with a password - then the SuperUser must login into the new tenant and set the password for the new users - I added a flag on Reset Password to expire the password immediately, so the user can be informed about the new password by the administrator, bu 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2549 
'''''Not-311d''''': [IDEMPIERE] nmicoud updated IDEMPIERE-1779 
'''''Not-311d''''': [IDEMPIERE] For splitting the plugin in 2, we just need to remove the src\org\idempiere\extend package, right ? 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1779 
'''''Not-311d''''': [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ 
'''''Not-311d''''': [iDempiere] globalqss bcc16d9 - IDEMPIERE-2549 Password rule break Initial Client Setup / fix broken swing 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss created IDEMPIERE-2580 Error with taxes and country groups 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2580 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2580 Attachment set to "IDEMPIERE-2580.patch" 
'''''Not-311d''''': [IDEMPIERE] Attaching a patch to solve the issue, now to combine country and country group you can define the country associated to a country group. I mean, previously the country and country group were exclusive - now with this approach you can fill both fields, or just one. 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2580 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-1779 
'''''Not-311d''''': [IDEMPIERE] Yep - and move it to a different plugin with the corresponding xmls on OSGI-INF 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1779 
'''''CarlosRuiz''''': tsvikruha, sorry - didn't see your question - no idea about what can be causing that 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2580 labels set to "+Patch" 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2580 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-449 
'''''Not-311d''''': [IDEMPIERE] [~nmicoud] I think this ticket can be solved better by a Login Validator plugin. Maybe good candidate for a plugin. 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-449 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-257 
'''''Not-311d''''': [IDEMPIERE] this seems like another good candidate for the user preferences 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-257 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-450 
'''''Not-311d''''': [IDEMPIERE] [~nmicoud] - this could be solved adding SOPOType to AD_User and changing the query in CalloutOrder.bPartner (and invoices too) to get the corresponding user marked for the SO/PO Both trx. 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-450 
'''''Not-311d''''': [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+2/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ 
'''''Not-311d''''': [iDempiere] globalqss 62a652f - IDEMPIERE-476 Report Engine related bugs 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-476 status set to "Resolved" -assignee set to "Carlos Antonio Ruiz Gomez" -resolution set to "Fixed" 
'''''Not-311d''''': [IDEMPIERE] for the dataset in the example the correct values were: Variance 19135181,671875 Deviation 4374,3778611221 I was calculating in libreoffice with var and desvest - but the correct functions are varp and desvestp 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-476 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-492 
'''''Not-311d''''': [IDEMPIERE] [~nmicoud], maybe to be in line with the tree now - we could show the nodes in bold 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-492 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-494 status set to "Resolved" -assignee set to "Carlos Antonio Ruiz Gomez" -resolution set to "Incomplete" 
'''''Not-311d''''': [IDEMPIERE] report seems incomplete and obsolete 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-494 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-495 assignee set to "None" 
'''''Not-311d''''': [IDEMPIERE] it sounds like a conversion is needed 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-495 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-521 status set to "Resolved" -resolution set to "Won't Fix" 
'''''Not-311d''''': [IDEMPIERE] This is reported as a migration note to take into account for those migrating with old production: http://wiki.idempiere.org/en/Migration_Notes#Production The migration note points to this ticket 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-521 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-527 status set to "Resolved" -resolution set to "Won't Fix" 
'''''Not-311d''''': [IDEMPIERE] closing as it has a valid workaround - please feel free to reopen if you have a suggested patch 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-527 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-551 status set to "Resolved" -resolution set to "Fixed" 
'''''Not-311d''''': [IDEMPIERE] closing as there is a valid workaround 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-551 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-552 status set to "Resolved" -resolution set to "Won't Fix" 
'''''Not-311d''''': [IDEMPIERE] same workaround seems to be valid here - uncheck IsCentrallyMaintained to change specific contexts 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-552 
'''''Not-311d''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-581 Attachment set to "IDEMPIERE-581_WIP_for21.patch" 
'''''Not-311d''''': [IDEMPIERE] Hi [~nmicoud], attached a work in progress patch for r2.1 It's working fine - the issue (big stopper issue I think) is that if you set a big height on a big screen (i.e. on my big screen I can set the detail pane to be 812px) - and then you try to open the same window in a small screen (i.e. a tablet - or to reproduce just make the browser window small - 1024x768) - then the window is opened but nothing is visible there. So, we would need 
'''''Not-311d''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-581

IDempiere/FullMeeting20150415 - Revision history

CarlosRuiz: drop JIRA notifications from log

CarlosRuiz: full meeting