CarlosRuiz: full meeting

2014-11-20T00:28:21Z

full meeting

New page

⇐
[[IDempiere|Table of Contents]] |
[[IDempiere/Full Meeting Minutes|Full Meeting Minutes]] |
Full Meeting 2014-11-19


'''''CarlosRuiz''''': Good Morning 
'''''aguerra''''': Good Morning @CarlosRuiz 
'''''nmicoud''''': Bonjour 
'''''nmicoud''''': Hi CarlosRuiz, do you have an idea for https://groups.google.com/forum/?fromgroups#!topic/idempiere/-Su6R2dRhr0 ? 
'''''Deepak''''': Good Morning carlos 
'''''CarlosRuiz''''': Hi Deepak 
'''''CarlosRuiz''''': nmicoud, iDempiere can be load balanced in app server and db server - I don't think there is a problem with 600 users - but you need to tune and probably load balance if they are concurrent 
'''''nmicoud''''': ok, we need to investigate the load balancing subject 
'''''Deepak''''': Carlos, can you please review and accept tickets IDEMPIERE-2314 and IDEMPIERE-2318 
'''''CarlosRuiz''''': sure Deepak - will start reviewing 2318 now 
'''''Deepak''''': nmicoud, please note that iDempiere is tuned for clustering, only restriction may come from DB server capability 
'''''Deepak''''': and one constraints is due to locking operation 
'''''nmicoud''''': thanks 
'''''Not-57f0''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2318 status set to "Resolved" -resolution set to "Fixed" 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2318 
'''''Not-57f0''''': [iDempiere] CarlosRuiz_globalqss pushed 2 commits to release-2.1 [+2/-0/±4] https://bitbucket.org/idempiere/idempiere/commits/ 
'''''Not-57f0''''': [iDempiere] dpansheriya 6eac0c0 - IDEMPIERE-2318: Handling NPE and providing meaning full error message 
'''''Not-57f0''''': [iDempiere] globalqss e89dcfb - IDEMPIERE-2318: Handling NPE and providing meaning full error message 
'''''egil_ghintech''''': Hi 
'''''egil_ghintech''''': anybody can help me with https://groups.google.com/forum/#!topic/idempiere/i7MKGrcSnNg 
'''''Not-57f0''''': [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ 
'''''Not-57f0''''': [iDempiere] dpansheriya 67f24db - IDEMPIERE-2314: Making import inventory process extendible 
'''''egil_ghintech''''': I have been working in the mobile app. There are a few things about callouts, location, theme and other i made changes. Here are the code https://bitbucket.org/egil0902/org.idempiere.iuimobile 
'''''CarlosRuiz''''': Hi egil_ghintech 
'''''CarlosRuiz''''': egil_ghintech, there must be something wrongly configured in your workflow - you can send an email after complete without problem - look at process requisition workflow on gardenworld 
'''''octavian''''': Hi. I try to make the path where migration scripts are written configurable but with no success. Any suggestions please ? 
'''''Deepak''''': Carlos, Which version should https://idempiere.atlassian.net/browse/IDEMPIERE-2319 go 
'''''Not-57f0''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2287 priority set to "Minor" 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2287 
'''''Deepak''''': I have migration script in that ticket, So need to decide so I commit migration script in correct folder 
'''''Not-57f0''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2287 
'''''Not-57f0''''': [IDEMPIERE] The patch is incomplete - it allows to create documents in closed periods as the validation for open period is done on prepareIt and the dateacct is changed at the end of completeIt. On the other hand, maybe this would be done configurable? 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2287 
'''''Not-57f0''''': [IDEMPIERE] deepak updated IDEMPIERE-2319 description set to "Currently iDempiere supports list, String and number data type in ASI. We should add support for date as it may be useful to have date kind of ASI. Also Found that there need for transaction management in saveSelection method to avoid creation of junk ASI. " 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2319 
'''''CarlosRuiz''''': Deepak, IDEMPIERE-2319 must go to 2.1z 
'''''Deepak''''': Thanks Carlos 
'''''Not-57f0''''': [IDEMPIERE] carlosruiz_globalqss created IDEMPIERE-2323 Payment Rule editor doesn't have context menu 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2323 
'''''Not-57f0''''': [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ 
'''''Not-57f0''''': [iDempiere] globalqss 4af3313 - IDEMPIERE-2323 Payment Rule editor doesn't have context menu 
'''''Not-57f0''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2323 status set to "Resolved" -resolution set to "Fixed" 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2323 
'''''Not-57f0''''': [IDEMPIERE] nmicoud created IDEMPIERE-2324 Env.parseVariable(String, PO, String, boolean) doesn't use format when keepUnparseable 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2324 
'''''Not-57f0''''': [IDEMPIERE] nmicoud updated IDEMPIERE-2324 Attachment set to "IDEMPIERE-2324.patch" 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2324 
'''''Not-57f0''''': [IDEMPIERE] nmicoud updated IDEMPIERE-2324 labels set to "+Patch" 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2324 
'''''Not-57f0''''': [IDEMPIERE] nmicoud updated IDEMPIERE-2324 assignee set to "Carlos Antonio Ruiz Gomez" 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2324 
'''''Not-57f0''''': [IDEMPIERE] nmicoud updated IDEMPIERE-2324 status set to "Peer Review Queue" 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2324 
'''''nmicoud''''': CarlosRuiz, found a funny (but annoying) bug :) ; could you have a look at https://idempiere.atlassian.net/browse/IDEMPIERE-2324 ; i've attached a patch that seems to work, at least in my case 
'''''Not-57f0''''': [IDEMPIERE] tsvikruha updated IDEMPIERE-2287 
'''''Not-57f0''''': [IDEMPIERE] I will make it configurable to change DateAcct at the end of CompleteIt and also I will add validation if period is not closed. Thanks for your advice. 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2287 
'''''CarlosRuiz''''': ah I see nmicoud 
'''''CarlosRuiz''''': nmicoud, same issue in line 1484 
'''''nmicoud''''': 1484 ?? 
'''''CarlosRuiz''''': Env.java 
'''''CarlosRuiz''''': and now that we're changing that maybe is better to change the + with .append 
'''''nmicoud''''': Could you explain the "change the + with .append" ? 
'''''Not-57f0''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2324 Attachment set to "IDEMPIERE-2324_CR.patch" 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2324 
'''''CarlosRuiz''''': you can see it on the attached patch - can you please test it? 
'''''nmicoud''''': sure 
'''''egil_ghintech''''': Hi @CarlosRuiz i was lost for a minute. Im going to checkit and coment in the group 
'''''egil_ghintech''''': thanks 
'''''CarlosRuiz''''': yw 
'''''Not-57f0''''': [IDEMPIERE] tsvikruha updated IDEMPIERE-2319 
'''''Not-57f0''''': [IDEMPIERE] Deepak, I am wondering about this use case: 1. Setup Not Mandatory Instance Attribute with AttributeType=String (max 40) 2. Create new document line and open Attribute Set Instance Dialog to create new Attribute Set Instance 3. Attribute created in first step leave empty 4. Click OK 5. Check table M_AttributeInstance => New Record Created also for Attribute which was empty (column 'Value' is filled with AttributeInstanceID) 6. Open Attrib 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2319 
'''''egil_ghintech''''': @CarlosRuiz the requisition process does not have an email node. What exacly should i see there to solve the problem? 
'''''Not-57f0''''': [IDEMPIERE] tsvikruha updated IDEMPIERE-2319 Attachment set to "bug_example.png" 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2319 
'''''CarlosRuiz''''': egil_ghintech, it has a couple of nodes at the end - it doesn't stop the completion of the document 
'''''CarlosRuiz''''': I'm not sure that I understand what your problem is reading the forum post :-) 
'''''egil_ghintech''''': I got it. it is that i put the email node after complete and it stay in an infinite bucle. 
'''''egil_ghintech''''': @CarlosRuiz Seems like it is exacly like the requisition workflow nodes after complete but the problem still there. I forget to say that is just with email because i call a node to send sms after complete and it works perfect 
'''''egil_ghintech''''': . I just put another coment in the group because i saw some warnings that happens every time after the problem in the console 
'''''CarlosRuiz''''': egil_ghintech, you can try to reproduce it in demo.idempiere.com 
'''''egil_ghintech''''': yes. i am going to 
'''''egil_ghintech''''': @CarlosRuiz demo say 504 Gateway Time-out 
'''''Not-57f0''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2321 
'''''Not-57f0''''': [IDEMPIERE] I'm not so sure about the convenience of filtering by AD_Client_ID Usually the confirmation of query is related to performance, to avoid a user to slow down the server with a query travelling many records. And usually (by default) the AD_Client_ID is not indexed in iDempiere tables, and is not 100% recommendable to have an access index by AD_Client_ID because of its usually low cardinality. So, I think the intention of opening the query w 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2321 
'''''CarlosRuiz''''': thanks egil_ghintech - will refresh demo then ... 
'''''egil_ghintech''''': @CarlosRuiz ok i'll be waiting :) 
'''''CarlosRuiz''''': ready egil_ghintech - demo is up again 
'''''CarlosRuiz''''': nmicoud, did IDEMPIERE-2324 work? 
'''''nmicoud''''': it seems, but maybe i found another bug with dates ; not sure, need to investigate further 
'''''nmicoud''''': anyway, your patch is ok for me 
'''''CarlosRuiz''''': so, safe to commit? 
'''''nmicoud''''': i think yes 
'''''nmicoud''''': but i think there maybe another bug with date 
'''''Not-57f0''''': [IDEMPIERE] hieplq updated IDEMPIERE-1930 description set to "ref:https://groups.google.com/forum/#!topic/idempiere/YXZVLT9GX1c reattach some 16 jasper report is very hard. because I switch to use this way, make fragment project. But seem it's have some limit: + same nicolas, Image is not load + naming of sub-report must below a rule + number of sub-report is restrict to 10 make this ticket to improve it : use below api to discover name of subreport, 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1930 
'''''Not-57f0''''': [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ 
'''''Not-57f0''''': [iDempiere] globalqss ae38957 - IDEMPIERE-2324 Env.parseVariable(String, PO, String, boolean) doesn't use format when keepUnparseable / based on patch from Nicolas Micoud (nmicoud) 
'''''Not-57f0''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2324 status set to "Resolved" -assignee set to "Nicolas Micoud" -resolution set to "Fixed" 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2324 
'''''Not-57f0''''': [IDEMPIERE] deepak updated IDEMPIERE-2319 Attachment set to "Deepak_IDEMPIERE-2319.patch" 
'''''Not-57f0''''': [IDEMPIERE] Attaching patch with improvement 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2319 
'''''Not-57f0''''': [IDEMPIERE] deepak updated IDEMPIERE-2319 
'''''Not-57f0''''': [IDEMPIERE] Carlos, Ignore other patch and file. Deepak_IDEMPIERE-2319.patch contains all fixes 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2319 
'''''Deepak''''': Carlos, Can you review and merge IDEMPIERE-2319 too? 
'''''egil_ghintech''''': @CarlosRuiz Ready i reproduce it in demo.idempiere.com. create node email put it in transition after complete, create bp with my mail, configure my mail server to get mail, create invoice and it send mail but stay in the loop 
'''''egil_ghintech''''': @CarlosRuiz the user i create is egil@erpgain.com and pasword egil 
'''''egil_ghintech''''': and the invoice is 100003 
'''''nmicoud''''': CarlosRuiz : i found the bug ! between the chair and the keyboard... was trying to show a date on the message which was null ! 
'''''mand1nga''''': that'd qualify as a problem at the 8th layer (osi model) 
'''''CarlosRuiz''''': egil_ghintech, tried to complete 100003 and in the log appeared 
'''''CarlosRuiz''''': org.adempiere.exceptions.DBException: Could not lock record for MInvoice[1000024-100003,GrandTotal=20] caused by ERROR: canceling statement due to user request 
'''''CarlosRuiz''''': at org.compiere.db.DB_PostgreSQL.forUpdate(DB_PostgreSQL.java:1098) 
'''''CarlosRuiz''''': at org.compiere.process.DocumentEngine.processIt(DocumentEngine.java:238) 
'''''CarlosRuiz''''': at org.compiere.model.MInvoice.processIt(MInvoice.java:1378) 
'''''egil_ghintech''''': @CarlosRuiz yes this is the nextstep of the problem 
'''''egil_ghintech''''': @CarlosRuiz after stay the loop i have to restart server 
'''''egil_ghintech''''': to complete 
'''''CarlosRuiz''''': ah - it means the record is kept locked in the db 
'''''egil_ghintech''''': ok. but if you restart server 
'''''egil_ghintech''''': it going to try to complete and stay in loop 
'''''egil_ghintech''''': first of all did you check the workflow configuration? 
'''''CarlosRuiz''''': egil_ghintech, 
'''''CarlosRuiz''''': traced the issue 
'''''CarlosRuiz''''': it seems it is trying to commit 
'''''CarlosRuiz''''': but the commit is blocked by a SELECT IsPrinted FROM C_Invoice ... 
'''''egil_ghintech''''': @CarlosRuiz No entiendo 
'''''egil_ghintech''''': @CarlosRuiz Could yo be more explicit? what sould i do? 
'''''egil_ghintech''''': *should 
'''''Not-57f0''''': [IDEMPIERE] nmicoud created IDEMPIERE-2325 Env.parseVariable(String, PO, String, boolean) displays 'null' instead of '' 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2325 
'''''Not-57f0''''': [IDEMPIERE] nmicoud updated IDEMPIERE-2325 Attachment set to "IDEMPIERE-2325.patch" 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2325 
'''''Not-57f0''''': [IDEMPIERE] nmicoud updated IDEMPIERE-2325 status set to "Peer Review Queue" 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2325 
'''''Not-57f0''''': [IDEMPIERE] nmicoud updated IDEMPIERE-2325 labels set to "+Patch" 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2325 
'''''nmicoud''''': CarlosRuiz: found another real bug in parseVariable (please have a look at https://idempiere.atlassian.net/browse/IDEMPIERE-2325) ; thanks 
'''''CarlosRuiz''''': egil_ghintech, still don't know the cause - just traced the lock to that select 
'''''CarlosRuiz''''': and I see a candidate at LayoutEngine line 491 
'''''CarlosRuiz''''': hmm egil_ghintech 
'''''CarlosRuiz''''': locally I cannot reproduce it 
'''''CarlosRuiz''''': so is possible that is caused by a plugin installed on demo? 
'''''egil_ghintech''''': but what about the workflow configuration? 
'''''egil_ghintech''''': @CarlosRuiz it is ok? 
'''''egil_ghintech''''': But in demo.idempiere.com i did not add any pluging 
'''''CarlosRuiz''''': but others can 
'''''egil_ghintech''''': and the problem happend. that is rare 
'''''egil_ghintech''''': ah ok 
'''''Deepak''''': Hello Carlos 
'''''Deepak''''': did you reviewed IDEMPIERE-2319? 
'''''CarlosRuiz''''': no - not yet - I would like to stabilize first zk7 before merging into dev and start adding things to r3 
'''''Deepak''''': ohk 
'''''Deepak''''': But that may result in code conflicts later if not accepted 
'''''Not-57f0''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2288 status set to "Resolved" -assignee set to "Jan Thielemann" -resolution set to "Fixed" 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2288 
'''''Not-57f0''''': [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ 
'''''Not-57f0''''': [iDempiere] jthielemann af3a1b5 - IDEMPIERE-2288 Load custom ToolbarButton Images (IAction) from OSGi Bundle 
'''''egil_ghintech''''': @CarlosRuiz i made a new instalation standard, did the same test and it happens. The loop is there. I though it was a problem with iuimobile pluging that is instaled in demo.idempiere.com and i had it to but no. 
'''''Not-57f0''''': [IDEMPIERE] norbert.bede updated IDEMPIERE-2321 
'''''Not-57f0''''': [IDEMPIERE] My opinion is HighVolume has also another functional feature in such cases better to start window always with high performance not with simple window. (dedicated tole to heavy document entry...orders). IMHO would be nice to get it to window customisation too...low prio but prefer it well. Then i can setup for all default IsHighVolume=N - because much easier for beginner users and new customer presentation :) then i can limit client(custom 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2321 
'''''CarlosRuiz''''': egil_ghintech, reinstalling demo without plugins ... 
'''''egil_ghintech''''': great 
'''''TurkerTunali''''': test 
'''''CarlosRuiz''''': egil_ghintech, demo is ready - clean 
'''''CarlosRuiz''''': I'll be out for 1 hour - in the meantime can you please recreate the test case 
'''''CarlosRuiz''''': brb 
'''''egil_ghintech''''': @CarlosRuiz tell me to create the enviroment again 
'''''egil_ghintech''''': ok 
'''''egil_ghintech''''': Ready 
'''''egil_ghintech''''': the invoce created is 100001 
'''''egil_ghintech''''': the user and password used egil@erpgain.com and password egil. 
'''''egil_ghintech''''': all the time i have the email 
'''''TurkerTunali''''': hello 
'''''egil_ghintech''''': back of coffee time 
'''''egil_ghintech''''': @CarlosRuiz the test case was recreated. 
'''''CarlosRuiz''''': yep - and I see is stuck on the same point 
'''''TurkerTunali''''': do you guys use test server, or somehow test it with remote debug? 
'''''egil_ghintech''''': Hi TurkerTunali 
'''''TurkerTunali''''': Hi 
'''''egil_ghintech''''': Could you please explin a little bit what doo you need? 
'''''TurkerTunali''''': I just curious about how do you test and debug collaboratively 
'''''TurkerTunali''''': do you connect to same test server or anything else? 
'''''egil_ghintech''''': Ok i did not understood what you say. That's a question for carlos. But for example now to check the case of workflow, we just use the demo server and make the changes there 
'''''TurkerTunali''''': alright 
'''''egil_ghintech''''': I really do not know if for advance test case the developers of the comunity have a common test server 
'''''CarlosRuiz''''': seems like the culprit is "Document Business Partner" on the workflow - now the test failed locally - before I left that field empty 
'''''egil_ghintech''''': Ok, Interesting. I am going to check it. But it is a bug ? 
'''''CarlosRuiz''''': yep - must be 
'''''CarlosRuiz''''': hard to trace 
'''''egil_ghintech''''': ummm well is good to to find it to solve it. Do you need i create a ticket on Jira? 
'''''egil_ghintech''''': At least i know i was doing the rigth way :) 
'''''egil_ghintech''''': It works! But is needed to send to the bp of the document 
'''''egil_ghintech''''': In the group i put also an image with some warnigs that happens always when i complete a document with the email node. 
'''''CarlosRuiz''''': ready egil_ghintech - found the guilty 
'''''egil_ghintech''''': Who was? 
'''''Not-57f0''''': [IDEMPIERE] carlosruiz_globalqss created IDEMPIERE-2326 Deadlock on workflow email after complete 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2326 
'''''Not-57f0''''': [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±2] https://bitbucket.org/idempiere/idempiere/commits/ 
'''''Not-57f0''''': [iDempiere] globalqss 168a925 - IDEMPIERE-2326 Deadlock on workflow email after complete 
'''''Not-57f0''''': [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2326 status set to "Resolved" -resolution set to "Fixed" 
'''''Not-57f0''''': [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2326 
'''''CarlosRuiz''''': you can see here https://bitbucket.org/idempiere/idempiere/commits/168a925 
'''''egil_ghintech''''': Ok :) excelent. Thanks 
'''''CarlosRuiz''''': will be out for another 1h :-) c u later 
'''''aguerra''''': Carlos in the same way, how to use context varibales? in payment , to select username ?? I am using @C_BPartner.Name@ 
'''''egil_ghintech''''': Tested work perfect

IDempiere/FullMeeting20141119 - Revision history

CarlosRuiz: drop JIRA notifications from log

CarlosRuiz: full meeting