CarlosRuiz: full meeting

2012-12-19T15:49:23Z

full meeting

New page

⇐
[[IDempiere|Table of Contents]] |
[[IDempiere/Full Meeting Minutes|Full Meeting Minutes]] |
Full Meeting 2012-12-19


'''''CarlosRuiz''''': Good Morning 
'''''nmicoud''''': Bonjour 
'''''CarlosRuiz''''': how're things going Nicolas? 
'''''nmicoud''''': Well, nearly in holidays ;) 
'''''CarlosRuiz''''': ah yes - same here - next week I'll be on vacations 
'''''nmicoud''''': so, everything's fine ! 
'''''nmicoud''''': will try to disconnect completly, at least for some days 
'''''nmicoud''''': and will be back in 2013 to rule the world using idempiere :)) 
'''''CarlosRuiz''''': trying to plan some vacations activities and found skydive close to where I'll be :-) 
'''''nmicoud''''': travelling ? 
'''''CarlosRuiz''''': yep - going to the caribbean 
'''''nmicoud''''': great ! 
'''''nmicoud''''': have fun 
'''''nmicoud''''': motivated to work on some tickets today ? 
'''''CarlosRuiz''''': as always :-) reading your comments on IDEMPIERE-526 
'''''nmicoud''''': yes, i think i'm close to the solution, but i'm missing something 
'''''CarlosRuiz''''': in your example B is summary - and A,C,D are leafs? 
'''''nmicoud''''': yes 
'''''CarlosRuiz''''': ah I see - using "move item here" behaves different than dropping 
'''''nmicoud''''': yep 
'''''nmicoud''''': "move item" method (which i called cut/paste) seems to work properly 
'''''CarlosRuiz''''': back to AdempiereTreeModel - saveChangedNodes 
'''''tbayen''''': Daarestiet! 
'''''nmicoud''''': seems that the "to.getChildCount()" retrieves a false value ; that's why the from node is updated twice 
'''''nmicoud''''': hi thomas 
'''''tbayen''''': Did not Jens say he implemented lazy trees? Is this in the tree already? It might be that this bug goes away if he reworked the tree code. 
'''''tbayen''''': ...in the trunk.. 
'''''nmicoud''''': i don't think that the trunk was updated with lazy trees 
'''''nmicoud''''': This bug seems to be very old 
'''''tbayen''''': IDEMPIERE-531 "Lazy Loading Trees" - you should look there if you work on it 
'''''CarlosRuiz''''': I think JanThielemann 
'''''nmicoud''''': i don't work on it ; Jan did it for a customer and was ready to share this feature if his customer agreed 
'''''tbayen''''': No code there. JanThielemann, is there a contribution? 
'''''CarlosRuiz''''': Nicolas 
'''''CarlosRuiz''''': in the case of drop the to has the moved node twice 
'''''tbayen''''': He should tell if he agrees you will repair the c&p-Bug for him. ;-) 
'''''nmicoud''''': :)) 
'''''tbayen''''': So his customer will understand the principles of open source 
'''''nmicoud''''': Carlos, do you see a reason ? 
'''''CarlosRuiz''''': seems like with the cut/paste the cut removes the node from the tree and then insert it again 
'''''CarlosRuiz''''': meanwhile the drop is not removing it first 
'''''nmicoud''''': i've try to play with VTReeTransferHAndler_importData 
'''''nmicoud''''': where there is a if statement dedicated to d&d ; to remove the node ; but was not succesful 
'''''CarlosRuiz''''': where is the "move item" event captured? 
'''''nmicoud''''': in VTreeTransferHandler, no ? 
'''''CarlosRuiz''''': VTreePanel line 789 
'''''nmicoud''''': i see it 
'''''CarlosRuiz''''': so - according to that the solution would be that the drop event removes the node from the old position before calling save 
'''''nmicoud''''': when this 'remove' is done ? and where ? 
'''''CarlosRuiz''''': haven't found 
'''''nmicoud''''': d&d and move should arrive to a same class/method ? the only difference is in VtreeTransferHandler.importData, nope ? 
'''''CarlosRuiz''''': Nicolas 
'''''CarlosRuiz''''': I'm trying this one 
'''''CarlosRuiz''''': diff -r db4bbc33f63a org.adempiere.ui.swing/src/org/compiere/grid/tree/VTreeTransferHandler.java 
'''''CarlosRuiz''''': --- a/org.adempiere.ui.swing/src/org/compiere/grid/tree/VTreeTransferHandler.java Wed Dec 19 18:18:26 2012 +0800 
'''''CarlosRuiz''''': +++ b/org.adempiere.ui.swing/src/org/compiere/grid/tree/VTreeTransferHandler.java Wed Dec 19 08:58:12 2012 -0500 
'''''CarlosRuiz''''': @@ -97,6 +97,7 @@ 
'''''CarlosRuiz''''': if (from == to) 
'''''CarlosRuiz''''': return false; 
'''''CarlosRuiz''''': 
'''''CarlosRuiz''''': + model.removeNodeFromParent(from); 
'''''CarlosRuiz''''': index = dl.getChildIndex(); 
'''''CarlosRuiz''''': if ( index == -1 ) 
'''''CarlosRuiz''''': index = 0; // insert as first child 
'''''CarlosRuiz''''': but the parent is not removing the children 
'''''CarlosRuiz''''': I mean - the line that I'm adding must remove the A org when dropping it - but it's not - troubleshooting why 
'''''nmicoud''''': ok 
'''''nmicoud''''': CarlosRuiz, could it also be related to the window used ? APanel or VTreeMaintenance ??? 
'''''CarlosRuiz''''': as I see the item is removed from the node - but from a different MTreeNode object 
'''''nmicoud''''': that would explain the problem ; where do you see it ? 
'''''CarlosRuiz''''': on the line I added 
'''''a42niem''''': hi all 
'''''CarlosRuiz''''': if you navigate inside the removeNodeFromParent - the parent GW has a different id than the from out 
'''''CarlosRuiz''''': Hi Dirk 
'''''tbayen''''': Daarestiet, Dirk! 
'''''nmicoud''''': Hi Dirk 
'''''nmicoud''''': i'm looking 
'''''a42niem''''': buenos dias Carlos, guten tag Thomas, bonjour Nicolas :) 
'''''CarlosRuiz''''': Hi Jens 
'''''tbayen''''': Hi Jens 
'''''tbayen''''': CarlosRuiz, I want to look at IDEMPIERE-454 (import/export). Is there anything new you are working on but is not yet released? 
'''''jmpiloq''''': HI CarlosRuiz 
'''''jmpiloq''''': Hi tbayen 
'''''CarlosRuiz''''': Thomas - we have been working with Juan trying to define how to mark the keycolumns on the csv header 
'''''CarlosRuiz''''': and the action to take with such keys 
'''''CarlosRuiz''''': our agreement until now is to use 
'''''CarlosRuiz''''': /KI /KM /KU annotations after the columnname 
'''''CarlosRuiz''''': for insert / update or merge operations over the key 
'''''a42niem''''': hallo Jens 
'''''tbayen''''': You annotate this in the header - not for every key? So the whole file is an insert or a update file? 
'''''CarlosRuiz''''': yes - I think action is per file 
'''''CarlosRuiz''''': Jens - struggling today with nmicoud trying to catch a bug on treepanel 
'''''CarlosRuiz''''': http://jira.idempiere.com/browse/IDEMPIERE-526 
'''''CarlosRuiz''''': nmicoud, I have an ugly patch - but seems is working :-) 
'''''nmicoud''''': great ! 
'''''nmicoud''''': we'll try to make it nice ina 2nd time 
'''''CarlosRuiz''''': uploaded - can you please test it? 
'''''nmicoud''''': yep, i'll do it 
'''''nmicoud''''': Exception in thread "AWT-EventQueue-0" java.lang.IllegalArgumentException: node does not have a parent. in organization window, try to move fertilizer 
'''''CarlosRuiz''''': tbayen, integrated the pull-request 53 
'''''CarlosRuiz''''': thanks 
'''''tbayen''''': :-) 
'''''tbayen''''': CarlosRuiz, the importer is not implemented in Swing, isn't it? 
'''''CarlosRuiz''''': nope - just zk at this moment 
'''''CarlosRuiz''''': but implementing the button on swing must be easy 
'''''tbayen''''': I looked into AExport.java how it was done. (I am not used to this code part yet.) Would'nt it be better to call a process (and open the standard process parameter window)? 
'''''tbayen''''': AExport opens two question-windows one after each other. In zk it looks nicer (like the parameter input of process). 
'''''buildmaster''''': Project iDempiere build #611: SUCCESS in 8 min 28 sec: http://jenkins.idempiere.com/job/iDempiere/611/ 
'''''buildmaster''''': * Carlos Ruiz <carg67@gmail.com>: Merged in tbayen/idempiere (pull request #53: IDEMPIERE-428, IDEMPIERE-81, equinox launcher version independence in adempiere-client.sh) 
'''''buildmaster''''': * hg: use of the equinox launcher is version independent 
'''''buildmaster''''': * tbayen: Merge with cf39fc7edafa6439d3e44e564c20e1c869cab0b6 
'''''buildmaster''''': * tbayen: Script did not work with actual plugin version. Enhancement for calling with VM args 
'''''CarlosRuiz''''': tbayen, the idea is to export content from the window 
'''''tbayen''''': I understand: The process has no direct access to the window, right? 
'''''CarlosRuiz''''': nmicoud, you're right - patch is behaving very badly 
'''''CarlosRuiz''''': yes tbayen - no access to window info 
'''''nmicoud''''': and it worked for you ? at least once ? 
'''''tbayen''''': Hmmm.... thinking.... why should the export/import be dependend from a window? We could use it in scripts later for automatic importing. 
'''''CarlosRuiz''''': it worked from within eclipse when I was playing 
'''''CarlosRuiz''''': after I logged out and in - it's showing now the error you said 
'''''nmicoud''''': i've tried it within eclipse the 1st time 
'''''nmicoud''''': it throws this error 
'''''tbayen''''': It may be dependend from the definition of a window (which means from a given window ID). Perhaps you could give a "preferred" tab (and use the frontmost for that). But I should not depend on an opened window. 
'''''CarlosRuiz''''': nmicoud, 
'''''CarlosRuiz''''': reading aboud DnD 
'''''CarlosRuiz''''': http://docs.oracle.com/javase/tutorial/uiswing/dnd/intro.html 
'''''CarlosRuiz''''': what I think is that the class didn't implement properly the drag event - just the drop 
'''''CarlosRuiz''''': the drag event must behave like the cut 
'''''jmpiloq''''': CarlosRuiz: our file looks different by now... 
'''''CarlosRuiz''''': maybe implementing exportAsDrag ? 
'''''CarlosRuiz''''': ah - interesting - if Jens sources changes this - maybe we better wait for your code 
'''''nmicoud''''': yep 
'''''nmicoud''''': is that related to lazy trees ? 
'''''jmpiloq''''': nmicoud: yes 
'''''jmpiloq''''': i just attached that one file here: http://jira.idempiere.com/browse/IDEMPIERE-526 
'''''jmpiloq''''': dont know, if this works for idempiere as well, or if something is missing 
'''''jmpiloq''''': we still need to clean up a bit, since we have lots of other changes all over the place... 
'''''nmicoud''''': ok thanks, i'll have a look at it 
'''''tbayen''''': CarlosRuiz, some month ago we talked about JasperReports. I wanted them to reflect the active window. I wanted to get information about filter and order of the current window into the process. I did not solve this at this time (it is still on m list). This seems similar: Export looks like a process for me but it could use some information about GUI state. 
'''''CarlosRuiz''''': nmicoud, I don't have time to test it - but I think maybe implementing exportAsDrag to behave as cut can do the trick 
'''''nmicoud''''': ok carlos, i will have a look at last patch from Jens. And then have a look a exportAsDrag 
'''''nmicoud''''': will update ticket with test results 
'''''CarlosRuiz''''': thanks 
'''''CarlosRuiz''''': gtg now - c u then 
'''''nmicoud''''': bye bye 
'''''tbayen''''': cu 
'''''CarlosRuiz''''': thanks for the meeting 
'''''CarlosRuiz''''': may the FOSS be with you :-) 
'''''CarlosRuiz''''': ah - by the way 
'''''CarlosRuiz''''': happy new year!! I think I'm not going to attend next meeting (vacations) - so wishing you all a great 2013 - if world survives the mayan prophecy :-D 
'''''nmicoud''''': :)) 
'''''tbayen''''': Hapy new year too... First thing will do to adjust adempiere calendars to the new mayan age... Seems like a kind of the Y2K problem

IDempiere/FullMeeting20121219 - Revision history

CarlosRuiz: full meeting