CarlosRuiz: full meeting

2012-07-18T15:09:37Z

full meeting

New page

⇐
[[IDempiere|Table of Contents]] |
[[IDempiere/Full Meeting Minutes|Full Meeting Minutes]] |
Full Meeting 2012-07-18


'''''CarlosRuiz''''': Good morning 
'''''tbayen__''''': Daarestiet 
'''''red1''''': Hola and good morning from Libya 
'''''mzuniga_ergio''''': good morning 
'''''nmicoud''''': Bonjour ! 
'''''CarlosRuiz''''': I'll be checking JIRA issues - please let me know if you're interested in any specific issue to review 
'''''nmicoud''''': I'd be interested in 332 (http://jira.idempiere.com/browse/IDEMPIERE-332) ; document sequence enhancements 
'''''nmicoud''''': i've added a migration script to the ticket to replace package ; so it should be easier to review 
'''''CarlosRuiz''''': good - will check it 
'''''nmicoud''''': thanks 
'''''hahmed''''': Hello everyone 
'''''CarlosRuiz''''': Hi Hesham 
'''''hahmed''''': its quiet here so I guess I didn't miss anything 
'''''CarlosRuiz''''': :-) you didn't - reviewing JIRA tickets - Nicolas suggested 332 
'''''hahmed''''': any feedback on IDEMPIERE-341 (adding tab to ZKUI) so I can accordingly update IDEMPIERE-320 
'''''hahmed''''': is it common to use TAB in description, document Notes fields 
'''''CarlosRuiz''''': I'm not sure - sounds like "not a big deal" - personally I have never used tabs within descriptions, but opened that ticket to query input from others 
'''''a42niem''''': hi everyone 
'''''hahmed''''': hi a42niem 
'''''tbayen''''': Hi Dirk 
'''''nmicoud''''': hi 
'''''hahmed''''': the ability to navigate using TAB is however very useful, the tab behaviour for TextArea it is a major slowdown for high volume data entry using keyboard (1000 documents per day per user) 
'''''CarlosRuiz''''': yep agree 
'''''tbayen''''': hahmed, Yes - did not see this entry before. I fully agree. 
'''''CarlosRuiz''''': I would be fine if the editor allows to add Tabs / but seems like the editor doesn't either on zkwebui 
'''''hahmed''''': on swing we can use Ctrl+Tab (since shift+tab is used to focus previous) 
'''''CarlosRuiz''''': hahmed, can you check on your implementation if you still can add tabs using the field editor? (I mean, right-click -> Editor) 
'''''CarlosRuiz''''': I didn't conduct that test 
'''''hahmed''''': no can not since editor also uses CTextArea 
'''''Pavol''''': Hello community! Can somebody help me with idempiere zk customizations? 
'''''hahmed''''': Pavol: go ahead and ask 
'''''hahmed''''': CarlosRuiz: the only way to add tabs in ZK and in Swing after my changeset is to copy and paste from notepad etc 
'''''CarlosRuiz''''': well, sounds like a valid workaround - if the need is so unlikely as I suspect (nobody have asked about this before on webui) 
'''''Pavol''''': I was developing on adempiere until now, but I'd like to migrate on iDempiere, so... I succesfully cloned repository into my eclipse, created packages (buckminster..), all's working - running ZK. But I'd like to create an additional 'project' or 'plugin', which will completely replace old ZK classes (plugin from trunk) with lots of new customized ZK classes - something like zkcustomizations.jar in old adempiere 
'''''a42niem''''': i remember problems in using tab within a text area using the internal document engine 
'''''Pavol''''': in adempiere eclipse dev. workspace I was using another new project, which was using adempiere trunk in its classloader paths, so it works.. 
'''''red1''''': Pavol: maybe u can dupe the same zk plugins + actual changes under another name and just uncheck the old zk for your new one to take effect 
'''''red1''''': AFAIU that is the power of OSGi 
'''''hahmed''''': Pavol: what kind of classes are you replacing? Models? Can you not do the same using some other mechanism (model validators, callouts etc) 
'''''hahmed''''': CarlosRuiz: so you can then review my changeset and integrate it for swing IDEMPIERE-320 
'''''CarlosRuiz''''': I made some comments yesternight 
'''''Pavol''''': And is there some trick, how to create some "customization" plugin, which will completely replace classes from target plugin if deploy on server? 
'''''CarlosRuiz''''': ah / you already fixed 
'''''CarlosRuiz''''': you're fast :-) 
'''''hahmed''''': :) 
'''''CarlosRuiz''''': http://demo.idempiere.com/webui/ was just updated 
'''''CarlosRuiz''''': you can enjoy the new "Info Product" window brought to you by Hahmed 
'''''Pavol''''': hahmed: The problem is, that it's not only models.. but also lots of classes like AbstractAdWindowPanel etc. and also new funcionalities 
'''''hahmed''''': Pavol: new functionalities can be added in a new plugin, replacing existing classes, AFAIK, would require changes to iDempiere source, unlike before you can not add a new jar to replace existing classes 
'''''hahmed''''': Pavol: Let me check one thing however 
'''''nmicoud''''': i've read spec for the new InfoProduct window, souds very interesting ! Thanks a lot ; just my 2 cents : the link label for the panel is "Product &Info" ; maybe try to remove "&" ? 
'''''CarlosRuiz''''': agree Nicolas 
'''''CarlosRuiz''''': found the fix on DPViews - testing 
'''''Pavol''''': hahmed: Ok, so if I can add new funcionalities into ZK, replacing lots of existing classes - I've to create new plugin and "configure" this plugin to replace existing classes in ZK plugin? 
'''''nmicoud''''': and 2 other cents : link for RecordInfo panel seems to be left align ; shouldn't be right align ? ; at first sight, i thought it was missing 
'''''red1''''': Pavol, previously it was java overload, now it is plugin replacement so you can decouple the old one .. or recouple the old one easily, unlike before 
'''''CarlosRuiz''''': Pavol - it can be good also to check with community if the need of changing AbstractAdWindowPanel is caused because a lack of an extension point 
'''''red1''''': cya later.. leaving office. 
'''''CarlosRuiz''''': c u red1 
'''''tbayen''''': c u 
'''''Pavol''''': bye 
'''''CarlosRuiz''''': nmicoud, what is "link for RecordInfo panel" 
'''''nmicoud''''': 1/1 or 1/2 at the bottom of windows 
'''''nmicoud''''': it shows number of records 
'''''CarlosRuiz''''': seems fine here with product window showing "1/53" 
'''''hahmed''''': Pavol: new plugin to add NEW functionality, for replacing no way other than to change iDempiere source 
'''''nmicoud''''': on Djoudi and Sales order windows, "x/y" are left align. You don't have the same ? 
'''''CIA-93''''': iDempiere: globalqss * a975d403666c r7403 /org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/DPViews.java: related to IDEMPIERE-337 / as suggested by NMicoud on weekly iDempiere meeting - drop the & from the info product link 
'''''CarlosRuiz''''': no, that textbox is on the right 
'''''CarlosRuiz''''': small and on down - right corner 
'''''nmicoud''''': :-/ 
'''''nmicoud''''': i'll try with another browser 
'''''nmicoud''''': it's ok using google chrome, and nok using FF 
'''''CarlosRuiz''''': checking with FF ... 
'''''Pavol''''': And if I create new functionalities, and my changes (my own plugin, new classes) need to override some trunk classes (only for my use) - is there some solution without ExtensionPoints? red1 introduced some plugin replacement, I'm looking for something like plugin overload 
'''''hahmed''''': Pavol: you can use fragment project, but it still requires changing the base plugins MANIFEST 
'''''CarlosRuiz''''': nmicoud, on firefox it appears a big box using half of the status line 
'''''nmicoud''''': yep 
'''''CarlosRuiz''''': I would recommend to open a zk6 jira ticket / attaching the screenshot and mentioning that is specific to firefox 
'''''Pavol''''': hahmed: Ok, I'll search some info about fragmented osgi plugins 
'''''hahmed''''': Pavol: http://wiki.eclipse.org/Steps_to_use_Fragments_to_patch_a_plug-in 
'''''nmicoud''''': ok, 'ill do it Carlos ; 
'''''buildmaster''''': Project iDempiere build #243: SUCCESS in 21 min: http://jenkins.idempiere.com/job/iDempiere/243/ 
'''''buildmaster''''': globalqss: related to IDEMPIERE-337 / as suggested by NMicoud on weekly iDempiere meeting - drop the & from the info product link 
'''''nmicoud''''': CarlosRuiz : did you manage to test ticket 332 ? i think you're doing it on postgresql and i can't test it (i got only oracle databse) 
'''''CarlosRuiz''''': not yet 
'''''CarlosRuiz''''': now checking 320 
'''''nmicoud''''': ok 
'''''CIA-93''''': iDempiere: hahmed * b5751f19c0b7 r7404 / (3 files in 3 dirs): 
'''''CIA-93''''': iDempiere: IDEMPIERE-320 - Make Swing CTextArea consistent with ZK 
'''''CIA-93''''': iDempiere: (transplanted from 994a9b5493ddba3c2a10e64ccf7377d8ae69b398) 
'''''CIA-93''''': iDempiere: hahmed * e76509b90442 r7405 / (5 files in 3 dirs): 
'''''CIA-93''''': iDempiere: IDEMPIERE-320 - Make Swing CTextArea consistent with ZK 
'''''CIA-93''''': iDempiere: (transplanted from 1c201bf217991c1d82d05f8eaa4bc2711d69c355) 
'''''CarlosRuiz''''': ready - moving to 332 
'''''nmicoud''''': have fun ;-) 
'''''CarlosRuiz''''': so, the IDEMPIERE-332_DB_Change_AD_Sequence_No.sql was not integrated on the migration scripts 
'''''CarlosRuiz''''': neither IDEMPIERE-332_OracleProcedures.sql 
'''''CarlosRuiz''''': ok, I'll need more time to test this and port the two scripts to postgresql 
'''''nmicoud''''': yes, because it was manually made and tested only on oracle 
'''''CarlosRuiz''''': don't worry, I'll port to postgres 
'''''nmicoud''''': fine 
'''''CarlosRuiz''''': seems like you reformatted the code :-) is showing changes on many lines about tabs and spaces 
'''''nmicoud''''': that's possible 
'''''CarlosRuiz''''': ah / the attached patch applied cleanly on 361 
'''''nmicoud''''': yep, done on 361, not idempiere 
'''''CarlosRuiz''''': nmicoud, at first sight the code seems right - but I need to conduct tesets 
'''''CarlosRuiz''''': tests 
'''''nmicoud''''': ok, fine 
'''''CarlosRuiz''''': so, please let me check it deeply 
'''''nmicoud''''': yep, no problem, modification are huge, so it need time 
'''''CarlosRuiz''''': the tab and space changes makes the peer review harder too 
'''''CarlosRuiz''''': because you cannot realize if something was changed or is just cosmetic :-) 
'''''buildmaster''''': Project iDempiere build #244: SUCCESS in 22 min: http://jenkins.idempiere.com/job/iDempiere/244/ 
'''''buildmaster''''': * hahmed: IDEMPIERE-320 - Make Swing CTextArea consistent with ZK 
'''''buildmaster''''': (transplanted from 1c201bf217991c1d82d05f8eaa4bc2711d69c355) 
'''''buildmaster''''': * hahmed: IDEMPIERE-320 - Make Swing CTextArea consistent with ZK 
'''''buildmaster''''': (transplanted from 994a9b5493ddba3c2a10e64ccf7377d8ae69b398) 
'''''CarlosRuiz''''': I like it - I'll try to test it this week 
'''''nmicoud''''': ok 
'''''CarlosRuiz''''': need to go - thanks for the meeting - c u later

IDempiere/FullMeeting20120718 - Revision history

CarlosRuiz: full meeting