CarlosRuiz: minor fix

2012-04-18T16:11:28Z

minor fix

CarlosRuiz: full meeting

2012-04-11T15:24:21Z

full meeting

New page

⇐
[[IDempiere|Table of Contents]] |
[[IDempiere/Full Meeting Minutes|Full Meeting Minutes]] |
Full Meeting 2012-04-1


'''''CarlosRuiz''''': Good morning 
'''''tbayen''''': Daarestiet! 
'''''nicolas''''': Hi ! 
'''''a42niem''''': hi 
'''''a42niem''''': a question concerning Tollbar Button Restrict: 
'''''a42niem''''': would this also be cofigurable per tab? 
'''''CarlosRuiz''''': not at this moment 
'''''hengsin''''': hi Carlos 
'''''CarlosRuiz''''': hi Heng Sin 
'''''a42niem''''': i know, that is why i am asking 
'''''CarlosRuiz''''': ah, you mean in future :-) 
'''''a42niem''''': yes, i did not look into the code. is the principle used extendable to tab in window instead of complete window? 
'''''CarlosRuiz''''': sounds like interesting extension of the concept - but not easy with the approach we followed 
'''''a42niem''''': okay 
'''''tbayen''''': For me it makes more sense when configured per tab. 
'''''hengsin''''': carlos, joel.s want to push forward the zk6 schedule. ok 4 u to move the 1.0 release to June to accomodate that ? 
'''''CarlosRuiz''''': yes Heng Sin - june sounds better 
'''''tbayen''''': Before you redo the button restrictions: Some weeks ago we talked about configuring new buttons (or all buttons) for every window or tab. Is anybody working on this? 
'''''tbayen''''': CarlosRuiz pointed me to http://www.adempiere.com/ADempiere_Multiple_Record_Action_Field 
'''''CarlosRuiz''''': I added some columns (for future use) to AD_ToolBar to allow customized buttons 
'''''CarlosRuiz''''': but they are just added there as "for future use" - it needs development 
'''''a42niem''''': is it all the fileds visible when you check "Customization"? 
'''''hengsin''''': ok, will target to merge the zk6 port by end of April. 
'''''CarlosRuiz''''': yep Dirk 
'''''Edwin_ang''''': hi everyone 
'''''a42niem''''': ok 
'''''CarlosRuiz''''': hi Edwin 
'''''Edwin_ang''''': hi carlos 
'''''Edwin_ang''''': what's the topic tonite? :) 
'''''CarlosRuiz''''': open meeting as usual 
'''''nicolas''''': I don't know if it is the right place to ask, but i've added a new column in CreateFromStatement ; this column (read/write) allow user to choose the 'Statement Line Date' (default is payment date) 
'''''tbayen''''': Is anoybody than me interested in configurable toolbar buttons and wants to think together how to do it? I could not find a tracker item for this. 
'''''nicolas''''': it works perfectly in swing but in webUI, when leaving the field, it became 'Tue Sep 20 00:00:00 CEST 2011' (whereas is should looks like 2011/09/20) 
'''''nicolas''''': any idea where to look ? 
'''''CarlosRuiz''''': tbayen, still not JIRA, yes, it's interesting and we can discuss possible implementation these meetings or JIRA ticket 
'''''CarlosRuiz''''': nicolas, do you mean a new parameter on process? or field in a form? which type? 
'''''nicolas''''': a new column in the form 
'''''nicolas''''': Timestamp 
'''''nicolas''''': you can find class here : http://nicolas.micoud.free.fr/trucs/CreateFromStatement.java 
'''''tbayen''''': I will think about it for a second(TM) and create a brainstorming page. 
'''''CarlosRuiz''''': and that new column is modifiable by user 
'''''nicolas''''': yes 
'''''nicolas''''': he can choose directly the date of the bank statement line 
'''''CarlosRuiz''''': testing locally .... let me check 
'''''CarlosRuiz''''': I like the concept - but the first column could be reused instead of adding a new one 
'''''nicolas''''': it could be an option, but i'd prefer to have both (original and new one) so user can compare 
'''''nicolas''''': btw i never try to do it with the first column, but i think the problem will be the same 
'''''CarlosRuiz''''': yes - same problem 
'''''nicolas''''': i've search another form with this behaviour and find no one. 
'''''nicolas''''': any idea on how to deal it ? 
'''''CarlosRuiz''''': looking for the implemenation of the MiniTable 
'''''nicolas''''': configureMiniTable (IMiniTable miniTable) ? 
'''''CarlosRuiz''''': seems like the problem is in WListBox.tableValueChange 
'''''CarlosRuiz''''': line 947 
'''''CarlosRuiz''''': it's not formatting the date 
'''''nicolas''''': great ! and you know how to do it ? 
'''''nicolas''''': if you look at WListItemRenderer.onEvent (line 518) ; some type are concerned, but not Timestamp. Is this where there is a lack ? 
'''''CarlosRuiz''''': I'm trying to check where the format is changed 
'''''CarlosRuiz''''': but seems is deeper in listeners 
'''''nicolas''''': ok 
'''''CarlosRuiz''''': nope - didn't work - I guess is better to open a JIRA ticket to research this 
'''''nicolas''''': ok, i'll do this ; thanks 
'''''CarlosRuiz''''': something like -> minitable implementation on zk doesn't manage editable timestamp properly 
'''''nicolas''''': fine 
'''''nicolas''''': ticket 233 created 
'''''nicolas''''': want to talk about hardcoded ID ? 
'''''CarlosRuiz''''': yep 
'''''nicolas''''': i think that we agree on a first step which will be a top level class 
'''''nicolas''''': After, you talked about making it parameterizable, so it means, deal it within a table 
'''''nicolas''''': i suggest to create a new one instead of using AD_SysFongi 
'''''nicolas''''': 'AD_SysConfig' 
'''''nicolas''''': it allow a better view than having just an ID in a string field 
'''''nicolas''''': WDYT ? 
'''''CarlosRuiz''''': ah - seems like I found the fix for 233 :-) 
'''''CarlosRuiz''''': will upload there for your tests 
'''''CarlosRuiz''''': let's start with the HardCodedIDs class 
'''''nicolas''''': You're my hero !!! 
'''''CarlosRuiz''''': I'm not sure about - AD_SysConfig is mostly intended for such things - but maybe it's not good opening so much sysconfigs :-) 
'''''CarlosRuiz''''': maybe it depends on the number of hardcoded IDs we find 
'''''nicolas''''': yes, i think SysConfig is to make user experience configurable ; 
'''''nicolas''''': where as hardcodedID are here for developers 
'''''nicolas''''': the aim is different 
'''''CarlosRuiz''''': no, I think SysConfig is mostly to avoid hardcodes 
'''''CarlosRuiz''''': well - at least that was the initial idea :-D but use was expanded quickly 
'''''nicolas''''': Yes, you're right, but IMHO, the aim of SysConfig is to store things (ID, parameters) for user level ; not for developers 
'''''nicolas''''': for sure :-) 
'''''nicolas''''': maybe a newbie question : where should we store this class ? 
'''''CarlosRuiz''''': I propose - let's start with the HardCodedIDs.java - and depending on the number of IDs there - we make a decision about sysconfig or new table 
'''''CarlosRuiz''''': hmmm - base/src/org.compiere.model maybe?? 
'''''nicolas''''': ok, let's do this 
'''''nicolas''''': yep 
'''''CarlosRuiz''''': I uploaded a patch for IDEMPIERE-233 - worked on my local tests - but I'm not sure if it breaks something else 
'''''nicolas''''': got it, thanks, i'll test it 
'''''CarlosRuiz''''': and is a change to a zk core class - so better to have the peer review from Heng Sin, and tests on the rest of UI 
'''''CarlosRuiz''''': yes - definitely a peer review from hengsin is required - WListItemRenderer is widely used 
'''''nicolas''''': o 
'''''nicolas''''': k 
'''''nicolas''''': patch tested and approved (for this form) ; i update ticket 
'''''CarlosRuiz''''': thanks for the meeting - c u later

@@ Line 4: / Line 4: @@
 [[IDempiere|Table of Contents]] |
 [[IDempiere/Full Meeting Minutes|Full Meeting Minutes]] |
-Full Meeting 2012-04-1
+Full Meeting 2012-04-11
 </font>

IDempiere/FullMeeting20120411 - Revision history

CarlosRuiz: minor fix

CarlosRuiz: full meeting