*** lcak <lcak!def7268e@222.247.38.142> has joined #idempiere | 01:08 | |
*** hieplq <hieplq!~hieplq@2405:9800:bc10:b6a7:b1d5:3aa0:dfde:d70> has joined #idempiere | 01:36 | |
*** hieplq <hieplq!~hieplq@2405:9800:bc10:b6a7:b1d5:3aa0:dfde:d70> has quit IRC | 02:12 | |
*** aguerrave <aguerrave!~aguerrave@190.153.25.70> has quit IRC | 02:21 | |
Not | [iDempiereDaily] jenkins build #118 started http://ci.idempiere.org/job/iDempiereDaily/118/ | 03:08 |
---|---|---|
Not | [iDempiereDaily] jenkins build #118 completed: success http://ci.idempiere.org/job/iDempiereDaily/118/ | 03:34 |
*** barg4barg <barg4barg!~barg4@212.248.31.220> has joined #idempiere | 06:21 | |
*** barg4_ <barg4_!~barg4@46.166.143.112> has joined #idempiere | 06:21 | |
*** barg4barg <barg4barg!~barg4@212.248.31.220> has quit IRC | 06:26 | |
*** norbertbede1 <norbertbede1!~Adium@94.228.89.101> has joined #idempiere | 07:06 | |
*** hieplq <hieplq!~hieplq@2405:9800:bc10:b6a7:b1d5:3aa0:dfde:d70> has joined #idempiere | 07:09 | |
hieplq | hi @tbayen, your improve about naming of 2pack is great but not in core, right? https://wiki.idempiere.org/en/Developing_Plug-Ins_-_2Pack_-_Pack_In/Out#improved_Incremental2PackActivator | 07:11 |
*** Layda <Layda!~Layda@2a02:908:1460:6b40:78df:4317:854:f71a> has joined #idempiere | 07:20 | |
*** CarlosRuiz <CarlosRuiz!~CarlosRui@ip-95-223-107-26.hsi16.unitymediagroup.de> has joined #idempiere | 07:36 | |
*** CarlosRuiz <CarlosRuiz!~CarlosRui@ip-95-223-107-26.hsi16.unitymediagroup.de> has quit IRC | 07:43 | |
*** a42niem <a42niem!~niem@p578b7daf.dip0.t-ipconnect.de> has joined #idempiere | 07:45 | |
*** CarlosRuiz <CarlosRuiz!~CarlosRui@ip-95-223-107-26.hsi16.unitymediagroup.de> has joined #idempiere | 07:49 | |
*** fabiocanella <fabiocanella!~fabio@net-93-145-129-254.cust.vodafonedsl.it> has joined #idempiere | 08:10 | |
CarlosRuiz | Hi @hieplq | 08:11 |
CarlosRuiz | about > hi @tbayen, your improve about naming of 2pack is great but not in core, right? | 08:11 |
*** nmicoud <nmicoud!~Nicolas@2a01:e34:eeb6:cb10:58b6:133d:6ef8:10e2> has joined #idempiere | 08:12 | |
*** fabiocanella <fabiocanella!~fabio@net-93-145-129-254.cust.vodafonedsl.it> has quit IRC | 08:12 | |
CarlosRuiz | I think that page is outdated on the comment above when it says that Incremental2PackActivator will not install 1.0.3 - that was changed | 08:12 |
*** fabiocanella <fabiocanella!~fabio@net-93-145-129-254.cust.vodafonedsl.it> has joined #idempiere | 08:12 | |
hieplq | hi @CarlosRuiz, it look great improve, but when i test on my environment it isn't happen | 08:12 |
CarlosRuiz | and also - the change from tbayen is not in production AFAIK - but I think 2packs can have comment after the version | 08:13 |
hieplq | ok. will check comment on after version to see. it's same. i also like after version than before version | 08:13 |
CarlosRuiz | so, instead of 2Pack_Tables_1.0.0.zip - you can use 2Pack_1.0.0_Tables.zip | 08:14 |
CarlosRuiz | I edited the wiki page to include this info | 08:17 |
*** Hideaki <Hideaki!7e85ddba@om126133221186.21.openmobile.ne.jp> has joined #idempiere | 08:30 | |
*** Hideaki <Hideaki!7e85ddba@om126133221186.21.openmobile.ne.jp> has quit IRC | 08:40 | |
*** mpowacht <mpowacht!3d5a9c82@mail.zi-th.com> has joined #idempiere | 08:54 | |
*** mpowacht <mpowacht!3d5a9c82@mail.zi-th.com> has left #idempiere | 09:05 | |
*** Patric32 <Patric32!~Patric_32@090-006-045-005.ip-addr.inexio.net> has joined #idempiere | 09:08 | |
*** Layda <Layda!~Layda@2a02:908:1460:6b40:78df:4317:854:f71a> has quit IRC | 09:13 | |
*** Layda <Layda!~Layda@ip-95-223-107-26.hsi16.unitymediagroup.de> has joined #idempiere | 09:19 | |
*** barg4_ <barg4_!~barg4@46.166.143.112> has quit IRC | 09:37 | |
*** barg4barg <barg4barg!~barg4@46.166.143.122> has joined #idempiere | 09:42 | |
hieplq | @CarlosRuiz. i try with this one 2Pack_0.5.3_greatMore.zip but not success. reason:Incremental2PackActivator.extractVersionString will return 0.5.3_greatMore. so at Version(o1.version).compareTo(new Version(o2.version)) will throw exception incorrect version | 09:50 |
hieplq | Version constructor validate for it version.matches("[0-9]+(\\.[0-9]+)*") | 09:51 |
CarlosRuiz | ah - bad news then - I thought I used that in a previous plugin | 09:53 |
CarlosRuiz | maybe it was changed in recent modifications | 09:53 |
CarlosRuiz | would be good to allow that anyways | 09:54 |
*** tbayen <tbayen!~tbayen@46.114.4.200> has quit IRC | 10:32 | |
*** Layda <Layda!~Layda@ip-95-223-107-26.hsi16.unitymediagroup.de> has quit IRC | 10:33 | |
*** tbayen <tbayen!~tbayen@x2f7fe59.dyn.telefonica.de> has joined #idempiere | 10:58 | |
CarlosRuiz | hieplq, AYT? | 11:10 |
hieplq | yeb. learning about version parsing :). we can use this one https://maven.apache.org/ref/3.6.2/maven-artifact/apidocs/ | 11:11 |
CarlosRuiz | can you check a little patch to see if that works? | 11:11 |
CarlosRuiz | this one here | 11:12 |
CarlosRuiz | https://pastebin.com/e0A0x1xB | 11:12 |
CarlosRuiz | I haven't tested - but I think that must be enough to make the idea work | 11:13 |
hieplq | where you attach patch? i prefer to use maven-artifact because it's well document | 11:13 |
CarlosRuiz | like your 2Pack_0.5.3_greatMore.zip | 11:13 |
CarlosRuiz | ah no sorry - instead of == must be != | 11:13 |
CarlosRuiz | so, this one | 11:15 |
CarlosRuiz | https://pastebin.com/R8Q7MSWn | 11:15 |
hieplq | but your patch can make some duplicate version when i have 2Pack_0.5.3_greatMore.zip 2Pack_0.5.3_greatMorePackout.zip. not sure it get issue or not | 11:15 |
hieplq | i will try this one maven-artifact. it help we can easy version 2pack file | 11:16 |
CarlosRuiz | probably not - it just extract the version from the file name - but anyways I would not recommend having multiple 2packs with same version | 11:16 |
CarlosRuiz | I mean - I think it will work anyways - is just to take the 0.5.3 from the filename | 11:17 |
hieplq | yeb. i see you take only version part. the purpose of Version class for sort to apply 2pack on order. at moment it's simple to get enough pattern. wdyt if i modify to use maven-artifact library? we can order 2pack with freedom of naming on version part | 11:21 |
hieplq | this's document for version we can use https://cwiki.apache.org/confluence/display/MAVENOLD/Versioning | 11:21 |
CarlosRuiz | this patch is really simple and we can apply it now if your tests are ok | 11:22 |
CarlosRuiz | to move to maven artifact maybe we'll need more time to check for collaterals and test the full use cases | 11:22 |
CarlosRuiz | I think we can apply the patch now (if your tests are successful) and the maven artifact you suggest in the next version | 11:22 |
hieplq | ok. will test and review some where to sure non side effect | 11:23 |
*** pshepetko <pshepetko!b024ab09@host-176-36-171-9.la.net.ua> has joined #idempiere | 12:00 | |
*** aguerrave <aguerrave!~aguerrave@190.153.25.70> has joined #idempiere | 12:02 | |
hieplq | hi @CarlosRuiz, it working in case you append my change also https://pastebin.com/1LC4E0uv sorry newbie on smartGit | 12:28 |
Not | [IDEMPIERE] Diego Ruiz updated IDEMPIERE-2837 assignee set to "Carlos Ruiz" | 12:31 |
Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2837 | 12:31 |
Not | [IDEMPIERE] Diego Ruiz updated IDEMPIERE-2837 status set to "Peer Review Queue" | 12:31 |
Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2837 | 12:31 |
CarlosRuiz | great hieplq - can you please open a ticket and upload the patch there? | 12:33 |
hieplq | ok | 12:33 |
Not | [IDEMPIERE] Hiep Lq created IDEMPIERE-4105 add "comment" to 2pack file | 12:37 |
Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4105 | 12:37 |
Not | [IDEMPIERE] Hiep Lq updated IDEMPIERE-4105 Attachment set to "IDEMPIERE-4105.patch" | 12:41 |
Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4105 | 12:41 |
Not | [IDEMPIERE] Hiep Lq updated IDEMPIERE-4105 status set to "Peer Review Queue" | 12:41 |
Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4105 | 12:41 |
hieplq | please take it from https://idempiere.atlassian.net/browse/IDEMPIERE-4105 mr @CarlosRuiz | 12:42 |
CarlosRuiz | thanks hieplq | 12:42 |
*** barg4barg <barg4barg!~barg4@46.166.143.122> has quit IRC | 12:51 | |
*** norbertbede1 <norbertbede1!~Adium@94.228.89.101> has quit IRC | 12:51 | |
*** norbertbede1 <norbertbede1!~Adium@94.228.89.101> has joined #idempiere | 12:53 | |
*** Not <Not!~notifico@www.globalqss.com> has quit IRC | 12:55 | |
*** Gaurav47 <Gaurav47!4d45fb84@mail-4-22.batelco.com.bh> has joined #idempiere | 12:57 | |
*** Layda <Layda!~Layda@2a02:908:1460:6b40:78df:4317:854:f71a> has joined #idempiere | 13:21 | |
*** hieplq <hieplq!~hieplq@2405:9800:bc10:b6a7:b1d5:3aa0:dfde:d70> has quit IRC | 13:32 | |
*** hieplq <hieplq!~hieplq@2405:9800:bc10:b6a7:b1d5:3aa0:dfde:d70> has joined #idempiere | 13:41 | |
*** Not-f062 <Not-f062!~notifico@www.globalqss.com> has joined #idempiere | 13:50 | |
Not-f062 | [IDEMPIERE] FreePath updated IDEMPIERE-3209 assignee set to "FreePath" | 13:50 |
Not-f062 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3209 | 13:50 |
Not-f062 | [IDEMPIERE] FreePath updated IDEMPIERE-3209 Attachment set to "11543.patch" | 13:50 |
Not-f062 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3209 | 13:50 |
*** barg4barg <barg4barg!~barg4@46.166.143.104> has joined #idempiere | 13:51 | |
*** Gaurav47 <Gaurav47!4d45fb84@mail-4-22.batelco.com.bh> has quit IRC | 14:24 | |
Not-f062 | [IDEMPIERE] Hiep Lq updated IDEMPIERE-4105 Attachment set to "IDEMPIERE-4105_outOfIndex.patch" | 14:35 |
Not-f062 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4105 | 14:35 |
*** Patric32 <Patric32!~Patric_32@090-006-045-005.ip-addr.inexio.net> has quit IRC | 15:32 | |
*** Layda <Layda!~Layda@2a02:908:1460:6b40:78df:4317:854:f71a> has quit IRC | 15:46 | |
*** hieplq <hieplq!~hieplq@2405:9800:bc10:b6a7:b1d5:3aa0:dfde:d70> has quit IRC | 15:47 | |
Not-f062 | [IDEMPIERE] Carlos Ruiz updated IDEMPIERE-4105 status set to "Resolved" -assignee set to "Hiep Lq" -resolution set to "Fixed" | 16:13 |
Not-f062 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4105 | 16:13 |
Not-f062 | [iDempiere] 2 commits to default [+0/-0/±3] https://bitbucket.org/idempiere/idempiere/commits/ | 16:13 |
Not-f062 | [iDempiere] hie...@hasuvimex.vn 19a78e8 - IDEMPIERE-4105:add "comment" to 2pack file refine pack from Carlos | 16:13 |
Not-f062 | [iDempiere] hieplq 0831ba4 - IDEMPIERE-4105:fix out of bound exception when don't append "comment" | 16:13 |
Not-f062 | [IDEMPIERE] Carlos Ruiz updated IDEMPIERE-3209 status set to "Resolved" -resolution set to "Fixed" | 16:15 |
Not-f062 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3209 | 16:15 |
Not-f062 | [iDempiere] 1 commit to default [+0/-0/±3] https://bitbucket.org/idempiere/idempiere/commits/ | 16:15 |
Not-f062 | [iDempiere] freepath 2e397e6 - small changes on method accessors | 16:15 |
*** fabiocanella <fabiocanella!~fabio@net-93-145-129-254.cust.vodafonedsl.it> has quit IRC | 16:15 | |
Not-f062 | [IDEMPIERE] Diego Ruiz updated IDEMPIERE-2837 Attachment set to "IDEMPIERE-2837.patch" | 16:19 |
Not-f062 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2837 | 16:19 |
*** hieplq <hieplq!~hieplq@2405:9800:bc10:b6a7:b1d5:3aa0:dfde:d70> has joined #idempiere | 16:20 | |
Not-f062 | [iDempiere] jenkins build #227 started http://ci.idempiere.org/job/iDempiere/227/ | 16:21 |
Not-f062 | [iDempiere] jenkins build #227 completed: success http://ci.idempiere.org/job/iDempiere/227/ | 16:28 |
*** barg4barg <barg4barg!~barg4@46.166.143.104> has quit IRC | 16:33 | |
*** nmicoud <nmicoud!~Nicolas@2a01:e34:eeb6:cb10:58b6:133d:6ef8:10e2> has quit IRC | 16:37 | |
Not-f062 | [IDEMPIERE] Carlos Ruiz updated IDEMPIERE-2837 status set to "Open" -assignee set to "Diego Ruiz" | 17:07 |
Not-f062 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2837 | 17:07 |
Not-f062 | [IDEMPIERE] Diego Ruiz updated IDEMPIERE-2837 status set to "Resolved" -resolution set to "Fixed" | 17:16 |
Not-f062 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2837 | 17:16 |
Not-f062 | [iDempiere] jenkins build #228 started http://ci.idempiere.org/job/iDempiere/228/ | 17:21 |
Not-f062 | [IDEMPIERE] Carlos Ruiz created IDEMPIERE-4106 Dependent fields not cleared when changing a parent field | 17:21 |
Not-f062 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4106 | 17:21 |
Not-f062 | [iDempiere] jenkins build #228 completed: success http://ci.idempiere.org/job/iDempiere/228/ | 17:28 |
*** hieplq <hieplq!~hieplq@2405:9800:bc10:b6a7:b1d5:3aa0:dfde:d70> has quit IRC | 17:46 | |
Not-f062 | [iDempiere] 1 commit to release-6.2 [+0/-0/±2] https://bitbucket.org/idempiere/idempiere/commits/ | 19:38 |
Not-f062 | [iDempiere] globalqss 1b8b1fa - IDEMPIERE-4106 Dependent fields not cleared when changing a parent field / IDEMPIERE-3961 | 19:38 |
Not-f062 | [IDEMPIERE] Carlos Ruiz updated IDEMPIERE-4106 status set to "Resolved" -assignee set to "Carlos Ruiz" -resolution set to "Fixed" | 19:40 |
Not-f062 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4106 | 19:40 |
*** CarlosRuiz <CarlosRuiz!~CarlosRui@ip-95-223-107-26.hsi16.unitymediagroup.de> has quit IRC | 19:47 | |
Not-f062 | [iDempiere6.2] jenkins build #207 started http://ci.idempiere.org/job/iDempiere6.2/207/ | 19:50 |
Not-f062 | [iDempiere] jenkins build #229 started http://ci.idempiere.org/job/iDempiere/229/ | 19:51 |
Not-f062 | [iDempiere] jenkins build #229 completed: failure http://ci.idempiere.org/job/iDempiere/229/ | 20:02 |
Not-f062 | [iDempiere6.2] jenkins build #207 completed: success http://ci.idempiere.org/job/iDempiere6.2/207/ | 20:03 |
*** Layda <Layda!~Layda@2a02:908:1460:6b40:78df:4317:854:f71a> has joined #idempiere | 20:23 | |
*** tbayen <tbayen!~tbayen@x2f7fe59.dyn.telefonica.de> has quit IRC | 20:39 | |
*** Layda <Layda!~Layda@2a02:908:1460:6b40:78df:4317:854:f71a> has quit IRC | 21:25 | |
*** a42niem <a42niem!~niem@p578b7daf.dip0.t-ipconnect.de> has quit IRC | 22:42 | |
*** aguerrave <aguerrave!~aguerrave@190.153.25.70> has quit IRC | 22:55 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!