| *** CarlosRuiz <CarlosRuiz!~CarlosRui@ip-95-223-107-103.hsi16.unitymediagroup.de> has quit IRC | 00:27 | |
| Not | [iDempiereDaily] jenkins build #116 started http://ci.idempiere.org/job/iDempiereDaily/116/ | 03:08 |
|---|---|---|
| *** wilson_iD <wilson_iD!b6011a2e@182.1.26.46> has joined #idempiere | 03:13 | |
| Not | [iDempiereDaily] jenkins build #116 completed: success http://ci.idempiere.org/job/iDempiereDaily/116/ | 03:36 |
| wilson_iD | hai all | 04:28 |
| *** wilson_iD <wilson_iD!b6011a2e@182.1.26.46> has quit IRC | 04:57 | |
| *** Iskandarone <Iskandarone!~Iskandaro@82.137.255.202> has joined #idempiere | 05:55 | |
| *** a42niem <a42niem!~niem@85.203.161.181> has joined #idempiere | 07:39 | |
| *** norbertbede <norbertbede!~Adium@94.228.89.101> has joined #idempiere | 07:47 | |
| *** norbertbede <norbertbede!~Adium@94.228.89.101> has quit IRC | 07:59 | |
| *** a42niem <a42niem!~niem@85.203.161.181> has quit IRC | 08:25 | |
| *** nmicoud <nmicoud!~Nicolas@37.171.7.217> has joined #idempiere | 08:56 | |
| *** norbertbede <norbertbede!~Adium@94.228.89.101> has joined #idempiere | 08:58 | |
| *** norbertbede <norbertbede!~Adium@94.228.89.101> has quit IRC | 09:09 | |
| *** nmicoud <nmicoud!~Nicolas@37.171.7.217> has quit IRC | 11:19 | |
| Not | [IDEMPIERE] Pritesh Shah created IDEMPIERE-4080 Report filtering based on parameter is not working | 15:54 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4080 | 15:54 |
| Not | [IDEMPIERE] Pritesh Shah updated IDEMPIERE-4080 assignee set to "Carlos Ruiz" | 15:54 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4080 | 15:54 |
| Not | [IDEMPIERE] Pritesh Shah updated IDEMPIERE-4080 description set to "If there is report based on temporary table and there is an optional (non-mandatory) parameter for which you have data in table and column do exists in temporary however report engine doesnt filter by the parameter value. Cause: https://idempiere.atlassian.net/browse/IDEMPIERE-3992 In this feature, below is the condition causing the issue, | 15:55 |
| Not | {code:java} if (isTemporaryTable || (table != null && table.getColumn(ParameterName) == null)) { query = reportQuery.getReportProcessQuery(); } {code} Here for any temporary table parameter will be skipped to be added to main query and hence report will not be filter by the optional parameter selected. I believe we should do either of the following, * Remove isTemporaryTable flag at all from above condition and let | 15:55 |
| Not | the parameter get ignored for any table if column doesnt exists * Instead of || make it && so it would be applied to only temporary table (like it was before IDEMPIERE-3992) and skip if column not exists in temporary table * Change condition to below, ** {code:java} if ((isTemporaryTable && table != null && table.getColumn(ParameterName) == null) || (table != null && table.getColumn(ParameterName) == null)) { query = | 15:55 |
| Not | reportQuery.getReportProcessQuery(); } {code} " | 15:55 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4080 | 15:55 |
| Not | [IDEMPIERE] Pritesh Shah updated IDEMPIERE-4080 description set to "If there is report based on temporary table and there is an optional (non-mandatory) parameter for which you have data in table and column do exists in temporary however report engine doesnt filter by the parameter value. Cause: https://idempiere.atlassian.net/browse/IDEMPIERE-3992 In this feature, below is the condition causing the issue, | 15:57 |
| Not | {code:java} if (isTemporaryTable || (table != null && table.getColumn(ParameterName) == null)) { query = reportQuery.getReportProcessQuery(); } {code} Here for any temporary table parameter will be skipped to be added to main query and hence report will not be filter by the optional parameter selected. I believe we should do either of the following, * Remove isTemporaryTable flag at all from above condition and let | 15:57 |
| Not | the parameter get ignored for any table if column doesnt exists * Instead of || make it && so it would be applied to only temporary table (like it was before IDEMPIERE-3992) and skip if column not exists in temporary table * Change condition to below, ** {code:java} if ((isTemporaryTable && table != null && table.getColumn(ParameterName) == null) || (table != null && table.getColumn(ParameterName) == null)) { query = | 15:57 |
| Not | reportQuery.getReportProcessQuery(); } {code} Last option would be same as first option" | 15:57 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4080 | 15:57 |
| Not | [IDEMPIERE] Pritesh Shah updated IDEMPIERE-4080 assignee set to "Heng Sin Low" | 17:46 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-4080 | 17:46 |
| *** a42niem <a42niem!~niem@85.203.161.181> has joined #idempiere | 17:54 | |
| *** a42niem <a42niem!~niem@85.203.161.181> has quit IRC | 18:50 | |
| *** nmicoud <nmicoud!~Nicolas@37.172.80.233> has joined #idempiere | 21:24 | |
| *** nmicoud <nmicoud!~Nicolas@37.172.80.233> has quit IRC | 21:48 | |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!