| *** a42niem <a42niem!~niem@p578b7daf.dip0.t-ipconnect.de> has joined #idempiere | 05:52 | |
| *** nmicoud <nmicoud!~Nicolas@2a01:e34:eeb6:cb10:e9dd:e377:eeb1:1d44> has joined #idempiere | 06:00 | |
| *** norbertbede <norbertbede!~Adium@94.228.89.101> has joined #idempiere | 08:42 | |
| *** norbertbede <norbertbede!~Adium@94.228.89.101> has quit IRC | 09:12 | |
| *** CarlosRuiz <CarlosRuiz!~CarlosRui@ip-95-223-106-220.hsi16.unitymediagroup.de> has joined #idempiere | 09:28 | |
| Not | [IDEMPIERE] nmicoud created IDEMPIERE-3987 EMailDialog user fields open the Info C_SalesDashboard search panel | 09:38 |
|---|---|---|
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3987 | 09:38 |
| nmicoud | Hi CarlosRuiz ; just discovered a new bug (https://idempiere.atlassian.net/browse/IDEMPIERE-3987) ; I think it is a recent one. Before I start to investigate, do you have an idea of which commit could have introduced it ? | 09:41 |
| CarlosRuiz | Hi nmicoud | 09:43 |
| CarlosRuiz | debugging ... | 09:53 |
| nmicoud | issue is in WSearchEditor | 09:53 |
| CarlosRuiz | yes - I'm there - in line 820 | 09:54 |
| nmicoud | line 819 ; in the loop, the last tablename set is C_SalesDashboard | 09:54 |
| CarlosRuiz | maybe this commit? https://bitbucket.org/idempiere/idempiere/commits/6c09776ce2b7 | 09:54 |
| nmicoud | Not sur as C_SalesDashboard or AD_User are not views | 09:55 |
| nmicoud | Not sure as C_SalesDashboard or AD_User are not views | 09:55 |
| CarlosRuiz | yes - it is that - just checked the result of the query | 09:56 |
| nmicoud | ah great - but I don't understand the logic behind - records from AD_Table are IsView='Y' so that should not change something | 09:57 |
| CarlosRuiz | seems like C_SalesDashboard.AD_User_ID is wrongly defined as Key | 09:58 |
| nmicoud | weird no one notice that before ; is there since 2019 :-/ | 10:00 |
| CarlosRuiz | not sure if is wrong - that's possible - not the best practice maybe - but in theory you can have a table or view which the key column has a name of ID of other table | 10:01 |
| nmicoud | And C_SalesDashboard is a particular table | 10:02 |
| CarlosRuiz | but - thinking here - is possible that the query in line 796 is wrong | 10:02 |
| nmicoud | Arghhhhhh ; didn't notice that C_SalesDashboard was defined as a view :D | 10:18 |
| nmicoud | Adding "order by t.isview DESC" at the end of the query should solve the issue. But I don't understand why the loop update each time the m_tableName variable | 10:21 |
| CarlosRuiz | yes - it's a bad bug | 10:22 |
| CarlosRuiz | I was checking the intention of that query | 10:23 |
| CarlosRuiz | it is to get the identifier columns of the table - but is bringing things from other tables | 10:23 |
| CarlosRuiz | so - my fix until now is adding the filter for table also - but checking that I think I found another bug | 10:23 |
| Not | [iDempiere] 1 commit to release-6.2 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ | 10:30 |
| Not | [iDempiere] hengsin 3c768c5 - IDEMPIERE-3983 Matched PO posting status "Deferred" never transitions to "Posted" if no matching MR is assigned | 10:30 |
| nmicoud | could you elaborate or you need more time ? | 10:32 |
| CarlosRuiz | :) | 10:33 |
| CarlosRuiz | that code is useless | 10:33 |
| CarlosRuiz | look | 10:34 |
| CarlosRuiz | I think is something we inherited from before the implementation of InfoWindow | 10:35 |
| CarlosRuiz | but after InfoWindow the code is almost useless | 10:35 |
| CarlosRuiz | the method getDirectAccessSQL is a private method, so cannot be used in plugins I hope | 10:35 |
| CarlosRuiz | at this moment in core is just called from two points: | 10:35 |
| CarlosRuiz | WSearchEditor.actionButton:570 | 10:36 |
| CarlosRuiz | WSearchEditor.actionText:366 | 10:36 |
| CarlosRuiz | and in both calls is just to set tablename and keycolumn - the returned SQL is not used - not even read | 10:37 |
| CarlosRuiz | so, in my head that method is doing nothing :-) just consuming CPU and database calls - because it just needs to be three lines | 10:38 |
| CarlosRuiz | String m_columnName = getColumnName(); | 10:38 |
| CarlosRuiz | m_tableName = m_columnName.substring(0, m_columnName.length()-3); | 10:38 |
| CarlosRuiz | m_keyColumnName = m_columnName; | 10:38 |
| CarlosRuiz | and the name must be setTableAndKeyColumn() | 10:38 |
| nmicoud | I think you're right | 10:39 |
| nmicoud | I've updated my local Eclipse with this change ; testing | 10:40 |
| nmicoud | The "Support Users vs Roles" IW is still working :) | 10:46 |
| CarlosRuiz | the info window for sales rep field is not | 10:47 |
| nmicoud | because of the line 695 (if m_columnName.equals("SalesRep_ID")) | 10:48 |
| nmicoud | ? | 10:48 |
| CarlosRuiz | right :) | 10:48 |
| CarlosRuiz | forgot to add that code | 10:49 |
| nmicoud | So, some special columns should be handled here | 10:49 |
| CarlosRuiz | that's weird - | 10:49 |
| CarlosRuiz | it must just get the correct table from dictionary | 10:49 |
| nmicoud | Same as org.compiere.model.MQuery.getZoomColumnName(String) | 10:49 |
| Not | [iDempiere6.2] jenkins build #155 started http://ci.idempiere.org/job/iDempiere6.2/155/ | 10:50 |
| *** norbertbede <norbertbede!~Adium@94.228.89.101> has joined #idempiere | 10:52 | |
| CarlosRuiz | that doesn't look good either - hardcoded | 10:52 |
| nmicoud | Won't it be better to have a table to store those synonyms ? | 10:55 |
| CarlosRuiz | no - it must call if possible MColumn.getReferenceTableName | 10:55 |
| nmicoud | So the WSeachEditor.getDirectAccessSQL should also just call MColumn.getReferenceTableName ? | 10:57 |
| CarlosRuiz | yes - that's what I'm trying | 10:57 |
| Not | [iDempiere6.2] jenkins build #155 completed: success http://ci.idempiere.org/job/iDempiere6.2/155/ | 11:00 |
| nmicoud | I got to go outside for 20mn, see you | 11:02 |
| CarlosRuiz | bye | 11:02 |
| nmicoud | i'm back | 11:23 |
| CarlosRuiz | ok - I have a patch | 11:23 |
| CarlosRuiz | made tests on windows and the mail dialog form and both are working | 11:23 |
| CarlosRuiz | do you want to try it? | 11:24 |
| nmicoud | I can put it on a dev (pre prod) environnment if you want | 11:24 |
| nmicoud | sure | 11:24 |
| nmicoud | I'm blocked ATM :D | 11:24 |
| CarlosRuiz | https://www.pastefile.com/tje4us | 11:25 |
| nmicoud | ok, thanks | 11:26 |
| CarlosRuiz | let me know - if it's OK I'll commit it | 11:26 |
| nmicoud | ok | 11:26 |
| nmicoud | The patch is now included in the dev environnment ; I'll report here on tuesday | 12:12 |
| *** norbertbede <norbertbede!~Adium@94.228.89.101> has quit IRC | 12:12 | |
| *** norbertbede <norbertbede!~Adium@94.228.89.101> has joined #idempiere | 12:16 | |
| *** CarlosRuiz <CarlosRuiz!~CarlosRui@ip-95-223-106-220.hsi16.unitymediagroup.de> has quit IRC | 12:22 | |
| Not | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-3987 status set to "Resolved" -assignee set to "Carlos Ruiz" -resolution set to "Fixed" | 12:22 |
| Not | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3987 | 12:22 |
| Not | [iDempiere] 1 commit to release-6.2 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ | 12:22 |
| Not | [iDempiere] globalqss 394cf6b - IDEMPIERE-3987 EMailDialog user fields open the Info C_SalesDashboard search panel | 12:22 |
| *** CarlosRuiz <CarlosRuiz!~CarlosRui@178.255.153.77> has joined #idempiere | 12:22 | |
| nmicoud | thanks | 12:24 |
| *** muriloht <muriloht!b1346902@gateway/web/freenode/ip.177.52.105.2> has joined #idempiere | 12:42 | |
| Not | [iDempiere6.2] jenkins build #156 started http://ci.idempiere.org/job/iDempiere6.2/156/ | 12:50 |
| Not | [iDempiere6.2] jenkins build #156 completed: failure http://ci.idempiere.org/job/iDempiere6.2/156/ | 12:58 |
| Not | [iDempiere6.2] jenkins build #157 started http://ci.idempiere.org/job/iDempiere6.2/157/ | 14:21 |
| *** norbertbede <norbertbede!~Adium@94.228.89.101> has quit IRC | 14:21 | |
| Not | [iDempiere6.2] jenkins build #157 completed: success http://ci.idempiere.org/job/iDempiere6.2/157/ | 14:30 |
| *** norbertbede <norbertbede!~Adium@94.228.89.101> has joined #idempiere | 14:38 | |
| *** norbertbede <norbertbede!~Adium@94.228.89.101> has quit IRC | 14:51 | |
| nmicoud | Hi again CarlosRuiz, if you have time, could you have a look at https://groups.google.com/forum/#!topic/idempiere/z2chPf47bMs please ? | 16:37 |
| CarlosRuiz | Hi nmico | 16:56 |
| CarlosRuiz | Hi nmicoud | 16:56 |
| CarlosRuiz | is your issue reproducible in your eclipse? | 16:56 |
| nmicoud | Sorry, was on phone ; yes, but randomly | 17:00 |
| nmicoud | but the fact that an order takes long time to complete is on 2 different environnements (one with Oracle, other with PG) | 17:01 |
| nmicoud | I also notice that the login/password field were greyed the 1st time user open the login page. Closing the brower was enought, but perhaps there is a link ? | 17:02 |
| CarlosRuiz | for me it sounds like one of your tables is maybe too big and there is a query without index | 17:02 |
| CarlosRuiz | -Dorg.idempiere.db.postgresql.debug=true can help easily to view which query is taking long | 17:03 |
| CarlosRuiz | but there are other ways more complex logging to postgresql | 17:03 |
| nmicoud | on PG, is a dev environnment, not a lot of data | 17:03 |
| CarlosRuiz | about the login/pass greyed - maybe your users need to remove cache from previous environment | 17:03 |
| nmicoud | and it was not so long with "old" code | 17:03 |
| nmicoud | and volume of data didn't grow , code of event/model classes remain the same | 17:04 |
| nmicoud | I wanted to try to return to the previous version to see if it change something. But before, I wanted to see if other people were impacted | 17:04 |
| CarlosRuiz | not me - I have migrated several environments to 6.2 and all of them working fine | 17:08 |
| nmicoud | ok, I will try to debug then ; thanks | 17:10 |
| *** nmicoud <nmicoud!~Nicolas@2a01:e34:eeb6:cb10:e9dd:e377:eeb1:1d44> has quit IRC | 18:46 | |
| Not | [iDempiere6.2] jenkins build #158 started http://ci.idempiere.org/job/iDempiere6.2/158/ | 20:20 |
| Not | [iDempiere6.2] jenkins build #158 completed: success http://ci.idempiere.org/job/iDempiere6.2/158/ | 20:30 |
| *** CarlosRuiz <CarlosRuiz!~CarlosRui@178.255.153.77> has quit IRC | 20:43 | |
| *** muriloht <muriloht!b1346902@gateway/web/freenode/ip.177.52.105.2> has quit IRC | 21:07 | |
| *** a42niem <a42niem!~niem@p578b7daf.dip0.t-ipconnect.de> has quit IRC | 22:29 | |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!