| *** giv has joined #idempiere | 00:25 | |
| *** silphium has joined #idempiere | 02:48 | |
| Not-4af | [iDempiere4.1Daily] jenkins built #33 completed (failure) http://ci.idempiere.org/job/iDempiere4.1Daily/33/ | 05:22 |
|---|---|---|
| *** nmicoud has joined #idempiere | 07:24 | |
| *** CarlosRuiz has joined #idempiere | 07:43 | |
| *** a42niem has joined #idempiere | 07:45 | |
| *** CarlosRuiz_ has joined #idempiere | 08:38 | |
| *** a42niem has quit IRC | 08:39 | |
| *** CarlosRuiz has quit IRC | 08:39 | |
| Not-4af | [iDempiere4.1] jenkins built #51 completed (success) http://ci.idempiere.org/job/iDempiere4.1/51/ | 11:48 |
| *** aguerra has joined #idempiere | 11:59 | |
| *** red1 has joined #idempiere | 12:15 | |
| *** ChanServ sets mode: +o red1 | 12:15 | |
| *** SmartJSP has joined #idempiere | 12:52 | |
| *** red1 has quit IRC | 13:04 | |
| *** jdpaniagua has quit IRC | 13:18 | |
| *** SmartJSP has quit IRC | 13:29 | |
| *** mbozem18 has joined #idempiere | 13:29 | |
| aguerra | Good morning !!!! | 13:42 |
| mbozem18 | Hello | 13:54 |
| *** CarlosRuiz_ has quit IRC | 13:54 | |
| *** CarlosRuiz has joined #idempiere | 13:54 | |
| mbozem18 | I have made a patch for including iban columns and fields into idempiere (IDEMPIERE-3039). And i would like to ask about your opinion. | 14:03 |
| CarlosRuiz | Hi mbozem18 | 14:06 |
| mbozem18 | Hi CarlosRuiz | 14:07 |
| CarlosRuiz | I think swift code is related to bank - so - doesn't sound necessary in all those tables if we already have it in bank | 14:07 |
| mbozem18 | But i think its for documentation. For example im c_payment, you can always see what swift code was used. | 14:08 |
| CarlosRuiz | it sounds redundant | 14:10 |
| CarlosRuiz | adding C_BP_BankAccount.IBAN sounds right | 14:15 |
| mbozem18 | i did the implementation like the existing one. I put the swift code to payment, so that the export process is very similar to the existing one (which uses RoutingNo). | 14:16 |
| mbozem18 | In Germany you even don´t need the SWIFT-Code anymore, when you transfer money to european countries. | 14:17 |
| CarlosRuiz | and to make it European maybe we would need to add C_Bank.BIC | 14:17 |
| CarlosRuiz | yep, you need BIC & IBAN for SEPA transfers | 14:18 |
| mbozem18 | I think BIC and SWIFT are the same | 14:18 |
| mbozem18 | Your don´t need a BIC anymore | 14:18 |
| mbozem18 | only outside europe i think | 14:19 |
| mbozem18 | SWIFT is the company and BIC is the code | 14:19 |
| CarlosRuiz | seems like BIC = SWIFT | 14:20 |
| CarlosRuiz | I would suggest to: C_BP_BankAccount.IBAN C_Payment.IBAN I_Payment.IBAN (if somebody still uses old importers) C_PaymentTransaction.IBAN -> C_POSPayment is not required as that's for sales make them optional and in payment window use it with Direct Deposit tender type (same as Account No) And add nmicoud validation on IDEMPIERE-1200 to those IBAN fields | 14:24 |
| CarlosRuiz | multi-line paste here :-) | 14:24 |
| CarlosRuiz | let me copy each line separate | 14:24 |
| CarlosRuiz | I would suggest to: | 14:24 |
| CarlosRuiz | C_BP_BankAccount.IBAN | 14:24 |
| CarlosRuiz | C_Payment.IBAN | 14:24 |
| CarlosRuiz | I_Payment.IBAN (if somebody still uses old importers) | 14:24 |
| CarlosRuiz | C_PaymentTransaction.IBAN | 14:24 |
| CarlosRuiz | -> C_POSPayment is not required as that's for sales | 14:24 |
| CarlosRuiz | make them optional and in payment window use it with Direct Deposit tender type (same as Account No) | 14:24 |
| CarlosRuiz | And add nmicoud validation on IDEMPIERE-1200 to those IBAN fields | 14:24 |
| mbozem18 | Ok. I can change this in the patch. | 14:25 |
| mbozem18 | For me it is ok. When somebody else needs SWIFTCode it can be added later. | 14:26 |
| CarlosRuiz | ah I see | 14:27 |
| CarlosRuiz | can be IBAN+SwiftCode - that's ok | 14:27 |
| CarlosRuiz | seems is just not necessary in c_pospayment | 14:27 |
| CarlosRuiz | so - sounds ok - reviewing your patch .... | 14:29 |
| CarlosRuiz | for your patch I would suggest: | 14:29 |
| CarlosRuiz | - exclude C_POSPayment from the patch | 14:29 |
| mbozem18 | ok | 14:29 |
| CarlosRuiz | MBPBankAccount.getSwiftCode sounds wrong - not necessary - must return the added column | 14:30 |
| mbozem18 | I didn´t add a field SWIFTCode to C_BP_BankAccount because, it is handled like RoutingNo. | 14:32 |
| CarlosRuiz | I see - agree | 14:34 |
| mbozem18 | There is a field RoutingNo in C_BP_BankAccount which overrides the RoutingNo in Bank | 14:34 |
| CarlosRuiz | yep | 14:35 |
| CarlosRuiz | I think also as you already added those to C_POSPayment - is fine to leave them there | 14:35 |
| CarlosRuiz | so your patch seems ok at first sight - would need to test | 14:35 |
| CarlosRuiz | does the new fields have same displaylogic as the routingno+accountno ? | 14:36 |
| mbozem18 | Yes, i copied the display logic | 14:36 |
| CarlosRuiz | good | 14:36 |
| mbozem18 | And i tested the swing client | 14:36 |
| CarlosRuiz | then - I'll test zkwebui and integrate if everything goes fine | 14:36 |
| mbozem18 | thanks.... so what about the SWIFTCode fields in C_Payment, I_Payment, C_PaymentTransaction... Should i remove them or should they stay like RoutingNo? | 14:37 |
| *** jdpaniagua has joined #idempiere | 14:38 | |
| CarlosRuiz | is ok - let's keep them | 14:39 |
| mbozem18 | ok. i think it´s better so. | 14:39 |
| CarlosRuiz | would be just advisable to add the nmicoud validation to all those new IBAN fields - and the currently existing in C_Bank | 14:40 |
| CarlosRuiz | but can be done after | 14:40 |
| mbozem18 | I can do this after... With that config key. | 14:40 |
| mbozem18 | At the moment the code is without checking the configuration key i think | 14:41 |
| mbozem18 | I´m so happy: My first patch :-) | 14:43 |
| CarlosRuiz | well - your first looks good :-) thanks for contributing - testing | 14:44 |
| CarlosRuiz | mbozem18: which is your developer code - in bitbucket - or your email? to use it as the commit developer | 14:51 |
| mbozem18 | mbozem@bozem.de | 14:51 |
| mbozem18 | I think bitbucket is markus_bozem, but mbozem@bozem.de is better | 14:52 |
| Not-4af | [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-4.1 [+2/-0/±15] https://bitbucket.org/idempiere/idempiere/commits/ | 14:56 |
| Not-4af | [iDempiere] mark...@bozem.de 8e89c5b - IDEMPIERE-3039 Add IBAN and Swift fields to Business Partner/Bank Account | 14:56 |
| CarlosRuiz | ok | 14:56 |
| CarlosRuiz | tests went fine - I integrated it into 4.1 | 14:56 |
| Not-4af | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-3039 status set to "Resolved" -assignee set to "Markus Bozem" -resolution set to "Fixed" | 14:57 |
| Not-4af | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3039 | 14:57 |
| mbozem18 | Thank you very much. The next days i will do IDEMPIERE-1200. | 14:58 |
| mbozem18 | I put the migration scripts into i4.1z... did you see it? | 14:58 |
| CarlosRuiz | yes - I moved them to 4.1 | 14:59 |
| mbozem18 | ok | 14:59 |
| mbozem18 | see you | 15:02 |
| CarlosRuiz | bye | 15:05 |
| Not-4af | [iDempiere4.1] jenkins built #52 completed (success) http://ci.idempiere.org/job/iDempiere4.1/52/ | 15:18 |
| Not-4af | [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-4.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ | 16:10 |
| Not-4af | [iDempiere] globalqss 25d8011 - IDEMPIERE-3147 Financial Report translation of the data not only headers (based on patch from Gaurav Sontake) | 16:10 |
| Not-4af | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-3147 status set to "Resolved" -assignee set to "Carlos Antonio Ruiz Gomez" -resolution set to "Fixed" | 16:10 |
| Not-4af | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3147 | 16:10 |
| *** CarlosRuiz has quit IRC | 16:11 | |
| *** mbozem18 has quit IRC | 16:20 | |
| Not-4af | [iDempiere4.1] jenkins built #53 completed (success) http://ci.idempiere.org/job/iDempiere4.1/53/ | 16:42 |
| *** nmicoud has quit IRC | 17:22 | |
| *** a42niem has joined #idempiere | 17:22 | |
| *** jdpaniagua has quit IRC | 18:26 | |
| *** jdpaniagua has joined #idempiere | 18:44 | |
| *** a42niem has quit IRC | 19:47 | |
| *** mbozem has joined #idempiere | 21:11 | |
| *** jdpaniagua has quit IRC | 23:24 | |
| *** jdpaniagua has joined #idempiere | 23:24 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!