| *** a42niem has joined #idempiere | 01:41 | |
| *** a42niem has quit IRC | 03:34 | |
| *** nmicoud has joined #idempiere | 07:06 | |
| *** a42niem has joined #idempiere | 08:42 | |
| *** CarlosRuiz has joined #idempiere | 09:11 | |
| *** Not-b4e has joined #idempiere | 09:28 | |
| Not-b4e | [IDEMPIERE] freepath updated IDEMPIERE-3243 | 09:28 |
|---|---|---|
| Not-b4e | [IDEMPIERE] Hi Carlos, i have attached the patch file (first time i do it, i hope there are no mistakes) for the 'wrapper' approach. About caching the factory, sounds like a good approach: engines are not guaranteed to be thread safe, but the factory should be. Regards, Silvano | 09:28 |
| Not-b4e | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3243 | 09:28 |
| *** mauro_ has joined #idempiere | 09:56 | |
| Not-b4e | [IDEMPIERE] freepath updated IDEMPIERE-3243 | 10:12 |
| Not-b4e | [IDEMPIERE] Sorry, forgot to mention a detail: the patch is equivalent to my original pull request without factory caching. I'll prefer to confirm the approach and implementation is fine before applying changes. Let me know if you prefer to check it with factory caching. If so, i'll do the caching in Core class, not MRule, since following the approach for other osgi services they are all discovered with support | 10:12 |
| Not-b4e | funtions in Core class. Thinking about it, i believe only engines discovered via classloader (not osgi) are cacheable, since osgi plugins can be unloaded and reloaded without stopping the server, so breaking the functionality of the cache, WDYT ? Regards, Silvano | 10:12 |
| Not-b4e | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3243 | 10:12 |
| *** CarlosRuiz has quit IRC | 10:14 | |
| *** a42niem has quit IRC | 10:20 | |
| *** CarlosRuiz has joined #idempiere | 10:26 | |
| *** red1 has joined #idempiere | 12:25 | |
| *** ChanServ sets mode: +o red1 | 12:25 | |
| *** aguerra has joined #idempiere | 13:00 | |
| aguerra | good morning!!! | 13:00 |
| nmicoud | hi aguerra | 13:03 |
| aguerra | hi nmicoud | 13:03 |
| *** mauro_ has quit IRC | 13:31 | |
| *** AlbinGMB has joined #idempiere | 13:51 | |
| AlbinGMB | Hello Guys ! | 13:52 |
| aguerra | how supposed to work on the Business Partner the field ... "Flat Discount %" ?? | 14:15 |
| aguerra | if i put 10%, it make a discount 10% of a total invoice?? | 14:32 |
| *** AlbinGMB has quit IRC | 15:55 | |
| *** red1 has quit IRC | 16:00 | |
| *** aguerra has quit IRC | 16:06 | |
| *** nmicoud has quit IRC | 16:21 | |
| *** CarlosRuiz has quit IRC | 17:07 | |
| *** a42niem has joined #idempiere | 17:24 | |
| *** CarlosRuiz has joined #idempiere | 19:29 | |
| Not-b4e | [iDempiere] CarlosRuiz_globalqss pushed 2 commits to release-4.1 [+4/-0/±4] https://bitbucket.org/idempiere/idempiere/commits/ | 20:09 |
| Not-b4e | [iDempiere] FreePath 6cac8d2 - IDEMPIERE-3243 fixed by using classes from apache felix project. No other classes needed modifications since script-enabled classes relies on MRule | 20:09 |
| Not-b4e | [iDempiere] globalqss a55cf97 - IDEMPIERE-3243 - peer review | 20:09 |
| Not-b4e | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-3243 status set to "Resolved" -assignee set to "Freepath" -resolution set to "Fixed" | 20:10 |
| Not-b4e | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3243 | 20:10 |
| Not-b4e | [iDempiere4.1] jenkins built #14 completed (success) http://ci.idempiere.org/job/iDempiere4.1/14/ | 20:19 |
| Not-b4e | [IDEMPIERE] red1 updated IDEMPIERE-3161 Attachment set to "SentByTranslate.png" | 20:51 |
| Not-b4e | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3161 | 20:51 |
| Not-b4e | [IDEMPIERE] red1 updated IDEMPIERE-3161 | 20:52 |
| Not-b4e | [IDEMPIERE] [~norbert.bede], isn't your patch and original statement not for Tenant, but at System level: MSysConfig.getValue("EMAIL_SENT_BY_TRADEMARK_TEXT" ? I checked with what [~carlosruiz_globalqss] said and yes i think if at System level, you can change the message as its not hardcoded. Also there was an idea from [~tbayen] before, that you can also make more localised translation, depending on company as | 20:52 |
| Not-b4e | Language can be 'Language-Co'. I attach the screen shot seems possible. !SentByTranslate.png|thumbnail! So if its OK, perhaps later i will recommend rephrase this ticket. It is not any bug, even major, but a good feature | 20:52 |
| Not-b4e | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3161 | 20:52 |
| Not-b4e | [IDEMPIERE] red1 updated IDEMPIERE-3150 status set to "Peer Review Queue" | 21:04 |
| Not-b4e | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3150 | 21:04 |
| Not-b4e | [IDEMPIERE] red1 updated IDEMPIERE-3150 | 21:06 |
| Not-b4e | [IDEMPIERE] Perhaps [~a42niem] need to confirm the commit is working and close this as 'Fixed' ? | 21:06 |
| Not-b4e | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3150 | 21:06 |
| Not-b4e | [IDEMPIERE] red1 updated IDEMPIERE-3149 Attachment set to "CreateReversal.png" | 21:26 |
| Not-b4e | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3149 | 21:26 |
| Not-b4e | [IDEMPIERE] red1 updated IDEMPIERE-3149 | 21:26 |
| Not-b4e | [IDEMPIERE] [~imarch] confirmed it is a feature on correct usage of GL Distribution where Reversal is done. So this is not a bug but a user guide. Screenshot attached to show usage. !CreateReversal.png|thumbnail! Ticket should be closed as Won't Fix. | 21:26 |
| Not-b4e | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3149 | 21:26 |
| Not-b4e | [IDEMPIERE] red1 updated IDEMPIERE-3149 status set to "Closed" -resolution set to "Won't Fix" | 21:27 |
| Not-b4e | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3149 | 21:27 |
| Not-b4e | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-3150 status set to "Resolved" -resolution set to "Fixed" | 21:29 |
| Not-b4e | [IDEMPIERE] Thanks @red1 - I think I forgot to close it | 21:29 |
| Not-b4e | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3150 | 21:29 |
| *** a42niem has quit IRC | 21:48 | |
| *** CarlosRuiz has left #idempiere | 21:50 | |
| Not-b4e | [IDEMPIERE] red1 updated IDEMPIERE-3151 | 22:32 |
| Not-b4e | [IDEMPIERE] [~norbert.bede] Isn't the Invalid setting for failed SQL execution? I tested getting "dba_free_space" does not exist, which has to be corrected by the developer and then set the Rule back to Valid. The result of the SQL execution will be sent as message to notify AlertRecipient(s). Or maybe i misunderstood? | 22:32 |
| Not-b4e | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3151 | 22:32 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!