| *** a42niem has quit IRC | 00:01 | |
| *** jdpaniagua has quit IRC | 04:24 | |
| *** silphium has joined #idempiere | 04:29 | |
| *** a42niem has joined #idempiere | 06:45 | |
| *** jdpaniagua has joined #idempiere | 07:10 | |
| *** nmicoud has joined #idempiere | 07:13 | |
| *** CarlosRuiz has joined #idempiere | 09:40 | |
| Not-7b4d | [IDEMPIERE] freepath created IDEMPIERE-3243 groovy script engine not recognized | 11:04 |
|---|---|---|
| Not-7b4d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3243 | 11:04 |
| Not-7b4d | [IDEMPIERE] a42niem updated IDEMPIERE-3243 | 11:36 |
| Not-7b4d | [IDEMPIERE] Hi [~freepath], I was recently thinking about having script engines pluggable in iDempiere mainly to allow to easily provide newer Jython versions when available. I found https://code.google.com/archive/p/jo-bridge/ as a possible solution but did not find time to test it up to now. WDYT? Regards, Dirk Niemeyer | 11:36 |
| Not-7b4d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3243 | 11:36 |
| Not-7b4d | [IDEMPIERE] freepath updated IDEMPIERE-3243 | 12:26 |
| Not-7b4d | [IDEMPIERE] Hi Dirk, i have completed a first revision of the fix by importing and integrating some classes from apache felix, after having found this article: https://devnotesblog.wordpress.com/2011/09/07/scripting-using-jsr-223-in-an-osgi-environment/ Its a bit more generic then the one you mentioned since its uses the standard way of declaring ScriptEngines without additional classes (I have found usage of the | 12:26 |
| Not-7b4d | same classes in hazelcast project, too ) They work by scanning osgi plugins for declared factories (javax.script.ScriptEngineFactory in META-INF/services). My current implementation first scans the classpath, then osgi bundles. To me it sounds like a bad idea to have both a version on org.adempiere.base classpath, and a version as a bundle, so the order should be irrelevant. This solution should work toward your | 12:26 |
| Not-7b4d | goal, if the script engine implementations are removed from classpath and moved to be plugins. I have created a pull request, so you can see by yourself the details. Regards, Silvano Trinchero | 12:26 |
| Not-7b4d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3243 | 12:26 |
| *** CarlosRuiz has quit IRC | 12:44 | |
| *** CarlosRuiz has joined #idempiere | 15:46 | |
| Not-7b4d | [IDEMPIERE] carlosruiz_globalqss created IDEMPIERE-3244 Jasper reports cannot run core classes | 16:35 |
| Not-7b4d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3244 | 16:35 |
| Not-7b4d | [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-4.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ | 16:40 |
| Not-7b4d | [iDempiere] globalqss 835ae3a - IDEMPIERE-3244 Jasper reports cannot run core classes / implement fix suggested by hieplq | 16:40 |
| Not-7b4d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-3244 status set to "Resolved" -assignee set to "hieplq" -resolution set to "Fixed" | 16:40 |
| Not-7b4d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3244 | 16:40 |
| Not-7b4d | [iDempiere4.1] jenkins built #13 completed (success) http://ci.idempiere.org/job/iDempiere4.1/13/ | 16:46 |
| *** nmicoud has quit IRC | 17:46 | |
| *** a42niem has quit IRC | 18:07 | |
| Not-7b4d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-3243 Attachment set to "IDEMPIERE-3243_v1.patch" | 19:32 |
| Not-7b4d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3243 | 19:32 |
| Not-7b4d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-3243 | 19:37 |
| Not-7b4d | [IDEMPIERE] Hi, following a suggestion from [~hieplq], I found a simpler way to get groovy working, see attached patch IDEMPIERE-3243_v1.patch I think in this way to add new script engines is just to define it in OSGI-INF properly. I also did some refactoring to avoid recreating the factory every time MRule.getScriptEngine is called, but is discovered when MRule is instantiated, is this preferable? [~a42niem], | 19:37 |
| Not-7b4d | [~hieplq], [~freepath], can you please review, test and provide feedback? Regards, Carlos Ruiz | 19:37 |
| Not-7b4d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3243 | 19:37 |
| Not-7b4d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-3243 | 19:49 |
| Not-7b4d | [IDEMPIERE] @freepath, reading the pull request I think maybe your approach is more solid, reading this comment on OSGiScriptEngineFactory.java : This is a wrapper class for the ScriptEngineFactory class that deals with context class loader issues It is necessary because engines (at least ruby) use the context classloader to find their resources (i.e., their "native" classes) But, I cannot test it unless I integrate | 19:49 |
| Not-7b4d | it, I don't have access to the source repository of the pull request, and I'm not able to make it a raw patch to import. Can you please provide the pull request in form of a patch? Regards, Carlos Ruiz | 19:49 |
| Not-7b4d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3243 | 19:49 |
| Not-7b4d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-3243 | 19:50 |
| Not-7b4d | [IDEMPIERE] [~freepath], reading the pull request I think maybe your approach is more solid, reading this comment on OSGiScriptEngineFactory.java : This is a wrapper class for the ScriptEngineFactory class that deals with context class loader issues It is necessary because engines (at least ruby) use the context classloader to find their resources (i.e., their "native" classes) But, I cannot test it unless I | 19:50 |
| Not-7b4d | integrate it, I don't have access to the source repository of the pull request, and I'm not able to make it a raw patch to import. Can you please provide the pull request in form of a patch? Regards, Carlos Ruiz | 19:50 |
| Not-7b4d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-3243 | 19:50 |
| *** CarlosRuiz has quit IRC | 20:27 | |
| *** super has joined #idempiere | 21:41 | |
| *** super has quit IRC | 21:46 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!