#idempiere IRC log for Friday, 2015-10-16

« Thursday, 2015-10-15 Index Saturday, 2015-10-17 »
*** Michael_AT has joined #idempiere00:13
*** CarlosRuiz has joined #idempiere00:14
*** hitchcock.freenode.net sets mode: +o CarlosRuiz00:14
*** ChuckBoecking has joined #idempiere00:16
*** ChanServ has joined #idempiere00:32
*** hitchcock.freenode.net sets mode: +o ChanServ00:32
*** CarlosRuiz has quit IRC01:03
*** mbozem has joined #idempiere01:33
*** mbozem has quit IRC01:37
*** ChuckBoecking has quit IRC02:51
*** VuongCT has joined #idempiere04:33
*** norbertbede1 has joined #idempiere04:37
*** norbertbede1 has quit IRC04:43
*** norbertbede has joined #idempiere04:46
*** norbertbede1 has joined #idempiere04:50
*** norbertbede has quit IRC04:50
*** norbertbede1 has quit IRC04:50
*** norbertbede has joined #idempiere04:53
*** norbertbede has joined #idempiere04:55
*** norbertbede has joined #idempiere04:56
*** norbertbede3 has joined #idempiere05:00
*** norbertbede has quit IRC05:01
*** norbertbede3 has quit IRC05:24
*** mbozem has joined #idempiere05:27
*** nmicoud has joined #idempiere05:34
*** norbertbede1 has joined #idempiere06:02
*** norbertbede2 has joined #idempiere06:08
*** jannis_a42 has joined #idempiere06:08
*** norbertbede1 has quit IRC06:11
*** a42niem has joined #idempiere06:19
Michael_ATGood Morning, I am thinking about a production setup and I am unsure if I should wait for V3 Release. I still have not found a way to migrate all Updates to the Database, because I do not see which Updates are already in it. Will be 3.0 released with a 3.0 Database?06:35
*** mbozem has quit IRC07:07
*** norbertbede2 has quit IRC07:08
*** norbertbede1 has joined #idempiere07:12
*** mbozem has joined #idempiere07:33
a42niemhi Michael_AT: did you have a look at window "migartion scripts" in system client?07:37
*** norbertbede1 has quit IRC07:37
a42niemOTOH the installer from ci does have an up to date seed database with it07:39
*** norbertbede1 has joined #idempiere07:45
*** norbertbede1 has quit IRC07:56
*** norbertbede1 has joined #idempiere08:11
*** norbertbede1 has quit IRC08:15
*** jannis_a421 has joined #idempiere08:29
*** jannis_a42 has quit IRC08:31
Not-5e44[IDEMPIERE] pritesh.shah17 updated IDEMPIERE-2887 Attachment set to "IDEMPIERE-2887.patch"08:35
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-288708:35
Not-5e44[IDEMPIERE] pritesh.shah17 updated IDEMPIERE-2887 Attachment set to "None"08:35
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-288708:35
Not-5e44[IDEMPIERE] pritesh.shah17 updated IDEMPIERE-288708:36
Not-5e44[IDEMPIERE] I have uploaded new patch with some info as requested, can you please verify those so from next time I will take care of those? Also, new CSV Importer will import child tab records similar to Window Import import functionality with single file?08:36
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-288708:36
Not-5e44[IDEMPIERE] a42niem updated IDEMPIERE-215808:52
Not-5e44[IDEMPIERE] Hi [~kinerix], did you define the corresponding tree as described on http://wiki.idempiere.org/en/NF3.0_Tree_On_Any_Table ? Regards Dirk Niemeyer08:52
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-215808:52
*** CarlosRuiz has joined #idempiere12:58
*** ChanServ sets mode: +o CarlosRuiz12:58
Not-5e44[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2158 status set to "Resolved" -resolution set to "Incomplete"13:22
Not-5e44[IDEMPIERE] [~kinerix], this is a support question that must be asked in forums https://groups.google.com/forum/?fromgroups#!forum/idempiere13:22
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-215813:22
Not-5e44[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-288713:23
Not-5e44[IDEMPIERE] > Also, new CSV Importer will import child tab records similar to Window Import import functionality with single file? Yes, please check http://wiki.idempiere.org/en/NF1.0_ImportCSV13:23
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-288713:23
Not-5e44[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-282613:28
Not-5e44[IDEMPIERE] [~hengsin] agreed: {quote}Yes, I think that's a good move. Using AD_ModelValidator does have its advantage - it can be make tenant configurable.{quote}13:28
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-282613:28
*** ChuckBoecking has joined #idempiere13:29
Not-5e44[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-284813:32
Not-5e44[IDEMPIERE] [~hengsin] agreed with this: {quote} Where feasible, decoupling more business logic from model ( MOrder, MInvoice, etc ) is the way to go. It is also worth mentioning that JJ approach of having all business logic in the model class ( M* ) does violate common MVC practice. {quote} [~cboecking], you were very interested on this topic, would you like to try it? The task that we talked at castel was something13:32
Not-5e44like this: Take all the business logic from MOrder (before/after save/delete, prepareIt, completeIt, *It ...) and move it to a plugin, something like org.idempiere.business.order - this plugin would have all the business logic from CalloutOrder and MOrder. So, if somebody wants to replace the business logic for orders it can simply uninstall the official plugin and install their customized plugin, or extend it as a13:32
Not-5e44fragment. This idea seems a lot better to explore and it can be inline with the long term goal of decoupling and modularizing iDempiere. Same can be applied later for other business logic invoices, bank statements, payments, etc.13:32
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-284813:32
*** posde2 has joined #idempiere13:35
*** posde has quit IRC13:35
*** posde2 is now known as possy13:36
Not-5e44[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-282813:37
Not-5e44[IDEMPIERE] [~hengsin] definitely agreed with the ideas we discussed at castle {quote} That have been my standing from many years back - Average Invoice Costing is a mistake and should be drop. In SAP there is no "Average Invoice" and "Average PO", just one "Average Costing" - I'm aware of that and have mention that several time. {quote} So, restoring our main conclusion at the castle: 1 - define Average PO method as13:37
Not-5e44the default method for new clients (at this moment is Average Invoice) 2 - if possible drop "Average Invoice" from the list (and deprecate it in code) - and rename "Average PO" to "Average Costing" We must add a migration note to people already using Average Invoice (any?) to encourage them to make a transition to "Average Costing" (formerly Average PO), but in the meantime the code must be kept there marked as13:37
Not-5e44deprecated. BTW, yesterday [~ocurieles] was doing extensive tests to Average PO and found that everything was working pretty good. Regards, Carlos Ruiz13:37
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-282813:37
Not-5e44[IDEMPIERE] cboecking updated IDEMPIERE-284814:08
Not-5e44[IDEMPIERE] Hi [~carlosruiz_globalqss], I would love to. Here are my first thoughts: * Add more events to IEventTopic to include something like "DOC_COMPLETE" in addition to the current "DOC_BEFORE_COMPLETE" and "DOC_AFTER_COMPLETE". * Use the "DOC_COMPLETE" as the hook to execute the business logic. * If we did use the [ModelEvent|http://wiki.idempiere.org/en/Developing_Plug-Ins_-_Model_Events] as the framework to14:08
Not-5e44implement this change, then the plugin's OrderEventHandler.java would act as the controller to execute the correct class (ex. OrderCompleteIt.java or OrderPrepareIt.java). * I assume this change would also include refactoring the code to move all business logic out of the actual prepareIt() and completeIt() methods and into helper methods so that fragments could more easily override logic of a given method. * We also14:08
Not-5e44spoke at the castle about eventually breaking iDempiere into multiple repositories. Does this ticket touch this topic? Creating a feature as its own repository seems logical to me. Is the vision to have a feature/plugin per table (C_Order, M_InOut, C_Invoice)? or one monolithic plugin for all model logic? If you do not think that [ModelEvent|http://wiki.idempiere.org/en/Developing_Plug-Ins_-_Model_Events], what are14:08
Not-5e44your thoughts?14:08
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-284814:08
*** Sri has joined #idempiere14:29
Not-5e44[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-284814:31
Not-5e44[IDEMPIERE] Thanks [~cboecking], > Add more events to IEventTopic to include something like "DOC_COMPLETE" I think the current BEFORE/AFTER events are enough if we can define the order of running the validators (eventhandlers) - does the service.ranking applies here? > We also spoke at the castle about eventually breaking iDempiere into multiple repositories. Does this ticket touch this topic? Probably we'll need to14:31
Not-5e44create a new repository for plugins - there are some tickets also talking about decoupling webstore and promotions (also jasper is a good candidate to decouple), but this plugin sounds too core - still haven't thought if it needs to be moved out, at the moment we just need to make it replaceable/extensible. > Is the vision to have a feature/plugin per table (C_Order, M_InOut, C_Invoice)? or one monolithic plugin for14:31
Not-5e44all model logic? IMHO it must not be per table, but maybe per functionality, but that's probably harder to achieve, let's try this as first step and proof of concept.14:31
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-284814:31
*** xapiens has joined #idempiere14:38
Not-5e44[IDEMPIERE] carlosruiz_globalqss created IDEMPIERE-2891 Refactor M_PriceList_Create14:50
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-289114:50
Not-5e44[IDEMPIERE] cboecking updated IDEMPIERE-284814:57
Not-5e44[IDEMPIERE] [~carlosruiz_globalqss], Therefore, i assume he [ModelEvent|http://wiki.idempiere.org/en/Developing_Plug-Ins_-_Model_Events] is the preferred implementation method for now. Here is how I plan to move forward: * create a fork of iDempiere * create a branch for this ticket * clean out MOrder prepareIt(), etc... methods * create a new plugin in the core with the package org.idempiere.business.order * update14:57
Not-5e44org.idempiere.business.order to implement [ModelEvent|http://wiki.idempiere.org/en/Developing_Plug-Ins_-_Model_Events] * re-create order business logic in the new plugin using either the BEFORE or AFTER timing events (with special attention to service.ranking) * test and share Please correct/fix as you deem appropriate. I anticipate having the first version for test around Nov 20th. Please let me know if this date14:57
Not-5e44causes any issues.14:57
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-284814:57
Not-5e44[iDempiere] CarlosRuiz_globalqss pushed 2 commits to development [+2/-0/±6] https://bitbucket.org/idempiere/idempiere/commits/15:22
Not-5e44[iDempiere] cboecking be9bee8 - IDEMPIERE-2811 Each Record should have a primary key / Implement for M_ProductPrice15:22
Not-5e44[iDempiere] globalqss 4ec9f8c - IDEMPIERE-2811 Each Record should have a primary key / Implement for M_ProductPrice / Peer review15:22
Not-5e44[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2811 status set to "Resolved" -resolution set to "Fixed"15:22
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-281115:22
Not-5e44[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2811 summary set to "Each Record should have a primary key - M_ProductPrice"15:22
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-281115:22
Not-5e44[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-281115:23
Not-5e44[IDEMPIERE] Thanks [~cboecking], I committed the fixes for this ticket and my peer review. Closing this ticket for M_ProductPrice - if there are more tables that you want to work please open specific ticket for each.15:23
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-281115:23
Not-5e44[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-284815:25
Not-5e44[IDEMPIERE] That's ok [~cboecking]. For the fork I recommend: - keep the fork just focused on this development - do not mix other tickets - keep the fork updated with main repo (pulling and merging frequently)15:25
Not-5e44[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-284815:25
Not-5e44[iDempiere] jenkins built #1751 completed (success) http://ci.idempiere.org/job/iDempiere/1751/15:31
Not-5e44[iDempiere] CarlosRuiz_globalqss pushed 1 commit to development [+8/-6/±0] https://bitbucket.org/idempiere/idempiere/commits/16:16
Not-5e44[iDempiere] globalqss 2b2980a - Fix wrong name scripts found on IDEMPIERE-1846 IDEMPIERE-2230 IDEMPIERE-182016:16
Not-5e44[iDempiere] CarlosRuiz_globalqss pushed 1 commit to development [+0/-0/±9] https://bitbucket.org/idempiere/idempiere/commits/16:18
Not-5e44[iDempiere] globalqss f216e0d - hg merge release-2.1 (merge release2.1 into development)16:18
*** nmicoud has quit IRC16:24
Not-5e44[iDempiere] jenkins built #1752 completed (success) http://ci.idempiere.org/job/iDempiere/1752/16:25
*** mbozem has quit IRC16:39
*** ChuckBoecking has quit IRC17:38
*** CarlosRuiz has quit IRC18:24
*** CarlosRuiz has joined #idempiere19:52
*** ChanServ sets mode: +o CarlosRuiz19:52
*** mbozem has joined #idempiere20:05
*** mbozem has quit IRC21:01
*** jannis_a421 has left #idempiere21:20
« Thursday, 2015-10-15 Index Saturday, 2015-10-17 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!