#idempiere IRC log for Wednesday, 2015-06-17

*** red1 has quit IRC00:16
*** is-mw2 has joined #idempiere01:44
*** is-mw has quit IRC01:45
*** norbertbede has joined #idempiere03:13
*** norbertbede has quit IRC03:17
*** hieplq has joined #idempiere03:39
*** hieplq has quit IRC03:47
*** hieplq_ has joined #idempiere03:47
*** norbertbede has joined #idempiere04:14
*** hieplq__ has joined #idempiere05:14
*** hieplq_ has quit IRC05:15
*** hieplq__ has quit IRC05:18
*** nmicoud has joined #idempiere05:46
*** norbertbede has quit IRC05:53
*** norbertbede has joined #idempiere05:54
*** norbertbede has quit IRC05:56
*** norbertbede has joined #idempiere06:07
*** KermitTheFragger has joined #idempiere06:35
*** a42niem has joined #idempiere06:59
*** druiz has joined #idempiere08:20
*** norbertbede has quit IRC10:00
*** norbertbede has joined #idempiere10:14
*** norbertbede has quit IRC10:31
*** norbertbede has joined #idempiere10:51
*** norbertbede has joined #idempiere10:51
*** norbertbede has quit IRC10:55
*** norbertbede has joined #idempiere10:57
*** norbertbede has quit IRC11:57
*** norbertbede has joined #idempiere11:57
*** norbertbede has joined #idempiere11:58
*** lescano has joined #idempiere12:09
lescanohi all12:18
druizhi @lescano12:18
*** norbertbede has quit IRC12:35
*** norbertbede has joined #idempiere12:37
*** HideakiHagiwara has joined #idempiere12:52
*** CarlosRuiz has joined #idempiere12:59
*** ChanServ sets mode: +o CarlosRuiz12:59
CarlosRuizGood Morning13:00
nmicoudBonjour13:00
druizHola13:00
nmicoudCarlosRuiz, could you have a look at those 2 little patches (2685, 2678 )  and then at 2679 (which will take more time - and still as draft) ?13:02
CarlosRuizok13:03
nmicoudthanks13:04
Not-604a[iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+2/-0/±0] https://bitbucket.org/idempiere/idempiere/commits/13:14
Not-604a[iDempiere] nmicoud 5364b7b - IDEMPIERE-2685 Jasper process field should be visible only for Advanced roles13:14
Not-604a[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2685 status set to "Resolved" -assignee set to "Nicolas Micoud" -resolution set to "Fixed"13:14
Not-604a[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-268513:14
CarlosRuiznmicoud,13:18
CarlosRuiztesting 2678 on Test Window (r2.1)13:19
CarlosRuizI set null as default value for Integer, Number, Amount and Qty13:19
CarlosRuizwhen saving just integer was saved as null13:19
CarlosRuiznumber, amount and qty were saved as zero13:20
nmicoudlet me check13:20
nmicoudat first, i wanted to add something like if Amount and DefaultLogic.equals("NULL")13:22
nmicoudbut it was maybe more useful to apply this patch to all field13:22
nmicoudDid you syncrhonize the column ?13:23
nmicoudi mean, there is no default value in the db13:23
CarlosRuizah - let me check - I tested setting the default on window13:23
*** Deepak__ has joined #idempiere13:27
Deepak__Good Morning all13:27
tbayenDaarestiet :-)13:27
CarlosRuizhi Deepak__ - hi tbayen13:27
nmicoudis ok here with NULL in column + synchronize column13:28
nmicoud(oracle)13:28
CarlosRuizgood nmicoud - it worked the db default was wrongly set13:30
nmicoudbut it means that this kind of default cannot be set in the field, right ?13:30
nmicoudit has to be set in the column13:30
CarlosRuizyes - it can13:31
nmicoudor at least, the column in db must have null as default13:31
CarlosRuizjust that the column in the db was not corresponding to the column in ad_column13:31
CarlosRuizI just synchronized - and the default was changed from 0 to null - without touching ad_column13:31
nmicoudok13:31
Not-604a[iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/13:36
Not-604a[iDempiere] nmicoud aa2906f - IDEMPIERE-2678 Allow to set explicit NULL value for fields13:36
Not-604a[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2678 status set to "Resolved" -assignee set to "Nicolas Micoud" -resolution set to "Fixed"13:37
Not-604a[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-267813:37
*** aguerra has joined #idempiere13:39
aguerrahi everybody13:39
aguerragood morning!!!13:40
Not-604a[iDempiere2.1] jenkins built #234 completed (success) http://ci.idempiere.org/job/iDempiere2.1/234/13:42
CarlosRuizHi aguerra14:03
*** HideakiHagiwara has quit IRC14:11
*** mhernandezve has joined #idempiere14:12
Not-604a[iDempiere2.1] jenkins built #235 completed (success) http://ci.idempiere.org/job/iDempiere2.1/235/14:14
druiz@CarlosRuiz have you had time to check IDEMPIERE-267314:19
CarlosRuiznot yet - will check it today14:20
*** mhernandezve has quit IRC14:31
*** mhernandezve has joined #idempiere14:31
mhernandezvehello idempierans! ;)14:33
CarlosRuizHi mhernandezve14:34
aguerrahi mhernandezve14:36
*** norbertbede has quit IRC14:48
*** norbertbede has joined #idempiere14:53
*** Deepak__ has quit IRC14:55
*** nmicoud has left #idempiere15:07
lescano@CarlosRuiz, ref. https://idempiere.atlassian.net/browse/IDEMPIERE-2676 seems not to have a easy resolution15:09
CarlosRuizI haven't checked, it sounds like a callout is reading info from another window15:10
*** druiz has quit IRC15:12
lescanoactually, it is related to context variables in a window. After a query for another record, some variables remains instead of clearing15:12
lescanoquery seems to be broken15:12
*** KermitTheFragger has quit IRC15:13
*** is-mw2 has quit IRC15:23
norbertbedehi all15:31
lescanohi norbert15:31
norbertbedepeople interested in replication should help me answer a tricky question well :)15:31
norbertbedehttps://groups.google.com/forum/#!topic/idempiere/3v4ipKmhoE815:31
*** Deepak has joined #idempiere15:38
CarlosRuizhi norbertbede15:39
DeepakHello Norbert, I just responded to you group message15:42
Deepakhope that helps15:42
norbertbedeah i see15:50
norbertbedethanks going to check15:50
*** nmicoud has joined #idempiere16:03
*** aguerra has quit IRC16:05
*** nmicoud_ has joined #idempiere16:43
*** nmicoud has quit IRC16:45
Not-604a[IDEMPIERE] norbert.bede updated IDEMPIERE-2660 description set to "we found the following process could be improved well: *Product Category filter (parameter 1)* ------------------------------ _{color:#707070}by product category filter users are able to filter specific lines from orders by his product cagetory - where shipment and invoice rules are fit and not yet invoiced. Important: parent/child categories must be16:51
Not-604aconsidered. well{color}_ example use case: user wants to invoice first: foods then office equipments. *Split orderlines by (parameter 2)* ------------------------------ _{color:#707070}by this parameter users are able to split invoices - to be created - by given option - then - where shipment and invoice rules are fit and not yet invoiced{color}_ ** split by salesman - invoice per order customers ** split by orders16:51
Not-604a** split by order reference ** split by shipments ** split by location(departments) - example use case: multiple invoices created for business partner - split by locations. e.g 100 shipments 10 invoice in period *Lines Order by (parameter 3)* --------------------------------------------- _{color:#707070}by this parameter users are able to define how lines - generated to invoice will be ordered - to be created - by16:51
Not-604agiven option - then - where shipment and invoice rules are fit and not yet invoiced{color}_ ** no grouping ** group by orders ** group by address ** group by shipments *Generate Notes (parameter 3)* --------------------------------------------- actual behaviour is: Shipment: TR/DL/150612089 (docno) - 18/06/2015 (date) yes/no Note 1. other ideas required - for better design Note 2. other ideas in code review required16:51
Not-604a- for better design Note 3. parameter 2 and 3 are - could be in conflict - ideas are welcome. "16:51
Not-604a[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-266016:51
Not-604a[iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±6] https://bitbucket.org/idempiere/idempiere/commits/17:32
Not-604a[iDempiere] globalqss 2fcb262 - IDEMPIERE-2664 DB Extensibility issues / calling convert for direct prepareStatement17:32
Not-604a[iDempiere2.1] jenkins built #236 completed (success) http://ci.idempiere.org/job/iDempiere2.1/236/17:42
*** Deepak has quit IRC17:57
norbertbedeCarlosRuiz where is or hieplq.18:02
norbertbedehe being silent latest weeks :)18:02
CarlosRuizyes, some time without hearing from him18:03
CarlosRuizlescano, still there?18:16
lescanoyes18:16
CarlosRuizthe solution I see is to avoid setting M_PriceList_Version_ID in the context - there is a query in CalloutOrder and CalloutInvoice to check the price list version when is not in the context - and then it sets it18:17
CarlosRuizif we simply never set it - then it must work18:17
lescanoI temporally solved here doing this, but this way we are ignoring a lot of future problems not related to pricelists18:17
lescanothere are similar problems with other variables18:18
CarlosRuizah I see - your comment points to clear any other potential dangerous field18:19
CarlosRuizyour comment to call clearWinContext18:20
lescanoyes. I've tried changing this in GridTab.query() (after testing if TabNo==0) but cleaned also important variables that shouldn't be cleaned18:22
CarlosRuizeven that way I see that InfoProduct is setting price list version - there must be another issue there18:23
*** CarlosRuiz has quit IRC18:29
*** CarlosRuiz has joined #idempiere18:30
*** ChanServ sets mode: +o CarlosRuiz18:30
lescanoso many callouts set context variables, and seems hard to handle them over GridTab queries. Maybe the solution would clean plus reset (similar when opening new GridTab) when querying18:32
*** CarlosRuiz has quit IRC18:40
*** CarlosRuiz has joined #idempiere18:40
*** ChanServ sets mode: +o CarlosRuiz18:40
CarlosRuizlescano - not just when querying - must be happening also when navigating to a different record with a different price list18:48
lescanohmm, isn't GridTab.query() always called when navigating and changing tab?18:51
CarlosRuizI checked and it seems is GridTab.setCurrentRow18:51
CarlosRuizI'm uploading a possible patch18:52
Not-604a[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2676 Attachment set to "IDEMPIERE-2676_v0.patch"18:53
Not-604a[IDEMPIERE] [~alan.lesc1], I'm uploading a possible patch following your suggestion and what we talked on IRC meeting. Can you please test it and provide feedback?18:53
Not-604a[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-267618:53
lescano@CarlosRuiz thank you, I will test right now18:55
lescanoCarlosRuiz, it doesn't work properly because setCurrentRow() is called by dataDelete(), dataRefresh(), etc... and context variables are cleared when they shouldn't be19:26
*** nmicoud_ has quit IRC19:48
CarlosRuizlescano, why?20:04
CarlosRuizwhenever you navigate to a new record - the context variables set for the old record are obsolete - and dangerous as in the case you found20:04
lescanoI agree, but the patch is removing variables when, for example, saving order line20:06
lescanothis may broke current funcionality20:08
CarlosRuizah yes - I see20:08
CarlosRuizchanged the if on GridTab to this one:20:10
CarlosRuizif (m_vo.TabLevel == 0 && m_currentRow != newCurrentRow)20:10
CarlosRuizseems it works better20:10
CarlosRuizah - found another ctx variable Base_Table_ID - must start with _WinInfo_ better20:18
CarlosRuizBaseTable_ID - very easy to collide with a real column20:18
lescanoyou're right20:21
lescanoseems to work now. I'll do more tests and compare if any variable is being wrongly removed using the patch20:22
CarlosRuizI think the ctx for IsSOTrx must be preserved also20:22
lescanohmm, for tables like c_payment this may be a problem20:24
lescanobecause both PO and SO records use same window Payment20:29
CarlosRuizI see two more window properties -> AutoCommit and AutoNew20:32
CarlosRuizmaybe this is not right approach  :-(20:32
CarlosRuizcould break other things that people trusted to put in context on plugins20:33
lescanoInitially, the best solution seems to clear the context for window ... but thinking better, it really may break third-party codes20:39
CarlosRuizanother approach is to fix the CalloutOrder and CalloutInvoice to not read the price list version from context20:42
CarlosRuizand thinking on a possible third approach could be to call the CalloutOrder.priceList when navigating20:43
lescanoI should go now, but I'll try to think another aproach20:44
CarlosRuizthat's not possible actually - but I've always thought could be a good addition to allow callouts on navigation20:44
lescanoyes, but...20:44
lescanoI see a problem with other variables20:44
CarlosRuizyep EnforcePriceLimit for example - which is set on CalloutOrder.pricelist20:45
Not-604a[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2676 Attachment set to "IDEMPIERE-2676_v1.patch"20:45
Not-604a[IDEMPIERE] Just for documentation of this process, a second patch checking for more variables - talking with [~alan.lesc1] on IRC seems like this is not the best approach20:45
Not-604a[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-267620:45
*** tbayen_ has quit IRC20:47
*** tbayen_ has joined #idempiere20:48
Not-604a[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2676 Attachment set to "IDEMPIERE-2676_v2_fixingCallouts.patch"20:49
Not-604a[IDEMPIERE] Another approach discussed is in patch IDEMPIERE-2676_v2_fixingCallouts.patch Fixing the callouts to avoid the context variable and always look for the price list version.20:49
Not-604a[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-267620:49
lescanoseems to solve pricelist issue. And we try to solve other context variables issues as they come in.20:50
*** norbertbede has quit IRC20:52
Not-604a[iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/20:55
Not-604a[iDempiere] globalqss 5a17930 - IDEMPIERE-2664 DB Extensibility issues20:55
lescanoAnyway , I'll keep thinking of another way to solve the context variables issue. Thank you very much Carlos, have a nice end of day20:56
CarlosRuizthanks to you Alan20:56
*** lescano has left #idempiere20:58
Not-604a[iDempiere2.1] jenkins built #237 completed (success) http://ci.idempiere.org/job/iDempiere2.1/237/21:12
Not-604a[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2676 Attachment set to "None"21:23
Not-604a[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-267621:23
Not-604a[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2676 Attachment set to "IDEMPIERE-2676_v1.patch"21:23
Not-604a[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-267621:24
Not-604a[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2676 Attachment set to "IDEMPIERE-2676_v3_CalloutOnNavigate.patch"21:43
Not-604a[IDEMPIERE] Another approach is to implement the ability to execute a callout when navigating to a new record - this is a very wanted feature that can serve for many other purposes - mostly setting or clearing context whenever you navigate to a new record. Tested the patch IDEMPIERE-2676_v3_CalloutOnNavigate.patch with this approach and it seems to work fine.21:43
Not-604a[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-267621:43
Not-604a[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2676 labels set to "+Patch"21:43
Not-604a[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-267621:43
*** norbertbede has joined #idempiere21:45
*** a42niem has quit IRC21:46
*** junooni has joined #idempiere22:02
junooniis there any user of adempiere from UAE22:03
Not-604a[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-268422:07
Not-604a[IDEMPIERE] Hi, tested this issue found that maybe is not needed - you just need to implement your own ProcessFactory and return your own custom ReportStarter. Just like the org.adempiere.report.jasper.ProcessFactory is returning the ReportStarter if the class is set like org.adempiere.report.jasper.ReportStarter or org.compiere.report.ReportStarter. Can you please check on your plugin if that approach works? Your22:07
Not-604aprocess factory requires also a service.ranking to be taken into account before the default which has service.ranking=122:07
Not-604a[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-268422:07
*** junooni has quit IRC22:11
*** norbertbede has quit IRC22:15
Not-604a[iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/23:18
Not-604a[iDempiere] globalqss 698e7e1 - IDEMPIERE-2673 Custom status line message not updating in different records23:18
Not-604a[IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2673 status set to "Resolved" -assignee set to "Carlos Antonio Ruiz Gomez" -resolution set to "Fixed"23:18
Not-604a[IDEMPIERE] Committed a different patch - for your test case on demo is better to use LEFT JOIN on C_OrderLine and M_Product so it can show information for orders without lines.23:18
Not-604a[IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-267323:18
Not-604a[iDempiere] CarlosRuiz_globalqss pushed 1 commit to development [+2/-0/±8] https://bitbucket.org/idempiere/idempiere/commits/23:22
Not-604a[iDempiere] globalqss aaf6911 - hg merge release-2.1 (merge release2.1 into development)23:22
*** CarlosRuiz has quit IRC23:24
Not-604a[iDempiere] jenkins built #1668 completed (success) http://ci.idempiere.org/job/iDempiere/1668/23:33
Not-604a[iDempiere2.1] jenkins built #238 completed (success) http://ci.idempiere.org/job/iDempiere2.1/238/23:42
*** mhernandezve has quit IRC23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!