*** CarlosRuiz has quit IRC | 00:16 | |
*** is-mw2 has joined #idempiere | 01:50 | |
*** is-mw has quit IRC | 01:50 | |
*** HansR42 has quit IRC | 02:02 | |
*** red1_ has joined #idempiere | 03:36 | |
*** ChanServ sets mode: +o red1_ | 03:36 | |
*** RecordingBot has joined #idempiere | 04:32 | |
Not-3656 | [IDEMPIERE] red1 created IDEMPIERE-2594 RMA does not allow repeat returns on same shipment. | 04:49 |
---|---|---|
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 04:49 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "SubtractPreviousRMA.patch" | 04:49 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 04:49 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "Balance3.png" | 04:50 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 04:50 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 description set to "During Customer RMA, the Shipment selected if has previous RMA still shows the same MovementQty/Delivered Qty for selection and then will give error during adding due to returned been higher than shipped before even though it was not completely returned in partial cases. With this patch, it shows original and moved qty so that when adding the balance, it goes through without issue. Testing wi | 04:53 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 04:53 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 status set to "Peer Review Queue" | 05:17 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 05:17 |
*** a42niem has joined #idempiere | 06:05 | |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "None" | 06:12 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 06:12 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "MultiPartialRMA.patch" | 06:13 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 06:13 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 description set to "During Customer RMA, the Shipment selected if has previous RMA still shows the same MovementQty/Delivered Qty for selection and then will give error during adding due to returned been higher than shipped before even though it was not completely returned in partial cases. With this patch, it shows original and moved qty so that when adding the balance, it goes through without issue. Testing wi | 06:17 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 06:17 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "BeforePatch.png" | 06:25 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 06:25 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 description set to "During Customer RMA, the Shipment selected if has previous RMA still shows the same MovementQty/Delivered Qty for selection and then will give error during adding due to returned been higher than shipped before even though it was not completely returned in partial cases !BeforePatch.png|thumbnail! With this patch, it shows original and moved qty so that when adding the balance, it goes throug | 06:25 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 06:25 |
*** KermitTheFragger has joined #idempiere | 06:28 | |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "IDEMPIERE-2594.patch" | 08:10 |
Not-3656 | [IDEMPIERE] Added non zero trigger for checkQty to disallow proceeding when balance is zero. More display friendly to use than not which allows passing thru of full qty and then stopping it. | 08:10 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 08:10 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 | 08:10 |
Not-3656 | [IDEMPIERE] Better patch - Added non zero trigger for checkQty to disallow proceeding when balance is zero. More display friendly to use than not which allows passing thru of full qty and then stopping it. | 08:11 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 08:11 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "ZeroCaseTrigger.png" | 08:19 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 08:19 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 | 08:20 |
Not-3656 | [IDEMPIERE] Better patch - Added non zero trigger for checkQty to disallow proceeding when balance is zero. More aesthetic to use than not which allows passing thru of full qty and then stopping it. !ZeroCaseTrigger.png|thumbnail! | 08:20 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 08:20 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 priority set to "Minor" | 08:20 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 08:20 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "None" | 08:28 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 08:28 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 status set to "Resolved" -resolution set to "Incomplete" | 08:40 |
Not-3656 | [IDEMPIERE] Testing with multi lines fail. Needing some more work | 08:40 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 08:40 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 status set to "Reopened" -resolution set to "None" | 08:40 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 08:40 |
*** red1_ has quit IRC | 09:23 | |
*** red1 has quit IRC | 12:21 | |
*** CarlosRuiz has joined #idempiere | 13:29 | |
*** ChanServ sets mode: +o CarlosRuiz | 13:29 | |
*** KermitTheFragger has quit IRC | 15:08 | |
*** norbertbede has joined #idempiere | 16:19 | |
norbertbede | hi | 16:19 |
norbertbede | any idea how first create invoice then match later generated shipment lines with invlice lines ? | 16:20 |
norbertbede | would be opt1. auto-allocate opt2. matching improvement opt3 any other idea | 16:21 |
CarlosRuiz | actually I see that flow is not supported on sales | 16:22 |
norbertbede | we could develop and commit | 16:22 |
norbertbede | what you suggest | 16:22 |
norbertbede | its stopper for us on project now | 16:22 |
CarlosRuiz | you can always invoice a sales order without shipping - and ship later | 16:23 |
norbertbede | just how "match" lines ? | 16:23 |
CarlosRuiz | no, not matching concept on sales - is direct | 16:23 |
norbertbede | c_invoiceline has c_inoutline_id | 16:24 |
norbertbede | that is what i want somehow match/allocate | 16:24 |
norbertbede | i know matching has additional matching process | 16:25 |
norbertbede | i see | 16:25 |
norbertbede | but independently when i will create first invoice then shipment i still want connect them | 16:25 |
norbertbede | ot thinking about improve generate shipment by - allocate shipment lines to invoice lines... | 16:31 |
norbertbede | this should be auto mode | 16:31 |
norbertbede | then reconcile those lines | 16:31 |
CarlosRuiz | I think they're linked in the orderline - the invoiceline points to an orderline - and same for the inoutline | 16:32 |
norbertbede | there should 1:N (1 orderline multiple shipment/invoice lines) relationship im not sure that is possible | 16:34 |
*** norbertbede1 has joined #idempiere | 16:52 | |
*** norbertbede has quit IRC | 16:55 | |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "None" | 17:09 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 17:09 |
Not-3656 | [iDempiere] CarlosRuiz_globalqss pushed 2 commits to development [+5/-0/±10] https://bitbucket.org/idempiere/idempiere/commits/ | 17:09 |
Not-3656 | [iDempiere] druiz_bxservice b45f48c - Add functionality to allow user preference window configurable | 17:09 |
Not-3656 | [iDempiere] globalqss 1861093 - IDEMPIERE-2556 User preferences window configurable / peer review | 17:09 |
Not-3656 | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2556 status set to "Resolved" -resolution set to "Fixed" | 17:09 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2556 | 17:09 |
*** norbertbede1 has quit IRC | 17:11 | |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "IDEMPIERE2594.patch" | 17:11 |
Not-3656 | [IDEMPIERE] Finally solved it and tested in multi line partial triple returns. Dirty hack seems to hold against the checkQty doing an init() to overwrite the returning balance. At least this fills such feature hole of RMA. | 17:11 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 17:11 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 status set to "Peer Review Queue" | 17:11 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 17:11 |
Not-3656 | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2556 | 17:12 |
Not-3656 | [IDEMPIERE] https://bitbucket.org/idempiere/idempiere/commits/b45f48 https://bitbucket.org/idempiere/idempiere/commits/1861093 | 17:12 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2556 | 17:12 |
*** red1 has joined #idempiere | 17:13 | |
red1 | hola CarlosRuiz i know its not wednesday meeting but i am motivated to conclude a https://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 17:14 |
red1 | it solves a feature hole in RMA as the way Material Receipts allow partial receipts | 17:14 |
red1 | now it works except there is a small workaround inside to make it more appealing during zero balance | 17:15 |
red1 | its not required by customer here in Austria but i was itching to make it work for fun :D | 17:16 |
CarlosRuiz | Hi RecordingBot | 17:18 |
CarlosRuiz | Hi red1 | 17:18 |
CarlosRuiz | :-) | 17:18 |
CarlosRuiz | I'm greeting the bot | 17:18 |
CarlosRuiz | reading the patch (not tested) | 17:19 |
CarlosRuiz | where you check the sum of other rmalines | 17:19 |
CarlosRuiz | you must check also for the status of the RMA | 17:20 |
red1 | in the patch it takes the SUM(rmal.Qty) from the previous | 17:20 |
CarlosRuiz | don't add if the RMA is draft or void | 17:20 |
red1 | the SQL done by Hengsin was already nearly perfect | 17:20 |
CarlosRuiz | I think usually just CL/CO must be taken into account | 17:20 |
red1 | hengsin SQL handles all that | 17:20 |
red1 | except that it stops repeat returns | 17:20 |
CarlosRuiz | which hengsin sql? | 17:21 |
red1 | CreateFromRMA | 17:21 |
red1 | it is copyrighted him | 17:21 |
red1 | though author was Teo | 17:22 |
CarlosRuiz | :-) you better check the author of the line | 17:22 |
CarlosRuiz | those lines were changed by elainetan | 17:22 |
CarlosRuiz | but - still | 17:22 |
red1 | anyway, the Create From button seems to be disable if its not allowed | 17:22 |
CarlosRuiz | <CarlosRuiz> where you check the sum of other rmalines | 17:23 |
CarlosRuiz | <CarlosRuiz> you must check also for the status of the RMA | 17:23 |
CarlosRuiz | <CarlosRuiz> don't add if the RMA is draft or void | 17:23 |
CarlosRuiz | <CarlosRuiz> I think usually just CL/CO must be taken into account | 17:23 |
red1 | i see | 17:23 |
CarlosRuiz | and the hack to change the qty from 0 to 1 sounds strange - I haven't tested but don't understand why you would need that | 17:23 |
red1 | ok i understand | 17:23 |
red1 | during a RMA.. customer may not return all items | 17:23 |
red1 | but later found more to return | 17:24 |
red1 | and he could not do that anymore | 17:24 |
red1 | thanks for your quick advice which you are correct | 17:25 |
red1 | i did not check if the RMA docstatus is not valid | 17:25 |
red1 | so i should be solving it before this wednesday meeting | 17:26 |
red1 | for it then | 17:26 |
*** norbertbede has joined #idempiere | 17:30 | |
CarlosRuiz | red1, | 17:32 |
CarlosRuiz | it could be a simpler patch | 17:32 |
CarlosRuiz | maybe you can test this approach | 17:33 |
CarlosRuiz | http://pastebin.com/5QF17Ru8 | 17:33 |
CarlosRuiz | is just to make the qty editable | 17:33 |
*** red1 has quit IRC | 17:45 | |
hieplq | hi @CarlosRuiz, i see you commit IDEMPIERE-2556. i want test it a bit. how to add new user preference value? | 18:05 |
CarlosRuiz | Hi hieplq | 18:07 |
CarlosRuiz | very easy now - you just need to add a column in the table AD_UserPreference | 18:08 |
CarlosRuiz | and add a field in the window "User Preference" | 18:08 |
CarlosRuiz | if you want the preference shown in the popup window - then you mark the field as quick entry | 18:09 |
hieplq | thanks, will test it. | 18:10 |
CarlosRuiz | great - any feedback is appreciated | 18:10 |
*** red1 has joined #idempiere | 18:15 | |
*** ChanServ sets mode: +o red1 | 18:15 | |
*** red1 has quit IRC | 18:17 | |
*** red1 has joined #idempiere | 18:18 | |
*** ChanServ sets mode: +o red1 | 18:18 | |
red1 | Thanks for the tip.. Studying it... | 18:20 |
red1 | Yes it can work in conjunction with the other patch which merely fetches the balance | 18:21 |
red1 | No need to go to detail line row | 18:22 |
red1 | Is so sexy now | 18:30 |
Not-3656 | [IDEMPIERE] hieplq updated IDEMPIERE-2556 | 18:31 |
Not-3656 | [IDEMPIERE] from my mistake, i see below case. 1. after add new column into table user preference (also create field for it). i forget run sync column. 2. I log out and can't login by error "ERROR: column "newpreference" does not exist" I suggest add try catch to line 69, class MUserPreference. with system user. show a warrning and still allow login to fix issue by run sync column. | 18:31 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2556 | 18:31 |
red1 | And the create from shipment window should also not show nil qty records | 18:31 |
red1 | And allow more shipment records | 18:32 |
red1 | In one RMA | 18:33 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 Attachment set to "editable minitable.png" | 19:09 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 19:09 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 | 19:11 |
Not-3656 | [IDEMPIERE] Carlos Ruiz gave the following single word change: diff -r 1861093d9de8 org.adempiere.ui/src/org/compiere/grid/CreateFromRMA.java --- a/org.adempiere.ui/src/org/compiere/grid/CreateFromRMA.java Fri Apr 24 12:08:56 2015 -0500 +++ b/org.adempiere.ui/src/org/compiere/grid/CreateFromRMA.java Fri Apr 24 12:32:57 2015 -0500 @@ -136,7 +136,7 @@ miniTable.setColumnClass(2, String.class, true); // 2-Product miniTable.setColumnClass(3, String.class, | 19:11 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 19:11 |
Not-3656 | [IDEMPIERE] red1 updated IDEMPIERE-2594 | 19:11 |
Not-3656 | [IDEMPIERE] Carlos Ruiz gave the following single word change: diff -r 1861093d9de8 org.adempiere.ui/src/org/compiere/grid/CreateFromRMA.java --- a/org.adempiere.ui/src/org/compiere/grid/CreateFromRMA.java Fri Apr 24 12:08:56 2015 -0500 +++ b/org.adempiere.ui/src/org/compiere/grid/CreateFromRMA.java Fri Apr 24 12:32:57 2015 -0500 @@ -136,7 +136,7 @@ miniTable.setColumnClass(2, String.class, true); // 2-Product miniTable.setColumnClass(3, String.class, | 19:11 |
Not-3656 | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2594 | 19:12 |
*** red1_ has joined #idempiere | 20:11 | |
*** red1_ has quit IRC | 20:38 | |
*** norbertbede has quit IRC | 21:27 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!