Not-311d | [IDEMPIERE] carlosruiz_globalqss created IDEMPIERE-2566 Print Format labels wrong after opening Report Wizard | 01:23 |
---|---|---|
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2566 | 01:23 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2566 Attachment set to "jira-capture-screenshot-20150407-202136-607.png" | 01:23 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2566 | 01:23 |
Not-311d | [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ | 01:25 |
Not-311d | [iDempiere] globalqss b3a7808 - IDEMPIERE-2566 Print Format labels wrong after opening Report Wizard | 01:25 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2566 status set to "Resolved" -assignee set to "Carlos Antonio Ruiz Gomez" -resolution set to "Fixed" | 01:25 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2566 | 01:25 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2561 | 01:35 |
Not-311d | [IDEMPIERE] [~hieplq], line 66 is supposed to revert the sysconfig when an exception is found - below comment "reset to N on exception" - perhaps is because the cache is not reset after that? | 01:35 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2561 | 01:35 |
Not-311d | [iDempiere] CarlosRuiz_globalqss pushed 2 commits to release-2.1 [+0/-0/±8] https://bitbucket.org/idempiere/idempiere/commits/ | 02:07 |
Not-311d | [iDempiere] hieplq 9cd67c5 - IDEMPIERE-2544:to more warning compiler hidden good warning leak resource | 02:07 |
Not-311d | [iDempiere] globalqss 44e38bb - IDEMPIERE-2447 Migration script from packin adding unnecessary updates / fix issue -> Unknown column reference type=null | 02:07 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2555 | 02:08 |
Not-311d | [IDEMPIERE] thanks [~hieplq], applied the patch and commented on ticket IDEMPIERE-2544 | 02:08 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2555 | 02:08 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2544 status set to "Reopened" -assignee set to "hieplq" -resolution set to "None" | 02:09 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2544 | 02:09 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2544 status set to "Resolved" -resolution set to "Fixed" | 02:10 |
Not-311d | [IDEMPIERE] Thank you very much [~hieplq], I applied the patch you uploaded on IDEMPIERE-2555 related to this ticket. Good catch!! | 02:10 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2544 | 02:10 |
Not-311d | [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±2] https://bitbucket.org/idempiere/idempiere/commits/ | 02:20 |
Not-311d | [iDempiere] tsvikruha 4199d3a - IDEMPIERE-2238 Printformat header not translated (report) | 02:20 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2238 status set to "Resolved" -resolution set to "Fixed" | 02:20 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2238 | 02:20 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2544 status set to "Reopened" -resolution set to "None" | 02:21 |
Not-311d | [IDEMPIERE] Reopening this - there are still some patches worthy to review (like Dead Code and generic) | 02:21 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2544 | 02:21 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2544 labels set to "+Patch" | 02:21 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2544 | 02:21 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2536 status set to "Resolved" -assignee set to "Carlos Antonio Ruiz Gomez" -resolution set to "Won't Fix" | 02:24 |
Not-311d | [IDEMPIERE] [~steveh], I think this behavior is correct as changing quantity can potentially change the price - because of price list breaks or discount breaks. | 02:24 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2536 | 02:24 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2529 | 02:36 |
Not-311d | [IDEMPIERE] Hi [~muriloht], I see the issue but don't understand why is it needed - the m_userpreference is just used locally to preselect the records on the lists. | 02:36 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2529 | 02:36 |
*** CarlosRuiz has quit IRC | 02:45 | |
Not-311d | [IDEMPIERE] muriloht updated IDEMPIERE-2529 | 02:47 |
Not-311d | [IDEMPIERE] Hi Carlos, I don't know if it's a problem or a expected behavior, maybe you can reproduce: - login do demo.idempiere.com as "superuser @ idempiere.com" (check select role) - the default selected Client is "client", then change to "System" and login - Logout - then try to login again with "superuser @ idempiere.com" (again, check select role) - and again the "client" Client is the default selected. The preferences from the last session was | 02:47 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2529 | 02:47 |
*** norbertbede has joined #idempiere | 04:49 | |
*** hieplq has joined #idempiere | 04:53 | |
*** HansR42 has joined #idempiere | 06:10 | |
Not-311d | [IDEMPIERE] Yu created IDEMPIERE-2567 RfQResponseRank's message is hard coding,cannot translate | 06:24 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2567 | 06:24 |
*** hieplq has quit IRC | 06:31 | |
*** KermitTheFragger has joined #idempiere | 06:33 | |
*** nmicoud has joined #idempiere | 06:37 | |
*** a42niem has joined #idempiere | 06:38 | |
*** KermitTheFragger has quit IRC | 07:08 | |
*** KermitTheFragger has joined #idempiere | 07:09 | |
*** Vyrlokar has joined #idempiere | 07:17 | |
Vyrlokar | Hello everyone | 07:17 |
HansR42 | Hi | 07:48 |
*** is-mw has joined #idempiere | 08:04 | |
Not-311d | [IDEMPIERE] hieplq updated IDEMPIERE-2561 status set to "Open" | 08:11 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2561 | 08:11 |
Not-311d | [IDEMPIERE] hieplq updated IDEMPIERE-2561 status set to "Closed" -resolution set to "Cannot Reproduce" | 08:13 |
Not-311d | [IDEMPIERE] thanks [~carlosruiz_globalqss], just review code. you correct and hash password do in a transaction. will investigate my issue late. | 08:13 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2561 | 08:13 |
*** hieplq has joined #idempiere | 08:15 | |
*** HansR42 has quit IRC | 08:50 | |
*** hieplq has quit IRC | 10:02 | |
*** adnan_T has joined #idempiere | 10:09 | |
*** is-mw has quit IRC | 11:05 | |
*** is-mw has joined #idempiere | 11:37 | |
*** hieplq has joined #idempiere | 11:49 | |
*** CarlosRuiz has joined #idempiere | 12:57 | |
*** ChanServ sets mode: +o CarlosRuiz | 12:57 | |
*** CarlosRuiz has quit IRC | 12:58 | |
*** CarlosRuiz has joined #idempiere | 12:58 | |
*** ChanServ sets mode: +o CarlosRuiz | 12:58 | |
*** ocurieles has joined #idempiere | 13:00 | |
CarlosRuiz | Good Morning | 13:00 |
nmicoud | Bonjour | 13:01 |
a42niem | Guten Tag | 13:01 |
*** HideakiHagiwara has joined #idempiere | 13:01 | |
nmicoud | Could you have a look at https://groups.google.com/d/msg/idempiere/ykc9dB-FdHs/y4qIfBo4-XoJ please ? I'd like to know what is the best practice | 13:01 |
CarlosRuiz | sure - brb - give me 5 min | 13:14 |
nmicoud | thanks | 13:14 |
CarlosRuiz | nmicoud, I get it - but it sounds like a bad practice to use X instead of M | 13:25 |
nmicoud | how should i do if i just want to update a record ? | 13:25 |
CarlosRuiz | why is that? I didn't understand -> "as i didn't want to control update" | 13:25 |
nmicoud | i don't want to get into the beforeSave method | 13:26 |
nmicoud | as it could failed | 13:26 |
nmicoud | in fact,i just need to do a "update c_invoice set... = abc where c_invoice_id = 123;" | 13:26 |
*** smartjsp has joined #idempiere | 13:26 | |
CarlosRuiz | ok, I'll change LCO according to that | 13:28 |
nmicoud | but means that it should be done in all plugins, right ? | 13:29 |
CarlosRuiz | yes - I have seen the same bug if somebody tries to use GenericPO | 13:30 |
nmicoud | in my plugin, i just check for the table name, never on the object itself. So, maybe instead of making a tableName.equals("C_Invoice"), we should do a po instanceof MInvoice | 13:30 |
nmicoud | i also see it :D | 13:30 |
nmicoud | Besides, i haven't had the time to review the ticket for updating the print format name. Just do the https://idempiere.atlassian.net/browse/IDEMPIERE-2554 (add acknowledgement of receipt on email). If you could see if is ok to integrate. Also, you send me your POC on Special Editor (ability to update fields for processed records). I think i will try to implement it for our instance. Would you be ok to publish it on bitbucket in | 13:33 |
Vyrlokar | nmicoud, heya | 13:35 |
nmicoud | hi | 13:36 |
Vyrlokar | You're interested in having payments work on a fixed day, with X days delay, right? | 13:37 |
nmicoud | yes, date invoiced + x days and then take the last day of month | 13:37 |
Vyrlokar | I'm the guy who replied to your post on the google group | 13:37 |
nmicoud | ah ok :) | 13:37 |
Vyrlokar | Our use cases are slightly different, as you're interested in payments without schedule, while I'm interested in payments with schedule. | 13:39 |
Vyrlokar | but we could definitively try and solve both use cases | 13:39 |
nmicoud | sure | 13:39 |
Vyrlokar | payments without schedule are handled exclusively by database functions AFAIK | 13:39 |
CarlosRuiz | sure nmicoud - please publish that | 13:40 |
nmicoud | yes, there is no field "due date" on c_invoice (could be interesting, but that's another debate :)) | 13:40 |
nmicoud | ok, Carlos, will do that | 13:40 |
Vyrlokar | nmicoud, well, there is, you only need to define a payment term schedule with a single payment term | 13:41 |
Vyrlokar | the database function for your use case is paymenttermduedate(paymentterm_id numeric, docdate timestamp with time zone) | 13:41 |
Vyrlokar | nmicoud, it's weird (but not that unusual, it's IMHO similar to how there's a swing client and a ZK client) that there are two ways to do the same thing, with different features | 13:43 |
Vyrlokar | schedules don't handle fixed days, at all | 13:44 |
CarlosRuiz | nmicoud, committed and compiled | 13:45 |
CarlosRuiz | http://ci.idempiere.org/job/globalqss-iDempiere-LCO/ | 13:45 |
nmicoud | thanks carlos, need to update mine now :) | 13:45 |
Vyrlokar | nmicoud, On my side, things would be much simpler if the part where due date is calculated was in a function outside of the constructor, as that way, it could be overridden in a module, via a model factory | 13:49 |
a42niem | we once created a paymenttermbasedate for a customer so he got some flexibility for strange paymentterm constructs | 13:51 |
nmicoud | not simple to implement as it would change the behaviour which was created since compiere times | 13:51 |
*** smartjsp has quit IRC | 13:51 | |
a42niem | it needed a callout to set it from invoicedate and change some views | 13:52 |
nmicoud | but perhaps we could add a DueDate on C_Invoice (in trunk, using a jira ticket). This would be filled with the sql function. And then you will be able to update it in plugin | 13:52 |
Vyrlokar | nmicoud, if you're replying to me, then yes, it would be a simple matter of making the constructor call something like "set due date" for the payment term, as that could be then overridden | 13:53 |
nmicoud | yes Vyrlokar | 13:53 |
Vyrlokar | nmicoud, invoices don't necessarily have a single due date, that's why making it a field of c_invoice would not work for me | 13:53 |
nmicoud | a42niem : as it need to update views, it's hard to maintain in plugin | 13:54 |
nmicoud | Vyrlokar : due dates could be found on C_Invoice or C_InvoicePaySchedule | 13:54 |
nmicoud | according to the payment term | 13:55 |
Vyrlokar | nmicoud, my usual use cases are X% immediate, Y% 30 days, and X% 30 days, Y% 60 days | 13:55 |
Vyrlokar | all dates with possible fixed day | 13:55 |
nmicoud | when you say 'fixed day', is it equal to 'last day of month' ? | 13:56 |
Vyrlokar | again, I solve this with an event handler (not the most elegant solution, but I believe it is the only way it can work without hacking core) | 13:56 |
Vyrlokar | Last day of month is one possibility | 13:56 |
*** aguerra has joined #idempiere | 13:57 | |
Vyrlokar | common fixed days are 25th, last day of month, and 1st | 13:57 |
aguerra | buenos dias a todos!!! | 13:57 |
Vyrlokar | buenos dias aguerra | 13:57 |
nmicoud | hi aguerra | 13:57 |
CarlosRuiz | Hi Alejandro | 13:58 |
aguerra | Salu2 a @Vyrlokar @nmicoud @CarlosRuiz | 13:58 |
CarlosRuiz | nmicoud, I think maybe taking FixMonthDay=31 as last day of month | 13:58 |
nmicoud | seems it could have problem with february | 13:59 |
nmicoud | see https://groups.google.com/d/msg/idempiere/VA3707UDwN8/rQxjrgbehJ4J | 13:59 |
CarlosRuiz | yes - I mean - changing the DB function to use 31 as LDOM | 14:00 |
nmicoud | i don't understand :( | 14:01 |
nmicoud | you want to change the db function ? or just put a differnt value in c_paymentterm ? | 14:01 |
CarlosRuiz | I think actual algorithm doesn't make sense - to say duedate=05/02/15 when you said FixMonthDay = 30 & FixMonthCutOff = 30 | 14:01 |
Vyrlokar | CarlosRuiz, what would be the right course of action for requesting a small refactoring of MInvoicePaySchedule, so the dates are handled in a separate function that is then called by the constructor that takes a MInvoice and a MPaySchedule? That way, that function would be overriddable in a plugin, to incorporate advanced functionality | 14:02 |
CarlosRuiz | Antoni, where is it being calculated actually? | 14:04 |
Vyrlokar | right now, lines 164 to 167 of org.compiere.model.MInvoicePaySchedule in the org.adempiere.base project | 14:06 |
Vyrlokar | those 4 lines right now handle the due date calculation for schedules, in a simple way (just add days, no fixed date, no next business day) | 14:07 |
Vyrlokar | CarlosRuiz, as the calculation it done in a nonstandard constructor, I don't see a way to override it in a plugin | 14:09 |
*** CarlosRuiz has quit IRC | 14:10 | |
*** CarlosRuiz has joined #idempiere | 14:10 | |
*** ChanServ sets mode: +o CarlosRuiz | 14:10 | |
Vyrlokar | WB CarlosRuiz | 14:11 |
Vyrlokar | nmicoud, at least we can curse weird business requirements together ;) | 14:12 |
nmicoud | :D | 14:12 |
CarlosRuiz | and c_paymentterm.afterdelivery is not used anywhere - another candidate for inactivate | 14:12 |
CarlosRuiz | Antoni, so you can create an EventHandler (ModelValidator) to change the date on beforeSave as I see | 14:15 |
Vyrlokar | CarlosRuiz, That's how I've done it, but it's hackish | 14:15 |
CarlosRuiz | paymenttermduedate is not taking into account the p.IsNextBusinessDay flag | 14:16 |
Vyrlokar | CarlosRuiz, as it will overwrite user input on the first save, when created manually, IIRC | 14:16 |
Vyrlokar | CarlosRuiz, I created a plugin that extends MInvoicePaySchedule, adds some extra fields and an updateDueDate function, and then use an EventHandler to call that function on PO_AFTER_NEW | 14:18 |
Vyrlokar | I'm testing it right now | 14:19 |
* Vyrlokar wonders if his opened a can of worms by asking on payment schedules, as it seems like the code is old... | 14:20 | |
* Vyrlokar also wonders on the purpose of MOrderPaySchedule - Is it for proforma invoices, or something like that? Speaking of which, how are proforma invoices actually handled in iDempiere? | 14:21 | |
Vyrlokar | CarlosRuiz, MOrderPaySchedule looks like a copy of MInvoicePaySchedule with some minor changes, with the original copyright left intact, even if that file never existed in Compiere | 14:23 |
CarlosRuiz | check http://www.adempiere.com/FS01_Commitment_AR_AP | 14:23 |
Vyrlokar | CarlosRuiz, thanks, interesting. However, since dates are calculated from order date for orders, and from invoice date for invoices, unless invoice date==order date, the schedules will not match... | 14:27 |
* Vyrlokar had to argue with his boss that it's not possible to have the system calculate due dates based on weird things like shipment dates for shipments that don't exist yet, so as they say in his country "Esta curado de espanto" | 14:29 | |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2567 labels set to "complex-easy language" | 14:37 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2567 | 14:37 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2529 | 14:41 |
Not-311d | [IDEMPIERE] [~muriloht] I was not able to reproduce the case you described. Maybe is caused because another person opened a session with superuser in Client while you were there as System I checked the context in both cases and it's not affecting any context variable - that's why I ask if there is a need to use the m_userpreference out of RolePanel. | 14:41 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2529 | 14:41 |
*** KermitTheFragger has quit IRC | 14:59 | |
Not-311d | [iDempiere] CarlosRuiz_globalqss pushed 2 commits to release-2.1 [+0/-0/±2] https://bitbucket.org/idempiere/idempiere/commits/ | 15:16 |
Not-311d | [iDempiere] hieplq fadbf6b - IDEMPIERE-2565:NPE when run init client without input city of country has "Allow Cities out of List" = false | 15:16 |
Not-311d | [iDempiere] globalqss 2a9e282 - IDEMPIERE-2565 - found transaction not rolled back when initial client setup was failing with an exception | 15:16 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2565 status set to "Resolved" -assignee set to "hieplq" -resolution set to "Fixed" | 15:16 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2565 | 15:16 |
*** norbertbede has joined #idempiere | 15:17 | |
nmicoud | gtg, (if you have the time CarlosRuiz, could you look at https://idempiere.atlassian.net/browse/IDEMPIERE-2554) please ? thanks and cu later | 15:18 |
*** nmicoud has quit IRC | 15:19 | |
*** norbertbede has quit IRC | 15:26 | |
Not-311d | [iDempiere] CarlosRuiz_globalqss pushed 1 commit to development [+0/-0/±2] https://bitbucket.org/idempiere/idempiere/commits/ | 15:28 |
Not-311d | [iDempiere] nmicoud 3b5a8fa - IDEMPIERE-2554 Mail : add acknowledgement of receipt | 15:28 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2554 status set to "Resolved" -assignee set to "Nicolas Micoud" -resolution set to "Fixed" | 15:28 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2554 | 15:28 |
Not-311d | [IDEMPIERE] hieplq created IDEMPIERE-2568 Can't user build in function of jasper report by miss lib | 15:31 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2568 | 15:31 |
Not-311d | [IDEMPIERE] hieplq updated IDEMPIERE-2568 status set to "Peer Review Queue" | 15:32 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2568 | 15:32 |
Not-311d | [iDempiere] CarlosRuiz_globalqss pushed 2 commits to development [+0/-0/±3] https://bitbucket.org/idempiere/idempiere/commits/ | 15:41 |
Not-311d | [iDempiere] globalqss 3b73421 - IDEMPIERE-2554 Mail : add acknowledgement of receipt - minor peer review serialVersionUID | 15:41 |
Not-311d | [iDempiere] hieplq 2d379de - IDEMPIERE-2563:packout with datatype without sql make NPE | 15:41 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2563 status set to "Resolved" -assignee set to "hieplq" -resolution set to "Fixed" | 15:41 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2563 | 15:41 |
*** HideakiHagiwara has quit IRC | 15:43 | |
Not-311d | [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ | 15:46 |
Not-311d | [iDempiere] brerp 2c3c76a - ModelValidationEngine - old style validator needed to osgi events work and FireFacts OSGI event is not sent | 15:46 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2530 status set to "Resolved" -assignee set to "Murilo Habermann Torquato" -resolution set to "Fixed" | 15:47 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2530 | 15:47 |
*** adnan_T has quit IRC | 15:48 | |
*** norbertbede has joined #idempiere | 15:57 | |
Vyrlokar | gtg, cya everybody | 15:57 |
norbertbede | hi alls | 15:57 |
CarlosRuiz | bye Antoni - hi norbertbede | 15:57 |
Vyrlokar | hi norbertbede and bye | 15:57 |
*** Vyrlokar has quit IRC | 15:58 | |
norbertbede | looking for experience zk7/idempiere3/nginx(gzip). im getting extremly frequently message Unexpected token < (Syntax Error) | 15:59 |
norbertbede | reported> https://idempiere.atlassian.net/browse/IDEMPIERE-2496 | 15:59 |
norbertbede | im totally confused :( how to catch | 15:59 |
norbertbede | i found lot topics about potential issues with javascripts | 16:00 |
norbertbede | when a googled | 16:00 |
norbertbede | when i googled | 16:01 |
*** ocurieles has quit IRC | 16:16 | |
*** allgood has joined #idempiere | 16:16 | |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2558 Attachment set to "IDEMPIERE-2558_PR.patch" | 16:16 |
Not-311d | [IDEMPIERE] Thanks [~hieplq], tests on this went fine but I have some concerns to solve: 1 - attaching a patch with minor fixes IDEMPIERE-2558_PR.patch 2 - the classes X_ must not be changed manually - on next release all the X_ classes are regenerated and your comment about deprecation is lost 3 - In MPasswordHistory.getPasswordHistoryForCheck - the usage of sysconfig USER_LOCKING_MAX_PASSWORD_AGE_DAY is not related - locking is a different feature t | 16:16 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2558 | 16:16 |
*** allgood has left #idempiere | 16:17 | |
*** ocurieles has joined #idempiere | 16:18 | |
*** norbertbede has quit IRC | 16:40 | |
*** ocurieles has quit IRC | 16:43 | |
*** norbertbede has joined #idempiere | 16:43 | |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2564 Attachment set to "IDEMPIERE-2564_CR.patch" | 17:01 |
Not-311d | [IDEMPIERE] Thanks [~tsvikruha] - can you please test the attached alternate patch IDEMPIERE-2564_CR.patch | 17:01 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2564 | 17:01 |
Not-311d | [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ | 17:05 |
Not-311d | [iDempiere] hieplq 64c918b - IDEMPIERE-2552:sometime has NPE in CLogErrorBuffer | 17:05 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2552 status set to "Resolved" -assignee set to "hieplq" -resolution set to "Fixed" | 17:05 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2552 | 17:05 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2551 Tested By set to "Carlos Antonio Ruiz Gomez" | 17:20 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2551 | 17:20 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2551 labels set to "+Patch" | 17:20 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2551 | 17:20 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2562 | 17:27 |
Not-311d | [IDEMPIERE] Hi [~HansR42a], the patch seems outdated with the current code. I don't understand what is the issue - can you please provide steps to reproduce and what is the actual result vs the expected result? | 17:27 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2562 | 17:27 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2525 | 17:30 |
Not-311d | [IDEMPIERE] it sounds like a massive change to core classes - I think in such case is better to use EventHandler to modify the behavior | 17:30 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2525 | 17:31 |
hieplq | hi @CarlosRuiz. i has a issue relate "allow null for city when "Allow Cities out of List = false". not sure it's issue or feature, | 17:32 |
hieplq | maybe you can confirm https://groups.google.com/forum/#!topic/idempiere/7IDj_fnrQEE | 17:32 |
CarlosRuiz | so, your question is if city must be mandatory? | 17:33 |
CarlosRuiz | I think it must - a location without a city is untraceable | 17:33 |
hieplq | @CarlosRuiz it's ok if always mandatory but when i "Allow Cities out of List = true" it's don't request input city | 17:46 |
CarlosRuiz | and the city field is filled? | 17:47 |
hieplq | no. | 17:48 |
hieplq | i fill same case "Allow Cities out of List = false" | 17:48 |
CarlosRuiz | allow cities out of list = false -> must force to choose a city from the list - is an autocomplete list so it shows the cities when you type the first letters | 17:50 |
CarlosRuiz | allow cities out of list = true -> it means it allows you to type a city in that field that is not on the list | 17:51 |
*** nmicoud has joined #idempiere | 17:52 | |
hieplq | thanks, just confirm to know it's issue or feature. | 17:52 |
hieplq | with me it still is a issue :D | 17:53 |
CarlosRuiz | is it working that way? | 17:53 |
hieplq | i know what you mean. but my case is "Allow Cities out of List = false" => user can don't input city and location save success | 17:55 |
hieplq | "Allow Cities out of List = true" => user don't input city (null) and location save unseccess | 17:55 |
hieplq | in "Allow Cities out of List = true", user even input nothing in city text. | 17:57 |
hieplq | i test in location window (exact from init client) not from location dialog | 17:58 |
CarlosRuiz | ah - that's intended for location dialog | 17:58 |
CarlosRuiz | you would need to add validations on initial client setup to control that | 17:58 |
hieplq | ok. i want ask other issue relate config hazelcast. | 18:00 |
hieplq | i explain at https://groups.google.com/forum/#!topic/idempiere/aWgia827mZ0 | 18:00 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-1752 | 18:03 |
Not-311d | [IDEMPIERE] [~hieplq], I reproduce the issue about the NPE - but your patch didn't solve it - still throwing the same exception. | 18:03 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1752 | 18:03 |
CarlosRuiz | hieplq, haven't tested using two different ports in adempiere simultaneously | 18:04 |
CarlosRuiz | but it doesn't sound as hazelcast - maybe zk session? | 18:05 |
hieplq | mabey hazelcast effect session | 18:05 |
CarlosRuiz | you can try disabling the hazelcast plugin to check if that's the cause | 18:05 |
hieplq | it's ok when i access my local instance and demo instance in same browse | 18:05 |
hieplq | but it's not importace, will investigate late. | 18:07 |
hieplq | about IDEMPIERE-1752 i will re-test it. | 18:07 |
hieplq | hi @CarlosRuiz, what NPE message you see when test IDEMPIERE-1752. | 18:15 |
hieplq | if at org.adempiere.base.callout.CostAdjustmentCalloutFactory$CostAdjustmentLineProduct.start(CostAdjustmentCalloutFactory.java:69) | 18:15 |
nmicoud | CarlosRuiz, i will publish Special Editor sources soon. But i can't find the email you sent me - neither the google forum thread i create for explaining the purpose - could you send me it again please ? as everything was well explain in it, i will copy/paste the content | 18:16 |
hieplq | you must resolve IDEMPIERE-1744 to see cast issue of IDEMPIERE-1752 | 18:20 |
hieplq | and patch in IDEMPIERE-1752 is for cast issue not NPE issue | 18:21 |
*** aguerra has quit IRC | 18:22 | |
CarlosRuiz | IDEMPIERE-1744 doesn't have a patch | 18:25 |
CarlosRuiz | nmicoud, is an email from 28/02/2014 | 18:26 |
CarlosRuiz | two emails indeed | 18:26 |
nmicoud | i think i've deleted it :( | 18:26 |
nmicoud | or i move it somewhere, but seems a very dark place | 18:27 |
CarlosRuiz | resent both | 18:27 |
nmicoud | thanks | 18:27 |
CarlosRuiz | brb - @ lunch | 18:28 |
nmicoud | bon ap' :) | 18:28 |
*** hieplq has quit IRC | 18:35 | |
norbertbede | hi nmicoud are you running already version 3 or still 2,1 | 18:36 |
nmicoud | hi norbert 2.1 | 18:37 |
norbertbede | are you planning to upgrade ? | 18:40 |
nmicoud | not now | 18:41 |
nmicoud | maybe near the end of year, but nothing is planned | 18:43 |
norbertbede | ok. | 18:44 |
norbertbede | thanks | 18:44 |
Not-311d | [IDEMPIERE] norbert.bede created IDEMPIERE-2569 ZK7 - Unexpected token in DSP/CSS | 19:14 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2569 | 19:14 |
*** herdem has joined #idempiere | 19:46 | |
Not-311d | [iDempiere] CarlosRuiz_globalqss pushed 3 commits to release-2.1 [+0/-0/±5] https://bitbucket.org/idempiere/idempiere/commits/ | 20:32 |
Not-311d | [iDempiere] nmicoud 70ba3c3 - IDEMPIERE-2235 Report wizard : ability to change the print format name (integrated by Carlos Ruiz, PO.java didn't pass) | 20:32 |
Not-311d | [iDempiere] globalqss ab74bc8 - IDEMPIERE-2235 Report wizard : ability to change the print format name - peer review | 20:32 |
Not-311d | [iDempiere] globalqss 86139d7 - IDEMPIERE-1135 Report wizard not clearing order items | 20:32 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2235 status set to "Resolved" -resolution set to "Fixed" | 20:34 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2235 | 20:34 |
nmicoud | oh! thanks for integrating #2235 Carlos :) | 20:34 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-1135 status set to "Resolved" -assignee set to "Carlos Antonio Ruiz Gomez" -resolution set to "Fixed" | 20:34 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1135 | 20:34 |
CarlosRuiz | thanks to you for developing that | 20:35 |
nmicoud | :) | 20:35 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2530 | 20:37 |
Not-311d | [IDEMPIERE] https://bitbucket.org/idempiere/idempiere/commits/2c3c76a | 20:37 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2530 | 20:37 |
*** a42niem has quit IRC | 20:41 | |
Not-311d | [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±2] https://bitbucket.org/idempiere/idempiere/commits/ | 21:02 |
Not-311d | [iDempiere] globalqss 507e137 - IDEMPIERE-2531 Archive Viewer open EnterQuery tab instead of ViewResult / IDEMPIERE-556 / IDEMPIERE-724 | 21:02 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2531 | 21:02 |
Not-311d | [IDEMPIERE] Found this was caused by a commit on IDEMPIERE-724 that reverted the behavior implemented with IDEMPIERE-556 | 21:02 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2531 | 21:03 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2531 status set to "Resolved" -assignee set to "Carlos Antonio Ruiz Gomez" -resolution set to "Fixed" | 21:03 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2531 | 21:03 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss created IDEMPIERE-2570 Form reports stacking on same page when issued for several records | 21:18 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2570 | 21:18 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2570 status set to "Resolved" -resolution set to "Fixed" | 21:18 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2570 | 21:18 |
Not-311d | [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ | 21:18 |
Not-311d | [iDempiere] globalqss ab1da70 - IDEMPIERE-2570 Form reports stacking on same page when issued for several records | 21:18 |
Not-311d | [iDempiere] CarlosRuiz_globalqss pushed 1 commit to development [+0/-0/±20] https://bitbucket.org/idempiere/idempiere/commits/ | 21:22 |
Not-311d | [iDempiere] globalqss 50617e9 - hg merge release-2.1 (merge release2.1 into development) | 21:22 |
*** nmicoud has quit IRC | 21:30 | |
*** norbertbede has quit IRC | 21:45 | |
Not-311d | [iDempiere] CarlosRuiz_globalqss pushed 16 commits to development [+12/-0/±61] https://bitbucket.org/idempiere/idempiere/commits/ | 22:04 |
Not-311d | [iDempiere] globalqss 865ea2d - creating branch experimental | 22:04 |
Not-311d | [iDempiere] dpansheriya 5af9b8c - IDEMPIERE-2389 Print format and View Report selection on process dialog. | 22:04 |
Not-311d | [iDempiere] hieplq 0ba4b6e - IDEMPIERE-2389:Print format and Report type selection on process dialog add summary checkbox | 22:04 |
Not-311d | [iDempiere] hieplq 64e5917 - IDEMPIERE-2389:Print format and Report type selection on process dialog remove duplicate code (IDEMPIERE-1882) remain some issue relate UI | 22:04 |
Not-311d | [iDempiere] hieplq 003da45 - IDEMPIERE-2389:Print format and Report type selection on process dialog add language combobox | 22:04 |
Not-311d | [iDempiere] hieplq 46ad165 - Merge with development | 22:04 |
Not-311d | [iDempiere] hieplq 1697e4f - IDEMPIERE-2532:issue relate show dialog when run process fix to show parameter dialog at center of info window | 22:04 |
Not-311d | [iDempiere] hieplq be8284b - IDEMPIERE-1657: common show window with mask cover below case + refactor * 1. show a dialog => show mask * 2. process a event * 2.1. show other dialog => show mask * 2.1. hidden dialog in step 1 => hidden mask * 3. result dialog show without mask | 22:04 |
Not-311d | [iDempiere] hieplq 20eacd2 - IDEMPIERE-2532:issue relate show dialog when run process show message success event hasn't any m_logs show message error same success (use ProcessInfoDialog not use FDialog) | 22:04 |
Not-311d | [iDempiere] hieplq 737d701 - IDEMPIERE-2389:Print format and Report type selection on process dialog recreate serialVersionUID fix show dialog when auto run process | 22:04 |
Not-311d | [iDempiere] hieplq 3ddb7cb - IDEMPIERE-2389:Print format and Report type selection on process dialog update Mandatory flag when load parameter value from save | 22:04 |
Not-311d | [iDempiere] globalqss abc0c8b - IDEMPIERE-2389 Print format and View Report selection on process dialog. / fix oracle migration script | 22:04 |
Not-311d | [iDempiere] hieplq d289afe - Merge with development | 22:04 |
Not-311d | [iDempiere] hieplq a8aef8f - IDEMPIERE-2389 Print format and View Report selection on process dialog NPE: when click save at process (not report) parameter | 22:04 |
Not-311d | [iDempiere] globalqss 32b868d - merge development into experimental | 22:04 |
Not-311d | [iDempiere] globalqss 89c06bb - merge experimental into development | 22:04 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-1657 status set to "Resolved" -resolution set to "Fixed" | 22:06 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-1657 | 22:06 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2532 status set to "Resolved" -assignee set to "hieplq" -resolution set to "Fixed" | 22:07 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2532 | 22:07 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2389 | 22:07 |
Not-311d | [IDEMPIERE] Ready [~hieplq], I integrated the experimental branch into development - please finish the layout of fields directly in development and we can use now the experimental repository for another ticket - maybe all the pending info window changes? | 22:08 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2389 | 22:08 |
Not-311d | [iDempiere] CarlosRuiz_globalqss pushed 3 commits to development [+0/-0/±71] https://bitbucket.org/idempiere/idempiere/commits/ | 22:52 |
Not-311d | [iDempiere] hieplq a6181c5 - IDEMPIERE-2544:to more warning compiler hidden good warning warning from build.xml | 22:52 |
Not-311d | [iDempiere] hieplq 62732d5 - IDEMPIERE-2544:to more warning compiler hidden good warning dead code | 22:52 |
Not-311d | [iDempiere] hieplq 1bab594 - IDEMPIERE-2544:to more warning compiler hidden good warning generic type warning | 22:52 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2544 status set to "Resolved" -resolution set to "Fixed" | 22:58 |
Not-311d | [IDEMPIERE] Thanks [~hieplq] for solving all those warnings - I integrated buildWarning, DeadCode and genericWarning. The leakResourceWarning maybe deserves more research to avoid the big impact. I think is worthy to check also all the deprecation from jasper (maybe upgrade jasper library and then solve the deprecations). Also research if is possible to let eclipse know that DB.close is a valid statement to close rs and pstmt. | 22:58 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2544 | 22:58 |
Not-311d | [iDempiere] CarlosRuiz_globalqss pushed 1 commit to release-2.1 [+0/-0/±1] https://bitbucket.org/idempiere/idempiere/commits/ | 23:08 |
Not-311d | [iDempiere] globalqss 20e82fc - IDEMPIERE-2555 Another leak found in CommissionCalc | 23:08 |
*** jmpiloq has quit IRC | 23:14 | |
*** CarlosRuiz has quit IRC | 23:20 | |
*** jmpiloq has joined #idempiere | 23:27 | |
Not-311d | [IDEMPIERE] hieplq updated IDEMPIERE-2544 status set to "Reopened" -resolution set to "None" | 23:29 |
Not-311d | [IDEMPIERE] thanks [~carlosruiz_globalqss], will kill deprecation warning. we will update jasper lib to 6.x? | 23:29 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2544 | 23:29 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2420 status set to "Reopened" -resolution set to "None" | 23:45 |
Not-311d | [IDEMPIERE] is this issue solved? the is no commit related | 23:45 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2420 | 23:45 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2420 status set to "Resolved" -assignee set to "Heng Sin Low" -resolution set to "Fixed" | 23:46 |
Not-311d | [IDEMPIERE] Ah, sorry - 2 commits linked | 23:46 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2420 | 23:46 |
Not-311d | [IDEMPIERE] carlosruiz_globalqss updated IDEMPIERE-2490 | 23:47 |
Not-311d | [IDEMPIERE] clicking on the Feedback when Home is shown (with dashboards) kill the server with this error | 23:47 |
Not-311d | [IDEMPIERE] http://idempiere.atlassian.net/browse/IDEMPIERE-2490 | 23:47 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!